Liumihust patch add null pointer exception in FsDatasetImpl.checkBlock() #254
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockIteratorImpl.nextBlock() will look for the blocks in the source volume, if there are no blocks any more,it will retrurn null to DiskBalancer.getBlockToCopy().However, the DiskBalancer.getBlockToCopy() will check whether it's a valid block. when I look into the FsDatasetSpi.isValidBlock(), I find that it doesn't check the null pointer! in fact,we firstly need to check whether it's null or not, or exception will occur. this bug is hard to find, because the DiskBalancer hardly copy all the data of one volume to others.even if some times we may copy all the data of one volume to other volumes, when the bug occurs, the copy process has done. However, when we try to copy all the data of two or more volumes to other volumes in more than one step, the thread will be shut down,which is caused by the bug above. the bug can fixed by two ways: 1)before the call of FsDatasetSpi.isValidBlock(), we check the null pointer 2)check the null pointer inside the implementation of FsDatasetSpi.isValidBlock()
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
navina **PR 1: AzureClient + AzureConfig** (current PR) Author: PawasChhokra <Jaimatadi1$> Reviewers: Navina Ramesh <navina@apache.org> Closes apache#254 from PawasChhokra/AzureStorageClient
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
…pache#5790) (apache#254) Co-authored-by: Xing Lin <linxingnku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional PR for the same bug