HADOOP-16080. hadoop-aws does not work with hadoop-client-api #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
aajisaka
reviewed
Dec 7, 2020
| import java.util.concurrent.LinkedBlockingQueue; | ||
| import java.util.concurrent.ThreadPoolExecutor; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.*; |
There was a problem hiding this comment.
oops will do - I forgot to set this up on my new laptop
Rethinking this, using String.format is slower than the template usages because it creates a string error message before checking the condition. Now I think we need to create our internal checkArgument/checkState/checkNotNull functions and it can be done in a separate JIRA. |
|
💔 -1 overall
This message was automatically generated. |
|
@sunchao Would you fix the findbugs warning or ignore it by adding an entry to the findbugs-exclude.xml? I'm +1 if that is addressed.
|
|
@aajisaka sure added to findbugs-exclude.xml - note that this PR doesn't touch anything on the method though. |
|
💔 -1 overall
This message was automatically generated. |
…#2510). Contributed by Chao Sun
sunchao
force-pushed
the
HADOOP-16080-branch-3.3
branch
from
eb08721 to
8600f19
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Backported https://issues.apache.org/jira/browse/HADOOP-17186 to fix the javadoc error in hadoop-aws module. |
|
Note: In branch-3.3, there is a findbugs warning in hadoop-cloud-storage-project/hadoop-cos. I'm going to cherry-pick HADOOP-17138 in #2538 to fix the warning. |
|
Thanks @aajisaka ! |
sunchao
added a commit
to sunchao/hadoop
that referenced
this pull request
Jan 9, 2021
…buted by Chao Sun (apache#2522)
steveloughran
pushed a commit
that referenced
this pull request
Mar 9, 2021
Contributed by Chao Sun. (Cherry-picked via PR #2575)
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…e#2522) Contributed by Chao Sun. (Cherry-picked via PR apache#2575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a backport from #2510)
This does the following:
ListenableFutureas well asListeningExecutorServicefrom public interfaces, so that modules such ashadoop-awsandhadoop-aliyuncan consume the class from hadoop-client-api without running into Guava conflicts.