Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17389. KMS should log full UGI principal. #2476

Merged
merged 2 commits into from
Dec 4, 2020
Merged

HADOOP-17389. KMS should log full UGI principal. #2476

merged 2 commits into from
Dec 4, 2020

Conversation

amahussein
Copy link
Contributor

Daryn Sharp reported that the kms-audit log only logs the short username:

OK[op=GENERATE_EEK, key=key1, user=hdfs, accessCount=4206, interval=10427ms]

In this example, it's impossible to tell which NN(s) requested EDEKs when they are all lumped together.

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 36s trunk passed
+1 💚 compile 20m 54s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 17m 50s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 36s trunk passed
+1 💚 mvnsite 0m 45s trunk passed
+1 💚 shadedclient 17m 7s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 38s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 0m 52s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 50s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 20m 23s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 20m 23s the patch passed
+1 💚 compile 18m 24s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 18m 24s the patch passed
+1 💚 checkstyle 0m 39s the patch passed
+1 💚 mvnsite 0m 43s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 19s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 38s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 39s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 0m 55s the patch passed
_ Other Tests _
+1 💚 unit 3m 41s hadoop-kms in the patch passed.
-1 ❌ asflicense 0m 56s /patch-asflicense-problems.txt The patch generated 2 ASF License warnings.
163m 56s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/1/artifact/out/Dockerfile
GITHUB PR #2476
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 05afac15988b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0705033
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/1/testReport/
Max. process+thread count 665 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

LGTM. Would you remove the @SuppressWarnings annotations?
The license warnings have been fixed by https://issues.apache.org/jira/browse/HADOOP-17390

@aajisaka aajisaka requested a review from jojochuang November 30, 2020 04:51
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 47s trunk passed
+1 💚 compile 19m 49s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 17m 4s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 41s trunk passed
+1 💚 mvnsite 0m 45s trunk passed
+1 💚 shadedclient 17m 12s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 39s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 38s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 0m 56s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 53s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 19m 4s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 19m 4s the patch passed
+1 💚 compile 17m 4s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 17m 4s the patch passed
+1 💚 checkstyle 0m 35s the patch passed
+1 💚 mvnsite 0m 42s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 28s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 37s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 0m 36s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 0m 59s the patch passed
_ Other Tests _
+1 💚 unit 3m 40s hadoop-kms in the patch passed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
155m 6s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/2/artifact/out/Dockerfile
GITHUB PR #2476
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6dd073e356a6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 60201cb
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/2/testReport/
Max. process+thread count 668 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2476/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jbrennan333
jbrennan333 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me as well.

@aajisaka aajisaka merged commit 8c234fc into apache:trunk Dec 4, 2020
@aajisaka
Copy link
Member

aajisaka commented Dec 4, 2020

Merged. Thank you @amahussein for your contribution and thank you @jbrennan333 for your review!

asfgit pushed a commit that referenced this pull request Dec 7, 2020
@amahussein @jbrennan333
HADOOP-17389. KMS should log full UGI principal. (#2476)
30c9f39 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Jim Brennan <jbrennan@apache.org>
(cherry picked from commit 8c234fc)
asfgit pushed a commit that referenced this pull request Dec 7, 2020
@amahussein @jbrennan333
HADOOP-17389. KMS should log full UGI principal. (#2476)
d9bf607 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Jim Brennan <jbrennan@apache.org>
(cherry picked from commit 8c234fc)
asfgit pushed a commit that referenced this pull request Dec 7, 2020
@jbrennan333
HADOOP-17389. KMS should log full UGI principal. (#2476) Contributed …
486da59 
…by Ahmed Hussein

    Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
    Reviewed-by: Jim Brennan <jbrennan@apache.org>
asfgit pushed a commit that referenced this pull request Dec 8, 2020
@amahussein @Hexiaoqiao
HADOOP-17389. KMS should log full UGI principal. (#2476)
39b4f9d 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Jim Brennan <jbrennan@apache.org>
(cherry picked from commit 8c234fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrennan333 jbrennan333 jbrennan333 approved these changes

@aajisaka aajisaka aajisaka approved these changes

@jojochuang jojochuang Awaiting requested review from jojochuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amahussein @hadoop-yetus @aajisaka @jbrennan333