HADOOP-17371. Bump Jetty to the latest version 9.4.34. Contributed by Wei-Chiu Chuang. #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
jojochuang
commented
Nov 10, 2020
There was a problem hiding this comment.
Do not merge. The shading is broken by this:
[ERROR] Found artifact with unexpected contents: '/Users/weichiu/sandbox/hadoop/hadoop-client-modules/hadoop-client-minicluster/target/hadoop-client-minicluster-3.4.0-SNAPSHOT.jar'
Please check the following and either correct the build or update
the allowed list with reasoning.
jetty-dir.css
|
💔 -1 overall
This message was automatically generated. |
|
The latest one is good. @aajisaka do you want to take another look? |
|
No unit tests run in the Jenkins job. I'll run the unit tests in hadoop-common module locally before +1. |
aajisaka
requested changes
Nov 11, 2020
There was a problem hiding this comment.
TestPseudoAuthenticator failed after the upgrade:
[INFO] Running org.apache.hadoop.security.authentication.client.TestPseudoAuthenticator
[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.63 s <<< FAILURE! - in org.apache.hadoop.security.authentication.client.TestPseudoAuthenticator
[ERROR] testAnonymousDisallowed(org.apache.hadoop.security.authentication.client.TestPseudoAuthenticator) Time elapsed: 0.463 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[Authentication requir]ed> but was:<[Unauthoriz]ed>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.apache.hadoop.security.authentication.client.TestPseudoAuthenticator.testAnonymousDisallowed(TestPseudoAuthenticator.java:68)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
|
In addition, TestKMS failed. |
|
Ok... so this is getting more involved. It turns out that Jetty 9.4.21 has a breaking change (https://github.com/eclipse/jetty.project/pull/3912/files) I don't feel that strong to include jetty-server just so that we can set a custom error message. We could update the test code instead too. |
|
(The above update addresses the issue with TestPseudoAuthenticator. Still trying to understand TestKMS errors... |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
TestPseudoAuthenticator, TestAuthenticationFilter and TestKMS are fixed in the last PR. |
|
(and apparently updating to 9.4.35 brought more unshaded files which I'll look into) |
|
💔 -1 overall
This message was automatically generated. |
|
Thank you for the work here everyone. |
… Wei-Chiu Chuang. Change-Id: I972c3120ec37ea024de9ea43afcb164457be1ea8
Change-Id: I0db7b8ac45df0c6afb951c72c799a511f30b3230
…age. Change-Id: Ifa9dcc9fcf6ba1dc4b0d96c66c64a6cddab3d120
Change-Id: I2595590289bc203c13c82024ba611d69fcca249b
Change-Id: Idab5e694d69b0960981fea7a39476ec767aa57bf
Change-Id: Id82219e354066e68c783b46f293c56c8874b4498
Change-Id: I4405e030399504e715dc7bb9675300f079215a70
jetty-security 9.4.35 adds a new dependency jetty-util-ajax. Exclude it to make shading pass. Change-Id: I9f62d76cd74bc89ede2c28d440dbe316545393aa
…mage servlet. Change-Id: Id4aaf799a481902a2ca32f25399d454d376066f1
jojochuang
force-pushed
the
HADOOP-17371
branch
from
9e8ccf8 to
f7a601e
Compare
|
@Sushmasree-28 thanks for the review. I updated the PR to address these two tetsts. However, please note that we use sendError() throughout the codebase. Unless they break tests I suggest we postpone any further changes to a future jira. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed test is this "TestBalancer.testMaxIterationTime:1669 Unexpected iteration runtime: 4007ms > 3.5s" |
brahmareddybattula
approved these changes
Jan 4, 2021
jojochuang
added a commit
to jojochuang/hadoop
that referenced
this pull request
Apr 9, 2021
… Wei-Chiu Chuang. (apache#2453) (cherry picked from commit 66ee0a6) (cherry picked from commit 6340ac8) Conflicts: hadoop-client-modules/hadoop-client-minicluster/pom.xml Change-Id: I673ac136922740cb1d426cb9593aa1bd3e9acd32
jojochuang
added a commit
that referenced
this pull request
Apr 20, 2021
…OP-17625 to update Jetty to 9.4.39. (#2879) * HADOOP-17371. Bump Jetty to the latest version 9.4.34. Contributed by Wei-Chiu Chuang. (#2453) (cherry picked from commit 66ee0a6) (cherry picked from commit 6340ac8) Conflicts: hadoop-client-modules/hadoop-client-minicluster/pom.xml Change-Id: I673ac136922740cb1d426cb9593aa1bd3e9acd32 * HADOOP-17621. hadoop-auth to remove jetty-server dependency. (#2865) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit dac60b8) (cherry picked from commit 1110b03) * HADOOP-17625. Update to Jetty 9.4.39. (#2870) Reviewed-by: cxorm <lianp964@gmail.com> (cherry picked from commit 6040e86) (cherry picked from commit 7f75355)
jojochuang
added a commit
to jojochuang/hadoop
that referenced
this pull request
Apr 20, 2021
…OP-17625 to update Jetty to 9.4.39. (apache#2879) * HADOOP-17371. Bump Jetty to the latest version 9.4.34. Contributed by Wei-Chiu Chuang. (apache#2453) (cherry picked from commit 66ee0a6) (cherry picked from commit 6340ac8) Conflicts: hadoop-client-modules/hadoop-client-minicluster/pom.xml Change-Id: I673ac136922740cb1d426cb9593aa1bd3e9acd32 * HADOOP-17621. hadoop-auth to remove jetty-server dependency. (apache#2865) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit dac60b8) (cherry picked from commit 1110b03) * HADOOP-17625. Update to Jetty 9.4.39. (apache#2870) Reviewed-by: cxorm <lianp964@gmail.com> (cherry picked from commit 6040e86) (cherry picked from commit 7f75355) (cherry picked from commit 8ff61f9) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java Change-Id: I465f6003b6f4c5df9c41c83eac3738bac56403e1
jojochuang
added a commit
that referenced
this pull request
Apr 20, 2021
…OP-17625 to update Jetty to 9.4.39. (#2879) (#2935) * HADOOP-17371. Bump Jetty to the latest version 9.4.34. Contributed by Wei-Chiu Chuang. (#2453) (cherry picked from commit 66ee0a6) (cherry picked from commit 6340ac8) Conflicts: hadoop-client-modules/hadoop-client-minicluster/pom.xml Change-Id: I673ac136922740cb1d426cb9593aa1bd3e9acd32 * HADOOP-17621. hadoop-auth to remove jetty-server dependency. (#2865) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit dac60b8) (cherry picked from commit 1110b03) * HADOOP-17625. Update to Jetty 9.4.39. (#2870) Reviewed-by: cxorm <lianp964@gmail.com> (cherry picked from commit 6040e86) (cherry picked from commit 7f75355) (cherry picked from commit 8ff61f9) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java Change-Id: I465f6003b6f4c5df9c41c83eac3738bac56403e1
eubnara
added a commit
to eubnara/hadoop
that referenced
this pull request
Mar 15, 2023
…buted by Wei-Chiu Chuang. (apache#2453)" This reverts commit 6340ac8.
eubnara
added a commit
to eubnara/hadoop
that referenced
this pull request
Mar 15, 2023
…buted by Wei-Chiu Chuang. (apache#2453)" This reverts commit 6340ac8.
jojochuang
added a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
… Wei-Chiu Chuang. (apache#2453) (cherry picked from commit 66ee0a6) Conflicts: hadoop-client-modules/hadoop-client-minicluster/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-project/pom.xml Change-Id: I9f0fb7b91ba07a4b722bf9f8c31f07a1a2bd0896 (cherry picked from commit e6b712bb2a57bf3cc29af7bb6cf0010e54c786c5) (cherry picked from commit 764e56807397200cb03164ee976d02cad202c09e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute