Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17309. Javadoc warnings and errors are ignored in the precommit jobs #2391

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

aajisaka
Copy link
Member

Set doclint option explicitly in maven-javadoc-plugin.

JIRA: https://issues.apache.org/jira/browse/HADOOP-17309

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 29m 32s trunk passed
+1 💚 compile 0m 21s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 0m 22s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 mvnsite 0m 26s trunk passed
+1 💚 shadedclient 45m 3s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 24s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 23s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 0m 12s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 0m 12s the patch passed
+1 💚 mvnsite 0m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 13m 54s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
_ Other Tests _
+1 💚 unit 0m 18s hadoop-project in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
65m 33s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2391/1/artifact/out/Dockerfile
GITHUB PR #2391
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux f5637a5e9c53 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cc57eeb
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2391/1/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2391/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aajisaka Thanks for working on this. I also confirmed that this PR catches javadoc warnings and errors of JDK11 on Ubuntu. +1.

@aajisaka aajisaka merged commit 3a0922f into apache:trunk Oct 19, 2020
@aajisaka aajisaka deleted the HADOOP-17309 branch October 19, 2020 01:47
@aajisaka
Copy link
Member Author

Thank you @tasanuma

aajisaka added a commit that referenced this pull request Oct 19, 2020
aajisaka added a commit that referenced this pull request Oct 19, 2020
aajisaka added a commit that referenced this pull request Oct 19, 2020
aajisaka added a commit that referenced this pull request Oct 19, 2020
…t jobs. (#2391)

(cherry picked from commit 3a0922f)

 Conflicts:
	hadoop-project/pom.xml
asfgit pushed a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants