HDFS-15634 [WIP] Invalidate replica on decommissioning/decommissioned… #2388
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goiri
reviewed
Oct 15, 2020
| return storedBlock; | ||
| } | ||
|
|
||
| // If there are enough live replicas, start invalidating | ||
| // decommissioned + decommissioning replicas | ||
| private boolean shouldInvalidateDecommissionedRedundancy(NumberReplicas num, |
There was a problem hiding this comment.
It makes sense. Maybe we should describe some of the JIRA description in this method to explain what we are doing in the high level.
| if(storedBlock.getBlockUCState() == BlockUCState.COMMITTED && | ||
|
|
||
| // if block is still under construction, then done for now | ||
| if (!storedBlock.isCompleteOrCommitted()) { |
There was a problem hiding this comment.
Why do we move this block here?
BTW we can leave it as a single if with a return.
There was a problem hiding this comment.
I felt quite confused with the original structure since the early return was put after the statements it is trying to avoid..
I can make it a single return no big deal.
|
💔 -1 overall
This message was automatically generated. |
|
Will put another patch with UT soon |
jojochuang
added
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Datanodes
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute