Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 #2330

Merged
merged 3 commits into from
Sep 24, 2020
Merged

HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 #2330

merged 3 commits into from
Sep 24, 2020

Conversation

aryangupta1998
Copy link
Contributor

@aryangupta1998 aryangupta1998 commented Sep 23, 2020 •
edited
Loading

jQuery version is being upgraded from jquery-3.4.1.min.js to jquery-3.5.1.min.js
Jira Link - https://issues.apache.org/jira/browse/HDFS-15593

Tested Manually. Also, NN UI is working fine.
Screenshot 2020-09-23 at 8 35 49 PM

@tasanuma
Copy link
Member

Thanks for working on this, @aryangupta1998.

There are still some codes using jquery-3.4.1. Could you also fix them?

$ find . -type f | grep -v target | xargs grep 'jquery-3.4' 2> /dev/null
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml:            <exclude>src/main/resources/webapps/static/jquery/jquery-3.4.1.min.js</exclude>
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/JQueryUI.java:        .script(root_url("static/jquery/jquery-3.4.1.min.js"))
./LICENSE-binary:hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/jquery-3.4.1.min.js
./hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/journal/index.html:<script type="text/javascript" src="/static/jquery-3.4.1.min.js">
./hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/explorer.html:    <script type="text/javascript" src="/static/jquery-3.4.1.min.js">

@aryangupta1998
Copy link
Contributor Author

Thanks, @tasanuma for the review. I have addressed the comments.

tasanuma
tasanuma approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1.

@tasanuma tasanuma changed the title HDFS-15593. Hadoop - Upgrade to jQuery 3.5.1 HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 Sep 24, 2020
@tasanuma tasanuma merged commit 486ddb7 into apache:trunk Sep 24, 2020
@tasanuma
Copy link
Member

Merged to trunk. Thanks for your contribution, @aryangupta1998.

bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Sep 27, 2020
@aryangupta1998 @bilaharith
HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 (apache#2330)
185bad9 
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
asfgit pushed a commit that referenced this pull request May 13, 2021
@aryangupta1998 @jojochuang
HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 (#2330)
28079e9 
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
(cherry picked from commit 486ddb7)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@aryangupta1998 @risdenk
HADOOP-17283. Hadoop - Upgrade to jQuery 3.5.1 (apache#2330)
a6ee8ae 
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
(cherry picked from commit 486ddb7)
Change-Id: I8545ccac6ddf2b18d99e4c20a86f9e5a3ea3be6f
(cherry picked from commit cb15fe7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasanuma tasanuma tasanuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryangupta1998 @tasanuma