HADOOP-17126. implement un-guava Precondition checkNotNull #2143

amahussein · 2020-07-16T00:55:30Z

NOTICE

As part In order to replace Guava Preconditions, we need to implement our own versions of the API.
This PR is to create checkNotNull in a new package dubbed unguava.
This is splitting the PR that was opened previously #2134

The plan is as follows

create a new package org.apache.hadoop.util.unguava;
create class Validate
implement org.apache.hadoop.util.unguava.Validate with the following interface
- checkNotNull(final T obj)
- checkNotNull(final T reference, final Object errorMessage)
- checkNotNull(final T obj, final String message, final Object... values)
- checkNotNull(final T obj,final Supplier<String> msgSupplier)
guava.preconditions used String.lenientformat which suppressed exceptions caused by string formatting of the exception message . So, in order to avoid changing the behavior, the implementation catches exceptions triggered by building the message (IllegalFormat, InsufficientArg, NullPointer..etc)
After merging the new class, we can replace guava.Preconditions.checkNotNull by unguava.Validate.checkNotNull
We need the change to go into trunk, 3.1, 3.2, and 3.3

Similar Jiras will be created to implement checkState, checkArgument, checkIndex

amahussein · 2020-07-16T01:00:22Z

CC @steveloughran I split the changes in PR #2134 . For practicality and convenience, I decided to breakdown the code implementation. Each PR focuses on a single helper.

hadoop-yetus · 2020-07-16T04:15:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	22m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 31s	trunk passed
+1 💚	compile	19m 22s	trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	compile	16m 42s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 51s	trunk passed
+1 💚	mvnsite	1m 27s	trunk passed
+1 💚	shadedclient	16m 38s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 44s	hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 4s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 13s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 48s	the patch passed
+1 💚	compile	18m 39s	the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	javac	18m 39s	the patch passed
+1 💚	compile	16m 46s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	16m 46s	the patch passed
+1 💚	checkstyle	0m 51s	the patch passed
+1 💚	mvnsite	1m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 4s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 44s	hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 3s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 21s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		170m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/1/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 990aeaa523a2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `1f71c4a`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/1/testReport/
Max. process+thread count	1664 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

other than import ordering, production code is good. Test-wise, you should move to LambdaTestUtils.intercept. It's much easier to use and reports failures better

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/unguava/Validate.java

...-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/unguava/TestValidate.java

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/unguava/Validate.java

hadoop-yetus · 2020-07-17T23:44:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
-1 ❌	mvninstall	19m 59s	root in trunk failed.
+1 💚	compile	19m 27s	trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	compile	16m 43s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 50s	trunk passed
+1 💚	mvnsite	1m 27s	trunk passed
+1 💚	shadedclient	16m 21s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 44s	hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 2s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 14s	Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	2m 11s	hadoop-common-project/hadoop-common in trunk has 2 extant findbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	18m 42s	the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	javac	18m 42s	the patch passed
+1 💚	compile	16m 35s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	16m 35s	the patch passed
+1 💚	checkstyle	0m 51s	the patch passed
+1 💚	mvnsite	1m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 54s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 44s	hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 3s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 23s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		148m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 055c3b2d06d9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `2ba44a7`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/artifact/out/branch-mvninstall-root.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/testReport/
Max. process+thread count	3416 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-07-22T13:12:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 16s	Docker failed to build yetus/hadoop:cce5a6f6094.

Subsystem	Report/Notes
GITHUB PR	#2143
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2143/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-07-31T07:41:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 29s	trunk passed
+1 💚	compile	20m 50s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 40s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 24s	trunk passed
+1 💚	shadedclient	16m 43s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 45s	hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 0s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 12s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 10s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	20m 55s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 55s	the patch passed
+1 💚	compile	18m 29s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	18m 29s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	mvnsite	1m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 53s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 37s	hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 58s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 53s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		157m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/3/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f85016c7de1c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `05b3337`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/3/testReport/
Max. process+thread count	3255 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-11-11T21:11:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 53s		trunk passed
+1 💚	compile	20m 48s		trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	compile	18m 49s		trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	checkstyle	0m 54s		trunk passed
+1 💚	mvnsite	1m 40s		trunk passed
+1 💚	shadedclient	21m 16s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	javadoc	1m 40s		trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗	spotbugs	2m 39s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 36s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 2s		the patch passed
+1 💚	compile	24m 41s		the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	javac	24m 41s		the patch passed
+1 💚	compile	21m 35s		the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	javac	21m 35s		the patch passed
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 41s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	19m 40s		patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	1m 8s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1.
+1 💚	javadoc	1m 46s		the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	findbugs	2m 51s		the patch passed
			_ Other Tests _
+1 💚	unit	10m 39s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		192m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/6/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 467ec93bb0b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `188ebb5`
Default Java	Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/6/testReport/
Max. process+thread count	3249 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-03T19:52:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	4m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 52s		trunk passed
+1 💚	compile	20m 55s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 43s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 27s		trunk passed
+1 💚	shadedclient	18m 52s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 10s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 47s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 8s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 4s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 5s		the patch passed
+1 💚	compile	26m 48s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	26m 48s		the patch passed
+1 💚	compile	24m 35s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	24m 35s		the patch passed
+1 💚	checkstyle	1m 14s		the patch passed
+1 💚	mvnsite	1m 43s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	18m 12s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 9s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 52s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	2m 58s		the patch passed
			_ Other Tests _
+1 💚	unit	19m 8s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 6s		The patch does not generate ASF License warnings.
		206m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/7/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c8cf890e6c74 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `182623d`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/7/testReport/
Max. process+thread count	1297 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/7/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

HADOOP-17126. use LambdaTestUtils.intercept and fix import ordering [HADOOP-17126]: replace lambda expressions with if/then Author: Ahmed Hussein <a@ahussein.me>

hadoop-yetus · 2021-02-04T18:53:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 33s		trunk passed
+1 💚	compile	20m 37s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 54s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 33s		trunk passed
+1 💚	shadedclient	16m 0s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 6s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 40s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	2m 22s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 20s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s		the patch passed
+1 💚	compile	19m 57s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	19m 57s		the patch passed
+1 💚	compile	18m 0s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	18m 0s		the patch passed
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 31s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 20s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 4s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 39s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	2m 22s		the patch passed
			_ Other Tests _
+1 💚	unit	17m 10s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		175m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/8/artifact/out/Dockerfile
GITHUB PR	#2143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8bcf12113992 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5f34271`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/8/testReport/
Max. process+thread count	2996 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2143/8/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

amahussein · 2021-02-15T15:51:35Z

@steveloughran and @daryn-sharp, Are you guys okay with the current version?

amahussein mentioned this pull request Jul 16, 2020

HADOOP-17123. remove guava Preconditions from Hadoop-common module #2134

Closed

steveloughran requested changes Jul 17, 2020

View reviewed changes

amahussein force-pushed the hadoop-17126 branch 2 times, most recently from 76dc374 to e4e57ae Compare July 17, 2020 21:11

amahussein force-pushed the hadoop-17126 branch from e4e57ae to beb843d Compare July 22, 2020 12:52

amahussein force-pushed the hadoop-17126 branch from beb843d to 08c8cb4 Compare November 11, 2020 17:57

amahussein force-pushed the hadoop-17126 branch from 08c8cb4 to 3d60bb9 Compare February 3, 2021 16:24

HADOOP-17126. implement non-guava Precondition checkNotNull

54437cf

HADOOP-17126. use LambdaTestUtils.intercept and fix import ordering [HADOOP-17126]: replace lambda expressions with if/then Author: Ahmed Hussein <a@ahussein.me>

amahussein force-pushed the hadoop-17126 branch from 3d60bb9 to 54437cf Compare February 4, 2021 15:57

amahussein closed this May 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17126. implement un-guava Precondition checkNotNull #2143

HADOOP-17126. implement un-guava Precondition checkNotNull #2143

Uh oh!

amahussein commented Jul 16, 2020

Uh oh!

amahussein commented Jul 16, 2020

Uh oh!

hadoop-yetus commented Jul 16, 2020

Uh oh!

steveloughran left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Jul 17, 2020

Uh oh!

hadoop-yetus commented Jul 22, 2020

Uh oh!

hadoop-yetus commented Jul 31, 2020

Uh oh!

hadoop-yetus commented Nov 11, 2020

Uh oh!

hadoop-yetus commented Feb 3, 2021

Uh oh!

hadoop-yetus commented Feb 4, 2021

Uh oh!

amahussein commented Feb 15, 2021

Uh oh!

Uh oh!

HADOOP-17126. implement un-guava Precondition checkNotNull #2143

HADOOP-17126. implement un-guava Precondition checkNotNull #2143

Uh oh!

Conversation

amahussein commented Jul 16, 2020

NOTICE

Uh oh!

amahussein commented Jul 16, 2020

Uh oh!

hadoop-yetus commented Jul 16, 2020

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Jul 17, 2020

Uh oh!

hadoop-yetus commented Jul 22, 2020

Uh oh!

hadoop-yetus commented Jul 31, 2020

Uh oh!

hadoop-yetus commented Nov 11, 2020

Uh oh!

hadoop-yetus commented Feb 3, 2021

Uh oh!

hadoop-yetus commented Feb 4, 2021

Uh oh!

amahussein commented Feb 15, 2021

Uh oh!

Uh oh!