Skip to content

[HADOOP-17109] Replace Guava base64Url and base64 with Java8+ base64 #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[HADOOP-17109] Replace Guava base64Url and base64 with Java8+ base64 #2122

wants to merge 2 commits into from

Conversation

dengliming
Copy link
Member

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 27m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 14 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 57s Maven dependency ordering for branch
+1 💚 mvninstall 22m 36s trunk passed
+1 💚 compile 21m 2s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 17m 41s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 2m 55s trunk passed
+1 💚 mvnsite 13m 21s trunk passed
+1 💚 shadedclient 32m 4s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 31s hadoop-auth in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 37s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 30s hadoop-kms in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 34s hadoop-registry in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 44s hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 40s hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 35s hadoop-yarn-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 33s hadoop-yarn-server-nodemanager in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-client in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 35s hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-azure in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 28s hadoop-cos in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 9m 51s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 0m 43s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 0m 42s hadoop-cloud-storage-project/hadoop-cos in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 9m 46s the patch passed
+1 💚 compile 20m 18s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
-1 ❌ javac 20m 18s root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 2 new + 1975 unchanged - 2 fixed = 1977 total (was 1977)
+1 💚 compile 17m 34s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌ javac 17m 34s root-jdkPrivateBuild-1.8.0_252-8u252-b09-118.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-118.04-b09 generated 2 new + 1868 unchanged - 2 fixed = 1870 total (was 1870)
-0 ⚠️ checkstyle 2m 57s root: The patch generated 20 new + 389 unchanged - 7 fixed = 409 total (was 396)
+1 💚 mvnsite 15m 45s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 17s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 31s hadoop-auth in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 38s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 29s hadoop-kms in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 30s hadoop-registry in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 44s hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 43s hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 33s hadoop-yarn-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 34s hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 33s hadoop-azure in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 30s hadoop-cos in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 10m 7s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 29m 10s the patch passed
_ Other Tests _
+1 💚 unit 3m 45s hadoop-auth in the patch passed.
-1 ❌ unit 9m 52s hadoop-common in the patch passed.
-1 ❌ unit 2m 41s hadoop-kms in the patch passed.
-1 ❌ unit 1m 15s hadoop-registry in the patch passed.
+1 💚 unit 2m 10s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 119m 43s hadoop-hdfs in the patch passed.
+1 💚 unit 10m 56s hadoop-hdfs-rbf in the patch passed.
+1 💚 unit 4m 9s hadoop-yarn-common in the patch passed.
+1 💚 unit 22m 12s hadoop-yarn-server-nodemanager in the patch passed.
-1 ❌ unit 93m 9s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 27m 51s hadoop-yarn-client in the patch passed.
+1 💚 unit 8m 13s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 20m 23s hadoop-yarn-services-core in the patch passed.
+1 💚 unit 2m 27s hadoop-yarn-services-api in the patch passed.
+1 💚 unit 1m 46s hadoop-aws in the patch passed.
+1 💚 unit 1m 45s hadoop-azure in the patch passed.
+1 💚 unit 0m 38s hadoop-cos in the patch passed.
+1 💚 asflicense 1m 15s The patch does not generate ASF License warnings.
636m 59s
Reason Tests
Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken
hadoop.security.token.TestToken
hadoop.security.token.delegation.web.TestDelegationTokenAuthenticationHandlerWithMocks
hadoop.crypto.key.kms.server.TestKMS
hadoop.registry.server.dns.TestRegistryDNS
hadoop.registry.server.dns.TestSecureRegistryDNS
hadoop.hdfs.web.TestWebHdfsTokens
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.web.TestWebHdfsUrl
hadoop.hdfs.TestSecureEncryptionZoneWithKMS
hadoop.hdfs.TestEncryptionZonesWithKMS
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.namenode.TestReencryptionWithKMS
hadoop.hdfs.TestAclsEndToEnd
hadoop.hdfs.TestTrashWithSecureEncryptionZones
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
hadoop.yarn.server.resourcemanager.TestRMHATimelineCollectors
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/Dockerfile
GITHUB PR #2122
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4f1e4a88fa28 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 55a2ae8
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-kms-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/diff-checkstyle-root.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-kms-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-unit-hadoop-common-project_hadoop-kms.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-unit-hadoop-common-project_hadoop-registry.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/testReport/
Max. process+thread count 3261 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-cloud-storage-project/hadoop-cos U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 14 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 24m 39s trunk passed
+1 💚 compile 24m 38s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 20m 41s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 3m 15s trunk passed
+1 💚 mvnsite 15m 28s trunk passed
+1 💚 shadedclient 36m 43s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 35s hadoop-auth in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 40s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 31s hadoop-kms in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 34s hadoop-registry in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 47s hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 45s hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 37s hadoop-hdfs-rbf in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 38s hadoop-yarn-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 36s hadoop-yarn-server-nodemanager in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 39s hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 34s hadoop-yarn-client in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 40s hadoop-aws in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 35s hadoop-azure in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 33s hadoop-cos in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 10m 41s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 0m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 0m 52s hadoop-cloud-storage-project/hadoop-cos in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 11m 8s the patch passed
+1 💚 compile 21m 26s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
-1 ❌ javac 21m 26s root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 2 new + 1975 unchanged - 2 fixed = 1977 total (was 1977)
+1 💚 compile 17m 34s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌ javac 17m 34s root-jdkPrivateBuild-1.8.0_252-8u252-b09-118.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-118.04-b09 generated 2 new + 1868 unchanged - 2 fixed = 1870 total (was 1870)
-0 ⚠️ checkstyle 2m 55s root: The patch generated 20 new + 389 unchanged - 7 fixed = 409 total (was 396)
+1 💚 mvnsite 13m 29s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 43s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 31s hadoop-auth in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 37s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 29s hadoop-kms in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 31s hadoop-registry in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 44s hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 40s hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 33s hadoop-hdfs-rbf in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 31s hadoop-yarn-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 35s hadoop-aws in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-azure in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 29s hadoop-cos in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 9m 50s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 25m 28s the patch passed
_ Other Tests _
+1 💚 unit 3m 35s hadoop-auth in the patch passed.
-1 ❌ unit 9m 37s hadoop-common in the patch passed.
-1 ❌ unit 2m 42s hadoop-kms in the patch passed.
-1 ❌ unit 1m 12s hadoop-registry in the patch passed.
+1 💚 unit 2m 10s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 131m 27s hadoop-hdfs in the patch passed.
-1 ❌ unit 12m 34s hadoop-hdfs-rbf in the patch passed.
+1 💚 unit 4m 36s hadoop-yarn-common in the patch passed.
+1 💚 unit 23m 34s hadoop-yarn-server-nodemanager in the patch passed.
-1 ❌ unit 100m 51s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 26m 31s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 10s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 19m 43s hadoop-yarn-services-core in the patch passed.
+1 💚 unit 2m 10s hadoop-yarn-services-api in the patch passed.
+1 💚 unit 1m 35s hadoop-aws in the patch passed.
+1 💚 unit 1m 41s hadoop-azure in the patch passed.
+1 💚 unit 0m 36s hadoop-cos in the patch passed.
+1 💚 asflicense 0m 56s The patch does not generate ASF License warnings.
643m 8s
Reason Tests
Failed junit tests hadoop.security.token.TestToken
hadoop.crypto.key.kms.server.TestKMS
hadoop.registry.server.dns.TestRegistryDNS
hadoop.registry.server.dns.TestSecureRegistryDNS
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.web.TestWebHdfsUrl
hadoop.hdfs.TestSecureEncryptionZoneWithKMS
hadoop.hdfs.TestEncryptionZonesWithKMS
hadoop.hdfs.server.namenode.TestReencryptionWithKMS
hadoop.hdfs.TestAclsEndToEnd
hadoop.hdfs.TestTrashWithSecureEncryptionZones
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
hadoop.yarn.server.resourcemanager.TestRMHATimelineCollectors
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/Dockerfile
GITHUB PR #2122
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c893ce9c0593 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 55a2ae8
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-kms-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/diff-checkstyle-root.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-kms-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-common-project_hadoop-kms.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-common-project_hadoop-registry.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/testReport/
Max. process+thread count 3261 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-cloud-storage-project/hadoop-cos U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2122/2/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@amahussein
Copy link
Contributor

Thanks @dengliming for the patch.

  • Can you please list the failing test units? Just to confirm that we went through all of them and enumerating the ones are flaky and the ones could be introduced by our changes.

  • Can you please fix the checkstyle warnings?

  • I see that there are many base64 implementations used throughout the code.I think in that case we change the Jira title and description to reflect the fact that we are also replace apache common base.

  • Just to make sure that we have the exact behavior as before, Do you know what are the differences between each of them? Also, any idea about performance between guava, apache common, and java.util?

  • com.google.common.io.BaseEncoding#base64

  • com.google.common.io.BaseEncoding#base64Url

  • org.apache.commons.codec.binary.Base64;

  • Can you please add the two classes to the illegal imports in checkstyle.xml? It is already done in HADOOP-17111. It should be something like that:

diff --git hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
index 8f3d3f13824..54a59437380 100644
--- hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
+++ hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
@@ -119,7 +119,12 @@
 
         <!-- Checks for imports                              -->
         <!-- See http://checkstyle.sf.net/config_import.html -->
-        <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
+        <module name="IllegalImport">
+          <property name="regexp" value="true"/>
+          <property name="illegalPkgs" value="^sun\.[^.]+"/>
+          <property name="illegalClasses"
+            value="^com\.google\.common\.io\.(BaseEncoding), org.apache.commons.codec.binary.Base64"/>
+        </module>
         <module name="RedundantImport"/>
         <module name="UnusedImports"/>

@dengliming dengliming closed this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dengliming @hadoop-yetus @amahussein