Skip to content

HADOOP-17107. hadoop-azure parallel tests not working on recent JDKs #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

steveloughran
Copy link
Contributor

Contributed by Steve Loughran.

tested: ireland

ran with

  1. -Dparallel-tests=both
  2. -Dparallel-tests=abfs
  3. -Dparallel-tests=wasb

all profiles worked as far as launching tests without showing errors and running all unit tests in parallel. I'm not 100% sure

Contributed by Steve Loughran.

Change-Id: I8fd4266351a7205cf889222deb61777dd67c87d2
Change-Id: Ib9126ef8adb351446d6f03a1c3f735cfbe8d1950
@steveloughran
Copy link
Contributor Author

..and by removing the declarations of fork count = 1, the integration tests run in parallel too

INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.fs.azure.contract.ITestAzureNativeContractGetFileStatus
[INFO] Running org.apache.hadoop.fs.azure.contract.ITestAzureNativeContractMkdir
[INFO] Running org.apache.hadoop.fs.azure.ITestFileSystemOperationExceptionHandling
[INFO] Running org.apache.hadoop.fs.azure.metrics.ITestAzureFileSystemInstrumentation
[INFO] Running org.apache.hadoop.fs.azure.contract.ITestAzureNativeContractOpen
[INFO] Running org.apache.hadoop.fs.azure.contract.ITestAzureNativeContractDelete

This may have been the case before, I'm just making extra sure after changing the test running

@steveloughran steveloughran requested a review from DadanielZ July 1, 2020 14:15
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 2s trunk passed
+1 💚 compile 0m 35s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 0m 30s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 mvnsite 0m 32s trunk passed
+1 💚 shadedclient 40m 21s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 26s hadoop-azure in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 0m 23s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 31s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 javac 0m 31s the patch passed
+1 💚 compile 0m 22s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 0m 22s the patch passed
+1 💚 mvnsite 0m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 shadedclient 15m 42s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 27s hadoop-azure in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 0m 23s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
_ Other Tests _
+1 💚 unit 1m 20s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
65m 36s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2118/1/artifact/out/Dockerfile
GITHUB PR #2118
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 7f35ad8c8abc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 04abd0e
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2118/1/artifact/out/branch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2118/1/artifact/out/patch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2118/1/testReport/
Max. process+thread count 311 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2118/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bgaborg
Copy link

bgaborg commented Jul 20, 2020

LGTM +1

@steveloughran steveloughran merged commit 9f407bc into apache:trunk Jul 20, 2020
@steveloughran
Copy link
Contributor Author

thanks. will backport to 3.3; if people need it for 3.2 then ping me after doing a test run locally

asfgit pushed a commit that referenced this pull request Jul 20, 2020
…2118)

Contributed by Steve Loughran.

Change-Id: I972264aed36f384b7ae23e214326ef7870261cf5
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…recent JDKs (apache#2118)

Contributed by Steve Loughran.

Change-Id: I06fc9cbfa592e13b1f2800d74de6e92f33c16678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants