MAPREDUCE-7279. Adds RM host name to history server web page #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I59a467a49d417aa76548fb8e00f1582b09b9e041
|
💔 -1 overall
This message was automatically generated. |
Gaurangi94
changed the title
Gaurangi94
changed the title
Gaurangi94
changed the title
|
💔 -1 overall
This message was automatically generated. |
jiwq
reviewed
Sep 1, 2020
There was a problem hiding this comment.
Thanks @Gaurangi94 for the contribution. I left a comment inline, can you help to resolve?
| JHAdminConfig.MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED, | ||
| JHAdminConfig.DEFAULT_MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED)) { | ||
|
|
||
| String hostName = getConfig().get(YarnConfiguration.RM_HOSTNAME, ""); |
There was a problem hiding this comment.
If we don't config the yarn.resourcemanager.address in client, how do we get the right address? And if enabled the federation feature, how can we ensure this?
There was a problem hiding this comment.
If we don't config it, it will not show up on the UI.
Could you tell me what federation feature you are referring to?
There was a problem hiding this comment.
I means the YARN Federation feature. As I know in the federation cluster has only one JobHistory server, but maybe has more YARN physical clusters.
There was a problem hiding this comment.
I see that YARN federation feature can have multiple RMs.
I created a high availability cluster to check my changes, and noticed that one of the RMs (job-cluster-m-0) was listed as the host.
Is it safe to assume that YARN federation will behave similarly? Please note that I used Hadoop 3.2.1 to test this.
There was a problem hiding this comment.
I don't think so. In federation cluster, the app can be routed to any physical cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute