HADOOP-16854. ABFS: Fix for the OutOfMemoryException in AbfsOutputStream #2014
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.fs.azurebfs.services; | ||
|
|
||
| import java.util.concurrent.ArrayBlockingQueue; | ||
|
|
||
| import com.google.common.annotations.VisibleForTesting; | ||
| import com.google.common.base.Preconditions; | ||
| import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; | ||
|
|
||
| import static java.lang.Math.ceil; | ||
| import static java.lang.Math.min; | ||
|
|
||
| import static org.apache.hadoop.fs.azurebfs.constants.FileSystemConfigurations.MAX_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE; | ||
| import static org.apache.hadoop.fs.azurebfs.constants.FileSystemConfigurations.MIN_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE; | ||
|
|
||
| /** | ||
| * Pool for byte[] | ||
|
There was a problem hiding this comment. . at ehd for javadoc in java 8 |
||
| */ | ||
| public class AbfsByteBufferPool { | ||
|
|
||
| private static final int HUNDRED = 100; | ||
|
|
||
| /** | ||
| * Queue holding the free buffers. | ||
| */ | ||
| private ArrayBlockingQueue<byte[]> freeBuffers; | ||
| /** | ||
| * Count to track the buffers issued from AbfsByteBufferPool and yet to be | ||
| * returned. | ||
| */ | ||
| private int numBuffersInUse; | ||
|
|
||
| private int bufferSize; | ||
|
|
||
| private int maxBuffersToPool; | ||
| private int maxMemUsagePercentage; | ||
|
|
||
| private static final Runtime RT = Runtime.getRuntime(); | ||
| private static final int AVAILABLE_PROCESSORS = RT.availableProcessors(); | ||
|
|
||
| private static int MAX_BUFFERS_THAT_CAN_BE_IN_USE; | ||
|
|
||
| /** | ||
| * @param bufferSize Size of the byte[] to be returned. | ||
| * @param queueCapacity Maximum number of buffers that the pool can | ||
| * keep within the pool. | ||
| * @param maxMemUsagePercentage Maximum percentage of memory that can | ||
| * be used by the pool from the max | ||
| * available memory. | ||
| */ | ||
| public AbfsByteBufferPool(final int bufferSize, final int queueCapacity, | ||
| final int maxMemUsagePercentage) { | ||
| validate(queueCapacity, maxMemUsagePercentage); | ||
| this.maxMemUsagePercentage = maxMemUsagePercentage; | ||
| this.bufferSize = bufferSize; | ||
| this.numBuffersInUse = 0; | ||
| this.maxBuffersToPool = queueCapacity; | ||
| freeBuffers = new ArrayBlockingQueue<>(queueCapacity); | ||
| } | ||
|
|
||
| private void validate(final int queueCapacity, | ||
| final int maxWriteMemUsagePercentage) { | ||
| Preconditions.checkArgument(maxWriteMemUsagePercentage | ||
| >= MIN_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE | ||
| && maxWriteMemUsagePercentage | ||
| <= MAX_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE, | ||
| "maxWriteMemUsagePercentage should be in range (%s - %s)", | ||
| MIN_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE, | ||
| MAX_VALUE_MAX_AZURE_WRITE_MEM_USAGE_PERCENTAGE); | ||
| Preconditions | ||
| .checkArgument(queueCapacity > 0, "queueCapacity cannot be < 1"); | ||
| } | ||
|
|
||
| private void setMaxBuffersThatCanBeInUse() { | ||
| double freeMemory = RT.maxMemory() - (RT.totalMemory() - RT.freeMemory()); | ||
| int bufferCountByMemory = (int) ceil( | ||
| (freeMemory * maxMemUsagePercentage / HUNDRED) / bufferSize); | ||
| int bufferCountByMaxFreeBuffers = maxBuffersToPool + AVAILABLE_PROCESSORS; | ||
| MAX_BUFFERS_THAT_CAN_BE_IN_USE = min(bufferCountByMemory, | ||
| bufferCountByMaxFreeBuffers); | ||
| if (MAX_BUFFERS_THAT_CAN_BE_IN_USE < 2) { | ||
| MAX_BUFFERS_THAT_CAN_BE_IN_USE = 2; | ||
| } | ||
| } | ||
|
|
||
| private synchronized boolean isPossibleToIssueNewBuffer() { | ||
| setMaxBuffersThatCanBeInUse(); | ||
| return numBuffersInUse < MAX_BUFFERS_THAT_CAN_BE_IN_USE; | ||
| } | ||
|
|
||
| /** | ||
| * @return byte[] from the pool if available otherwise new byte[] is returned. | ||
| * Waits if pool is empty and already maximum number of buffers are in use. | ||
| */ | ||
| public byte[] get() { | ||
| byte[] byteArray = null; | ||
| synchronized (this) { | ||
| byteArray = freeBuffers.poll(); | ||
| if (byteArray == null && isPossibleToIssueNewBuffer()) { | ||
| byteArray = new byte[bufferSize]; | ||
| } | ||
| if (byteArray != null) { | ||
| numBuffersInUse++; | ||
| return byteArray; | ||
| } | ||
| } | ||
| try { | ||
| byteArray = freeBuffers.take(); | ||
| synchronized (this) { | ||
| numBuffersInUse++; | ||
| return byteArray; | ||
| } | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @param byteArray The buffer to be offered back to the pool. | ||
| */ | ||
| @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED") | ||
| public synchronized void release(byte[] byteArray) { | ||
| Preconditions.checkArgument(byteArray.length == bufferSize, | ||
| "Buffer size has" + " to be %s (Received buffer length: %s)", | ||
| bufferSize, byteArray.length); | ||
| numBuffersInUse--; | ||
| if (numBuffersInUse < 0) { | ||
| numBuffersInUse = 0; | ||
| } | ||
| freeBuffers.offer(byteArray); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| public synchronized int getBuffersInUse() { | ||
| return this.numBuffersInUse; | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| public synchronized ArrayBlockingQueue<byte[]> getFreeBuffers() { | ||
| return freeBuffers; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which annotations is it actually for? as VisibleForTesting is in guava