Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-10223. Remove jersey-test-framework-core dependency from yarn-server-common #1939

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Apr 3, 2020

@aajisaka aajisaka requested a review from szilard-nemeth April 3, 2020 16:28
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 19m 20s trunk passed
+1 💚 compile 0m 34s trunk passed
+1 💚 mvnsite 0m 37s trunk passed
+1 💚 shadedclient 34m 34s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 30s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 32s the patch passed
+1 💚 compile 0m 28s the patch passed
+1 💚 javac 0m 28s the patch passed
+1 💚 mvnsite 0m 31s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 shadedclient 14m 4s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
+1 💚 unit 2m 41s hadoop-yarn-server-common in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
57m 4s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1939/1/artifact/out/Dockerfile
GITHUB PR #1939
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 2698ec8738c0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1695d8d
Default Java 1.8.0_242
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1939/1/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1939/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@szilard-nemeth
Copy link
Contributor

Hey @aajisaka ,
I can prioritize and review your code next week.

@steveloughran
Copy link
Contributor

this cuts out both imports. intentional?

@aajisaka
Copy link
Member Author

It's intentional. I think these imports are not required.

@steveloughran
Copy link
Contributor

in that case: +1

@szilard-nemeth
Copy link
Contributor

szilard-nemeth commented Apr 23, 2020

Hi @aajisaka ,
Change makes sense, LGTM.
Do you need other reviews or may I commit this?
Btw, side question: What is the policy of PR commits? Is it okay to push the "Squash and merge" button and just close the jira afterwards?

@aajisaka aajisaka merged commit 9827ff2 into apache:trunk Apr 24, 2020
@aajisaka
Copy link
Member Author

What is the policy of PR commits? Is it okay to push the "Squash and merge" button and just close the jira afterwards?

I think It's okay to push the "Squash and merge" button and just close the jira afterwards.

@aajisaka aajisaka deleted the YARN-10223-2 branch April 24, 2020 00:33
@aajisaka aajisaka changed the title YARN-10223. Duplicate jersey-test-framework-core dependency in yarn-server-common YARN-10223. Remove jersey-test-framework-core dependency from yarn-server-common Apr 24, 2020
aajisaka added a commit that referenced this pull request Apr 24, 2020
aajisaka added a commit that referenced this pull request Apr 24, 2020
zhangxiping1 pushed a commit to zhangxiping1/hadoop that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants