HDFS-14743. Enhance INodeAttributeProvider/ AccessControlEnforcer Interface in HDFS to support Authorization of mkdir, rm, rmdir, copy, move etc...

[jojochuang]

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 1s	trunk passed
+1 💚	compile	1m 4s	trunk passed
+1 💚	checkstyle	0m 49s	trunk passed
+1 💚	mvnsite	1m 11s	trunk passed
+1 💚	shadedclient	15m 51s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 22s	trunk passed
+0 🆗	spotbugs	3m 14s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 9s	trunk passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 32s	hadoop-hdfs in the patch failed.
-1 ❌	compile	0m 33s	hadoop-hdfs in the patch failed.
-1 ❌	javac	0m 33s	hadoop-hdfs in the patch failed.
-0 ⚠️	checkstyle	0m 46s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 27 new + 245 unchanged - 0 fixed = 272 total (was 245)
-1 ❌	mvnsite	0m 36s	hadoop-hdfs in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	shadedclient	3m 46s	patch has errors when building and testing our client artifacts.
-1 ❌	javadoc	1m 14s	hadoop-hdfs-project_hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-1 ❌	findbugs	0m 36s	hadoop-hdfs in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 36s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		55m 1s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6ed8ff3e7720 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 1e3a0b0
Default Java	1.8.0_242
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/testReport/
Max. process+thread count	303 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	27m 14s	trunk passed
+1 💚	compile	1m 24s	trunk passed
+1 💚	checkstyle	1m 2s	trunk passed
+1 💚	mvnsite	1m 33s	trunk passed
+1 💚	shadedclient	18m 6s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 35s	trunk passed
+0 🆗	spotbugs	3m 43s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 38s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 18s	the patch passed
+1 💚	compile	1m 13s	the patch passed
-1 ❌	javac	1m 13s	hadoop-hdfs-project_hadoop-hdfs generated 5 new + 580 unchanged - 0 fixed = 585 total (was 580)
-0 ⚠️	checkstyle	0m 50s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 47 new + 245 unchanged - 0 fixed = 292 total (was 245)
+1 💚	mvnsite	1m 19s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	17m 51s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	1m 18s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	findbugs	3m 2s	the patch passed
		_ Other Tests _
-1 ❌	unit	109m 18s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		194m 31s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 25fc7bd1eabb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 314e2f9
Default Java	1.8.0_232
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/testReport/
Max. process+thread count	2751 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 37s	trunk passed
+1 💚	compile	1m 13s	trunk passed
+1 💚	checkstyle	0m 53s	trunk passed
+1 💚	mvnsite	1m 11s	trunk passed
+1 💚	shadedclient	17m 24s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 40s	trunk passed
+0 🆗	spotbugs	3m 6s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 3s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s	the patch passed
+1 💚	compile	1m 2s	the patch passed
-1 ❌	javac	1m 2s	hadoop-hdfs-project_hadoop-hdfs generated 8 new + 580 unchanged - 0 fixed = 588 total (was 580)
-0 ⚠️	checkstyle	0m 45s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 60 new + 245 unchanged - 0 fixed = 305 total (was 245)
+1 💚	mvnsite	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 41s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 43s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
-1 ❌	findbugs	3m 32s	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	89m 6s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		162m 51s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	org.apache.hadoop.hdfs.server.namenode.INodeAttributeProvider$AuthorizationContext defines equals and uses Object.hashCode() At INodeAttributeProvider.java:Object.hashCode() At INodeAttributeProvider.java:[lines 234-237]
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6a227c3f2b1c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d5467d2
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/testReport/
Max. process+thread count	3232 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	27m 58s	trunk passed
+1 💚	compile	1m 27s	trunk passed
+1 💚	checkstyle	1m 1s	trunk passed
+1 💚	mvnsite	1m 41s	trunk passed
+1 💚	shadedclient	21m 20s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s	trunk passed
+0 🆗	spotbugs	3m 40s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 36s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 25s	the patch passed
+1 💚	compile	1m 15s	the patch passed
-1 ❌	javac	1m 15s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 580 unchanged - 0 fixed = 586 total (was 580)
-0 ⚠️	checkstyle	0m 52s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 55 new + 245 unchanged - 0 fixed = 300 total (was 245)
+1 💚	mvnsite	1m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	17m 51s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 52s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
-1 ❌	findbugs	4m 21s	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	126m 12s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		216m 38s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	org.apache.hadoop.hdfs.server.namenode.INodeAttributeProvider$AuthorizationContext defines equals and uses Object.hashCode() At INodeAttributeProvider.java:Object.hashCode() At INodeAttributeProvider.java:[lines 234-237]
Failed junit tests	hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestDeadNodeDetection
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestWriteReadStripedFile
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.TestErasureCodingPolicies

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 20fcfe1c7a85 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d5467d2
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/testReport/
Max. process+thread count	2822 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 45s	trunk passed
+1 💚	compile	1m 11s	trunk passed
+1 💚	checkstyle	0m 53s	trunk passed
+1 💚	mvnsite	1m 24s	trunk passed
+1 💚	shadedclient	17m 50s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 42s	trunk passed
+0 🆗	spotbugs	3m 25s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 23s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 14s	the patch passed
+1 💚	compile	1m 14s	the patch passed
-1 ❌	javac	1m 14s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 580 unchanged - 0 fixed = 586 total (was 580)
-0 ⚠️	checkstyle	0m 45s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 245 unchanged - 0 fixed = 299 total (was 245)
+1 💚	mvnsite	1m 21s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 3s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 39s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
-1 ❌	findbugs	4m 40s	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	144m 22s	hadoop-hdfs in the patch passed.
-1 ❌	asflicense	0m 37s	The patch generated 1 ASF License warnings.
		221m 3s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	org.apache.hadoop.hdfs.server.namenode.INodeAttributeProvider$AuthorizationContext defines equals and uses Object.hashCode() At INodeAttributeProvider.java:Object.hashCode() At INodeAttributeProvider.java:[lines 211-217]
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData
	hadoop.hdfs.TestDeadNodeDetection
	hadoop.hdfs.server.namenode.TestAuditLoggerWithCommands
	hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
	hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.server.namenode.TestNamenodeRetryCache
	hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
	hadoop.hdfs.TestReadStripedFileWithDNFailure
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy
	hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
	hadoop.hdfs.TestMaintenanceState
	hadoop.hdfs.server.namenode.TestEditLogAutoroll
	hadoop.hdfs.server.namenode.TestFSImage
	hadoop.hdfs.server.namenode.ha.TestStandbyIsHot

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 366e61eb090f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3f1aad0
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/testReport/
asflicense	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	3761 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 16s	trunk passed
+1 💚	compile	1m 10s	trunk passed
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 13s	trunk passed
+1 💚	shadedclient	17m 42s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 45s	trunk passed
+0 🆗	spotbugs	3m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 14s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 18s	the patch passed
+1 💚	compile	1m 3s	the patch passed
-1 ❌	javac	1m 3s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 580 unchanged - 0 fixed = 586 total (was 580)
-0 ⚠️	checkstyle	0m 44s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 54 new + 245 unchanged - 0 fixed = 299 total (was 245)
+1 💚	mvnsite	1m 10s	the patch passed
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	16m 38s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 40s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
-1 ❌	findbugs	3m 27s	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	29m 1s	hadoop-hdfs in the patch passed.
+0 🆗	asflicense	0m 40s	ASF License check generated no output?
		103m 21s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	org.apache.hadoop.hdfs.server.namenode.INodeAttributeProvider$AuthorizationContext defines equals and uses Object.hashCode() At INodeAttributeProvider.java:Object.hashCode() At INodeAttributeProvider.java:[lines 211-217]
Failed junit tests	hadoop.hdfs.TestDFSClientFailover
	hadoop.hdfs.TestWriteRead
	hadoop.hdfs.client.impl.TestBlockReaderFactory
	hadoop.hdfs.TestEncryptionZones

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ce99c1da1660 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ec75071
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/whitespace-eol.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/testReport/
Max. process+thread count	2609 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

The javac warnings are expected since we deprecate the original API and add tests for them.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 6s	trunk passed
+1 💚	compile	1m 7s	trunk passed
+1 💚	checkstyle	0m 48s	trunk passed
+1 💚	mvnsite	1m 13s	trunk passed
+1 💚	shadedclient	17m 27s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 41s	trunk passed
+0 🆗	spotbugs	3m 1s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 59s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s	the patch passed
+1 💚	compile	1m 2s	the patch passed
-1 ❌	javac	1m 2s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 580 unchanged - 0 fixed = 586 total (was 580)
-0 ⚠️	checkstyle	0m 44s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 55 new + 245 unchanged - 0 fixed = 300 total (was 245)
+1 💚	mvnsite	1m 8s	the patch passed
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	15m 12s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 39s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
-1 ❌	findbugs	3m 6s	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	116m 52s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 22s	The patch does not generate ASF License warnings.
		190m 0s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	org.apache.hadoop.hdfs.server.namenode.INodeAttributeProvider$AuthorizationContext defines equals and uses Object.hashCode() At INodeAttributeProvider.java:Object.hashCode() At INodeAttributeProvider.java:[lines 211-217]
Failed junit tests	hadoop.hdfs.TestHDFSTrash
	hadoop.hdfs.TestDeadNodeDetection
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.TestReadStripedFileWithDNFailure
	hadoop.hdfs.TestSafeModeWithStripedFile

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f70f77162930 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 6f84269
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/whitespace-eol.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/testReport/
Max. process+thread count	3276 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

The javac warning is because of the deprecation added in the code.

The javadoc warning looks like a false positive to me.
findbugs: fixed.

getter/setter: used Intellij to assist this part

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 35s	trunk passed
+1 💚	compile	1m 5s	trunk passed
+1 💚	checkstyle	0m 46s	trunk passed
+1 💚	mvnsite	1m 11s	trunk passed
+1 💚	shadedclient	17m 29s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 40s	trunk passed
+0 🆗	spotbugs	3m 0s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 58s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 8s	the patch passed
+1 💚	compile	1m 1s	the patch passed
-1 ❌	javac	1m 1s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 579 unchanged - 0 fixed = 585 total (was 579)
-0 ⚠️	checkstyle	0m 43s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 243 unchanged - 0 fixed = 249 total (was 243)
+1 💚	mvnsite	1m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 54s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 44s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
+1 💚	findbugs	3m 33s	the patch passed
		_ Other Tests _
-1 ❌	unit	117m 45s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		190m 58s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5ffedccb1e05 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / cf9cf83
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/testReport/
Max. process+thread count	3090 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/13/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

javac and javadoc warnings can be ignored. Unit test failure is unrelated.

[xiaoyuyao]

Thanks for the update. LGTM overall, just some minor comments inline.
+1 after that being fixed, pending CI.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	24m 12s	trunk passed
+1 💚	compile	1m 25s	trunk passed
+1 💚	checkstyle	1m 2s	trunk passed
+1 💚	mvnsite	1m 27s	trunk passed
+1 💚	shadedclient	20m 29s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 49s	trunk passed
+0 🆗	spotbugs	3m 34s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 31s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 23s	the patch passed
+1 💚	compile	1m 13s	the patch passed
-1 ❌	javac	1m 13s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 579 unchanged - 0 fixed = 585 total (was 579)
-0 ⚠️	checkstyle	0m 50s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 339 unchanged - 0 fixed = 345 total (was 339)
+1 💚	mvnsite	1m 15s	the patch passed
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	shadedclient	17m 16s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 41s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
+1 💚	findbugs	3m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	110m 53s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		192m 47s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
	hadoop.hdfs.TestDecommissionWithStriped
	hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.TestWriteRead
	hadoop.hdfs.TestAclsEndToEnd
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
	hadoop.hdfs.TestDecommission
	hadoop.hdfs.TestWriteReadStripedFile

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6e3684b16c0f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 0b931f3
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/testReport/
Max. process+thread count	4794 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/14/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

Test failures due to OOM, unrelated. Triggered a rebuild regardless

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 41s	trunk passed
+1 💚	compile	1m 7s	trunk passed
+1 💚	checkstyle	0m 48s	trunk passed
+1 💚	mvnsite	1m 13s	trunk passed
+1 💚	shadedclient	17m 33s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 41s	trunk passed
+0 🆗	spotbugs	3m 2s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 58s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s	the patch passed
+1 💚	compile	1m 3s	the patch passed
-1 ❌	javac	1m 3s	hadoop-hdfs-project_hadoop-hdfs generated 6 new + 579 unchanged - 0 fixed = 585 total (was 579)
-0 ⚠️	checkstyle	0m 44s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 339 unchanged - 0 fixed = 345 total (was 339)
+1 💚	mvnsite	1m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 43s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 43s	hadoop-hdfs-project_hadoop-hdfs generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)
+1 💚	findbugs	3m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	108m 2s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		181m 53s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/artifact/out/Dockerfile
GITHUB PR	#1829
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 23bd4bf9dade 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 0b931f3
Default Java	1.8.0_242
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/testReport/
Max. process+thread count	2876 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/15/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[xiaoyuyao]

+1. Thanks @jojochuang for the update. There are whitespace related checkstyle issue which you can fix at commit.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 6s	#1829 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1829
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1829/16/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

Thanks @xiaoyuyao for your thorough review. Learned a lot through your review.

[vinayakumarb]

After this change...

Namenode logs are getting flooded with below logs.

2020-03-17 17:18:29,102 INFO org.apache.hadoop.security.UserGroupInformation: Default authorization provider supports the new authorization provider API

[jojochuang]

Thanks @vinayakumarb. I am looking into it now.

[tasanuma]

Hi @jojochuang,
NameNode still generates many log messages of Default authorization provider supports the new authorization provider API. Do you plan to fix it?

[jojochuang]

Hi @tasanuma do you have RBF?
I don't see this message in my test cluster (we don't have RBF) and wonder if it comes from RBF.

Not familiar with RBF but if each RPC call results in one permission checker object I can see why there are many messages.
` /**

• Get a new permission checker used for making mount table access
• control. This method will be invoked during each RPC call in router
• admin server.
• @return Router permission checker.
• @throws AccessControlException If the user is not authorized.
  */
  public static RouterPermissionChecker getPermissionChecker()
  throws AccessControlException {
  if (!isPermissionEnabled) {
  return null;
  }

try {
  return new RouterPermissionChecker(routerOwner, superGroup,
      NameNode.getRemoteUser());
} catch (IOException e) {
  throw new AccessControlException(e);
}

}`

[tasanuma]

@jojochuang
No, I see the logs from namenode in a cluster that doesn't have Routers.
I also confirmed it on my local laptop.
https://gist.github.com/tasanuma/c066b0d3cadf3be38b2b6d921d4ae28f

When FileSystem API is executed, it seems to generate the logs.