Skip to content

HADOOP-16811: Use JUnit TemporaryFolder Rule in TestFileUtils #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2020

Conversation

belugabehr
Copy link
Contributor

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 21m 2s trunk passed
+1 💚 compile 17m 31s trunk passed
+1 💚 checkstyle 0m 45s trunk passed
+1 💚 mvnsite 1m 20s trunk passed
+1 💚 shadedclient 16m 10s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 26s trunk passed
+0 🆗 spotbugs 2m 8s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 5s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 16m 39s the patch passed
+1 💚 javac 16m 39s the patch passed
+1 💚 checkstyle 0m 44s hadoop-common-project/hadoop-common: The patch generated 0 new + 57 unchanged - 1 fixed = 57 total (was 58)
+1 💚 mvnsite 1m 22s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 40s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 23s the patch passed
+1 💚 findbugs 2m 12s the patch passed
_ Other Tests _
+1 💚 unit 9m 14s hadoop-common in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
109m 24s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1811/2/artifact/out/Dockerfile
GITHUB PR #1811
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux af8b35854133 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6a859d3
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1811/2/testReport/
Max. process+thread count 1343 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1811/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Jan 21, 2020
@steveloughran
Copy link
Contributor

LGTM.
you happy with this yourself?

@belugabehr
Copy link
Contributor Author

belugabehr commented Jan 21, 2020 via email

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 1afd54f into apache:trunk Jan 25, 2020
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
iwasakims pushed a commit that referenced this pull request Mar 14, 2022
…. Contributed by David Mollitor.

(cherry picked from commit 1afd54f)
iwasakims pushed a commit that referenced this pull request Mar 14, 2022
…. Contributed by David Mollitor.

(cherry picked from commit 1afd54f)
iwasakims pushed a commit that referenced this pull request Apr 14, 2022
…. Contributed by David Mollitor.

(cherry picked from commit 1afd54f)

Conflicts:
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants