-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-16811: Use JUnit TemporaryFolder Rule in TestFileUtils #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
LGTM. |
Yup! Thanks!
…On Tue, Jan 21, 2020, 9:34 AM Steve Loughran ***@***.***> wrote:
LGTM.
you happy with this yourself?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1811?email_source=notifications&email_token=AC766E6C3HGPOBIE6ZS6KJ3Q64BXNA5CNFSM4KIKBYH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJP6CGQ#issuecomment-576708890>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC766E2W3OIZNO4PQT6WKMTQ64BXNANCNFSM4KIKBYHQ>
.
|
goiri
approved these changes
Jan 21, 2020
ayushtkn
approved these changes
Jan 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…#1811). Contributed by David Mollitor.
iwasakims
pushed a commit
that referenced
this pull request
Mar 14, 2022
…. Contributed by David Mollitor. (cherry picked from commit 1afd54f)
iwasakims
pushed a commit
that referenced
this pull request
Mar 14, 2022
…. Contributed by David Mollitor. (cherry picked from commit 1afd54f)
iwasakims
pushed a commit
that referenced
this pull request
Apr 14, 2022
…. Contributed by David Mollitor. (cherry picked from commit 1afd54f) Conflicts: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute