Skip to content

HADOOP-16826. ABFS: update abfs.md to include config keys for identity transformation #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

karthick-rn
Copy link
Contributor

In this PR, I have updated the abfs.md to include some key configurations required when submitting jobs to YARN using hadoop-azure module. Currently, these properties aren't documented anywhere in Apache Hadoop. I have them included under 'Troubleshooting' section of abfs.md, please review and also let me know if you think they need to be documented elsewhere?
As the PR is only an update to the existing doc I have not opened any JIRA ticket, let me know if you think a JIRA is still required?

Many thanks!

@steveloughran
Copy link
Contributor

LGTM; one minor tweak and then it's good to go in. Troubleshooting docs are, provided kept current, wonderful

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 25m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 18m 11s trunk passed
+1 💚 mvnsite 0m 34s trunk passed
+1 💚 shadedclient 31m 22s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 mvnsite 0m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
73m 36s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1785/3/artifact/out/Dockerfile
GITHUB PR #1785
Optional Tests dupname asflicense mvnsite markdownlint
uname Linux 96d349367a81 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 263413e
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1785/3/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@@ -857,6 +857,46 @@ signon page for humans, even though it is a machine calling.
1. The URL is wrong —it is pointing at a web page unrelated to OAuth2.0
1. There's a proxy server in the way trying to return helpful instructions.

### `java.io.IOException: The ownership on the staging directory /tmp/hadoop-yarn/staging/user1/.staging is not as expected. It is owned by <principal_id>. The directory must be owned by the submitter user1 or user1`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of options to deal with the issue like deleting staging dir before running the job or changing the staging directory in config before running the job. The configs identity.transformer listed here are also providing a workaround specific to ABFS driver to let the client assume the ownership is with current local user.

As this is not really a store issue, please reword to highlight that this is a workaround.

Copy link
Contributor Author

@karthick-rn karthick-rn Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snvijaya The options suggested are not a suitable fix for the exception. I think identity.transformer is more of a fix rather to be considered as a workaround. I have added a short message on the fix in my last commit. Let me know for any further comments?

</description>
</property>
<property>
<name>fs.azure.use.upn</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config is not required to be set as it does not contribute to the conversion of the AAD OID to local user. Can be removed from this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snvijaya Removed this config in the new commit

@apache apache deleted a comment from hadoop-yetus Jan 20, 2020
@apache apache deleted a comment from hadoop-yetus Jan 20, 2020
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 26m 13s trunk passed
+1 💚 mvnsite 0m 34s trunk passed
+1 💚 shadedclient 43m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 mvnsite 0m 29s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 38s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
66m 30s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1785/4/artifact/out/Dockerfile
GITHUB PR #1785
Optional Tests dupname asflicense mvnsite markdownlint
uname Linux bc4ee17148c8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / f206b73
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1785/4/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@karthick-rn
Copy link
Contributor Author

@steveloughran @snvijaya - Please can you review the changes and merge if you're happy? Thanks!

@DadanielZ DadanielZ added the fs/azure changes related to azure; submitter must declare test endpoint label Jan 23, 2020
Copy link
Contributor

@DadanielZ DadanielZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.
@karthick-rn for this PR could you create a subtask under HADOOP-15763 so I can help to commit using its JIRA id?

@DadanielZ DadanielZ changed the title [Doc] Update abfs.md to include additional configs HADOOP-16826 Update abfs.md to include additional configs Jan 23, 2020
@DadanielZ DadanielZ changed the title HADOOP-16826 Update abfs.md to include additional configs HADOOP-16826. Update abfs.md to include additional configs Jan 23, 2020
@DadanielZ DadanielZ changed the title HADOOP-16826. Update abfs.md to include additional configs HADOOP-16826. ABFS: update abfs.md to include config keys for identity transformation Jan 23, 2020
@DadanielZ
Copy link
Contributor

committed, thank you @karthick-rn

@DadanielZ DadanielZ closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs/azure changes related to azure; submitter must declare test endpoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants