YARN-10020. Fix build instruction of hadoop-yarn-ui. #1750

iwasakims · 2019-12-10T16:36:40Z

We don't need to manually install package managers such as yarn and bower as described in README.md since frontend-maven-plugin was introduced by YARN-6278.

https://issues.apache.org/jira/browse/YARN-10020

goiri · 2019-12-17T01:43:40Z

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/README.md

+
+### Building with Maven
+
+YARN-6278 added build profile using rontend-maven-plugin which


Should we put the link to the JIRA?

Sure. I made it a hyperlink.

hadoop-yetus · 2019-12-17T02:29:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 52s	trunk passed
+1 💚	mvnsite	0m 18s	trunk passed
+1 💚	shadedclient	34m 52s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	mvnsite	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 48s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		81m 47s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/1/artifact/out/Dockerfile
GITHUB PR	#1750
Optional Tests	dupname asflicense mvnsite markdownlint
uname	Linux 93968e63980a 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `578bd10`
Max. process+thread count	305 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-12-17T04:17:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 20s	trunk passed
+1 💚	mvnsite	0m 18s	trunk passed
+1 💚	shadedclient	34m 30s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 13s	the patch passed
+1 💚	mvnsite	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 1s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		53m 2s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/2/artifact/out/Dockerfile
GITHUB PR	#1750
Optional Tests	dupname asflicense mvnsite markdownlint
uname	Linux 2c3dc525c2a1 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `2408066`
Max. process+thread count	308 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/2/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-12-17T04:20:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 28s	trunk passed
+1 💚	mvnsite	0m 17s	trunk passed
+1 💚	shadedclient	34m 19s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s	the patch passed
+1 💚	mvnsite	0m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 47s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		52m 33s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/3/artifact/out/Dockerfile
GITHUB PR	#1750
Optional Tests	dupname asflicense mvnsite markdownlint
uname	Linux 75dff2fe2475 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `2408066`
Max. process+thread count	311 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/3/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

goiri · 2019-12-17T05:20:46Z

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/README.md

+You can point the UI to custom locations by setting the environment variables in `src/main/webapp/config/configs.env`.
+
+In order to access RM from UI started by `yarn start`,
+you need to enbale CORS by setting `hadoop.http.cross-origin.enabled` to true


goiri · 2019-12-17T05:21:38Z

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/README.md

-* You can point the UI to custom locations by setting the environment variables in `src/main/webapp/config/configs.env`
+You can point the UI to custom locations by setting the environment variables in `src/main/webapp/config/configs.env`.
+
+In order to access RM from UI started by `yarn start`,


"from the UI"? I'm not sure what we are trying to say here.
I would recommend rephrasing this.

addressed by adding the development context.

goiri · 2019-12-17T05:23:31Z

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/README.md

+### Building with Maven
+
+[YARN-6278](https://issues.apache.org/jira/browse/YARN-6278)
+added build profile using frontend-maven-plugin which


"a" build profile.

What is "frontend-maven-plugin"? I think this looks more like:
"YARN-6278 added a build profile to frontend-maven-plugin which automatically..."

added link to frontend-maven-plugin as a reference.

goiri · 2019-12-17T05:24:02Z

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/README.md

+added build profile using frontend-maven-plugin which
+automatically installs Node.js and Yarn locally under target/webapp directory.
+After building yarn-ui by `mvn package -Pyarn-ui`, you can reuse
+locally installed Node.js and Yarn instead of manually installing them.


"you can reuse the locally installed..."

hadoop-yetus · 2019-12-17T07:23:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 34s	trunk passed
+1 💚	mvnsite	0m 19s	trunk passed
+1 💚	shadedclient	34m 43s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s	the patch passed
+1 💚	mvnsite	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 56s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		53m 6s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/4/artifact/out/Dockerfile
GITHUB PR	#1750
Optional Tests	dupname asflicense mvnsite markdownlint
uname	Linux 72818233016d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `2408066`
Max. process+thread count	300 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1750/4/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

iwasakims · 2019-12-18T04:34:37Z

Thanks for the review, @goiri.

(cherry picked from commit 92c8962)

iwasakims added 2 commits December 11, 2019 01:35

YARN-10020. Fix build instruction of hadoop-yarn-ui.

f116226

moved added contents to independent sub-section.

80f1932

goiri reviewed Dec 17, 2019

View reviewed changes

iwasakims added 2 commits December 17, 2019 12:22

made JIRA issue key hyperlink.

a8f12cc

fixed typo.

d969c57

goiri requested changes Dec 17, 2019

View reviewed changes

updated wording based on review comments.

2f8b12f

goiri approved these changes Dec 17, 2019

View reviewed changes

iwasakims merged commit 92c8962 into apache:trunk Dec 18, 2019

li-afaris pushed a commit to li-afaris/hadoop that referenced this pull request Dec 26, 2019

YARN-10020. Fix build instruction of hadoop-yarn-ui. (apache#1750)

0fa63f8

RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020

YARN-10020. Fix build instruction of hadoop-yarn-ui. (apache#1750)

5478576

iwasakims mentioned this pull request Jun 29, 2020

HADOOP-17097. start-build-env.sh fails in branch-3.1. #2108

Merged

aajisaka pushed a commit that referenced this pull request Jun 24, 2021

YARN-10020. Fix build instruction of hadoop-yarn-ui. (#1750)

3a224b7

(cherry picked from commit 92c8962)

iwasakims added a commit to iwasakims/hadoop that referenced this pull request Dec 7, 2023

YARN-10020. Fix build instruction of hadoop-yarn-ui. (apache#1750)

655325b

(cherry picked from commit 92c8962)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-10020. Fix build instruction of hadoop-yarn-ui. #1750

YARN-10020. Fix build instruction of hadoop-yarn-ui. #1750

Uh oh!

iwasakims commented Dec 10, 2019 •

edited by goiri

Loading

Uh oh!

goiri Dec 17, 2019

Uh oh!

iwasakims Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

goiri Dec 17, 2019

Uh oh!

iwasakims Dec 17, 2019

Uh oh!

goiri Dec 17, 2019

Uh oh!

iwasakims Dec 17, 2019

Uh oh!

goiri Dec 17, 2019

Uh oh!

iwasakims Dec 17, 2019

Uh oh!

goiri Dec 17, 2019

Uh oh!

iwasakims Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

iwasakims commented Dec 18, 2019

Uh oh!

Uh oh!


		### Building with Maven

		YARN-6278 added build profile using rontend-maven-plugin which

YARN-10020. Fix build instruction of hadoop-yarn-ui. #1750

YARN-10020. Fix build instruction of hadoop-yarn-ui. #1750

Uh oh!

Conversation

iwasakims commented Dec 10, 2019 • edited by goiri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Dec 17, 2019

Uh oh!

iwasakims commented Dec 18, 2019

Uh oh!

Uh oh!

iwasakims commented Dec 10, 2019 •

edited by goiri

Loading