-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-16748. Migrate to Python 3 and upgrade Yetus to 0.13.0 #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Python2 is still required in Dockerfile because releasedocmaker.py in Apache Yetus only supports Python2. |
(!) A patch to the testing environment has been detected. |
💔 -1 overall
This message was automatically generated. |
(!) A patch to the testing environment has been detected. |
💔 -1 overall
This message was automatically generated. |
Looks good to me overall, but I'm not Python expert to be +1 |
Thanks @liuml07 for review. |
💔 -1 overall
This message was automatically generated. |
@aajisaka If you would like to put this forward, I can help review and vote for a binding +1 Thanks! |
efb9bd6
to
6cbe83c
Compare
(!) A patch to the testing environment has been detected. |
TODOs
|
💔 -1 overall
This message was automatically generated. |
Umm. Pylint is still 1.9.2 in the precommit job. I updated the Dockerfile but it is not reflected. |
6c5ea0c
to
783f2af
Compare
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
e0cada5
to
63d6191
Compare
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
It seems that Python 2 is still used.
|
I found the root cause and opened a PR in Yetus: apache/yetus#212 |
Thank you @goiri for your review. I'll rebase this and wait for YETUS-1099 before committing. |
f4bd2c8
to
cc34617
Compare
(!) A patch to the testing environment has been detected. |
Umm. I think we need to release Yetus 0.13.1 |
(!) A patch to the testing environment has been detected. |
This reverts commit cc34617.
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
Now the patch is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aajisaka for working on that!
(!) A patch to the testing environment has been detected. |
@goiri @amahussein Would you check the latest patch? |
+1 (non-binding). |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Merged. Thank you @goiri @liuml07, and @amahussein. |
…#1738) - Upgrade Yetus to 0.13.0 to support Python 3 for the release scripts. - Removed determine-flaky-tests-hadoop.py. - Temporarily disabled shelldocs check due to YETUS-1099. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Reviewed-by: Mingliang Liu <liuml07@apache.org> (cherry picked from commit b9b49ed) Conflicts: dev-support/Jenkinsfile dev-support/docker/Dockerfile dev-support/docker/Dockerfile_aarch64
#### | ||
RUN pip2 install python-dateutil==2.7.3 | ||
RUN pip3 install pylint==2.6.0 python-dateutil==2.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line fails to run on arm64. it require python3-dev. I'll create a PR.
…#1738) - Upgrade Yetus to 0.13.0 to support Python 3 for the release scripts. - Removed determine-flaky-tests-hadoop.py. - Temporarily disabled shelldocs check due to YETUS-1099. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Reviewed-by: Mingliang Liu <liuml07@apache.org>
…#1738) - Upgrade Yetus to 0.13.0 to support Python 3 for the release scripts. - Removed determine-flaky-tests-hadoop.py. - Temporarily disabled shelldocs check due to YETUS-1099. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Reviewed-by: Mingliang Liu <liuml07@apache.org> (cherry picked from commit b9b49ed) Conflicts: dev-support/Jenkinsfile dev-support/bin/yetus-wrapper dev-support/docker/Dockerfile dev-support/docker/Dockerfile_aarch64
JIRA: https://issues.apache.org/jira/browse/HADOOP-16748
Fix formatting by IntelliJ IDEA Python plugin