HDFS-11148. Update DataNode to use StorageLocationChecker at startup. #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I664e5c719921ef5e0891bc392f37ee67639a8660
anuengineer
reviewed
Nov 16, 2016
| } | ||
|
|
||
| if (storageLocationChecker != null) { | ||
| storageLocationChecker.shutdownAndWait(10, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Something for you to consider, most of the other threads seems to shutdown much quicker, do we need to wait 10 seconds ?
There was a problem hiding this comment.
Good point. We can exit much quicker since a stalled disk check need not block shutdown at all. I'll change it to 1 second.
anuengineer
reviewed
Nov 16, 2016
| } | ||
|
|
||
| @Test(timeout = 30000) | ||
| public void testDataDirValidation() throws Throwable { |
There was a problem hiding this comment.
Presuming that we will have an equivalent or better test using storageLocationChecker ?
There was a problem hiding this comment.
Yes there's new tests in TestStorageLocationChecker added by HDFS-11119 which cover this better with different combinations of failed/healthy storages.
anuengineer
approved these changes
Nov 16, 2016
Also fix unit tests flagged by Jenkins.
…le ordering of StorageLocations at startup.
|
Arpit, thanks for updating the patch. +1. LGTM. |
|
This issue has been fixed. Closing this PR as well. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
This is not the solution posted in SAMZA-1228. For now, we are moving jmxserver lifecycle to be within the container. Ideally, it should be within the Streamprocessor so that the job coordinator can also be associated with the same instance. Author: Navina Ramesh <navina@apache.org> Reviewers: Xinyu Liu <xiliu@linkedin.com>, Prateek Maheshwari <pmaheshw@linkedin.com> Closes apache#162 from navina/SAMZA-1228
This was referenced Aug 24, 2025
This was referenced Sep 2, 2025
This was referenced Sep 12, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I664e5c719921ef5e0891bc392f37ee67639a8660