Skip to content

HDDS-2226. S3 Secrets should use a strong RNG. #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2019
Merged

HDDS-2226. S3 Secrets should use a strong RNG. #1572

merged 2 commits into from
Oct 3, 2019

Conversation

anuengineer
Copy link
Contributor

https://issues.apache.org/jira/browse/HDDS-2226

The S3 token generation under ozone should use a strong RNG.

I want to thank Jonathan Leitschuh, for originally noticing this issue and reporting it.

How tested: Ran Unit.sh

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 29 hadoop-hdds in trunk failed.
-1 mvninstall 31 hadoop-ozone in trunk failed.
-1 compile 18 hadoop-hdds in trunk failed.
-1 compile 13 hadoop-ozone in trunk failed.
+1 checkstyle 56 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 927 branch has no errors when building and testing our client artifacts.
-1 javadoc 19 hadoop-hdds in trunk failed.
-1 javadoc 16 hadoop-ozone in trunk failed.
0 spotbugs 1017 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 30 hadoop-hdds in trunk failed.
-1 findbugs 17 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 32 hadoop-hdds in the patch failed.
-1 mvninstall 34 hadoop-ozone in the patch failed.
-1 compile 20 hadoop-hdds in the patch failed.
-1 compile 16 hadoop-ozone in the patch failed.
-1 javac 20 hadoop-hdds in the patch failed.
-1 javac 16 hadoop-ozone in the patch failed.
-0 checkstyle 26 hadoop-ozone: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 779 patch has no errors when building and testing our client artifacts.
-1 javadoc 19 hadoop-hdds in the patch failed.
-1 javadoc 16 hadoop-ozone in the patch failed.
-1 findbugs 28 hadoop-hdds in the patch failed.
-1 findbugs 16 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 24 hadoop-hdds in the patch failed.
-1 unit 22 hadoop-ozone in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
2392
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/Dockerfile
GITHUB PR #1572
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 54792875d352 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 41440ec
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/testReport/
Max. process+thread count 340 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer
Copy link
Contributor Author

/retest

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 45 hadoop-hdds in trunk failed.
-1 mvninstall 43 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-hdds in trunk failed.
-1 compile 16 hadoop-ozone in trunk failed.
+1 checkstyle 59 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 859 branch has no errors when building and testing our client artifacts.
-1 javadoc 25 hadoop-hdds in trunk failed.
-1 javadoc 20 hadoop-ozone in trunk failed.
0 spotbugs 976 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 46 hadoop-hdds in trunk failed.
-1 findbugs 22 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 36 hadoop-hdds in the patch failed.
-1 mvninstall 38 hadoop-ozone in the patch failed.
-1 compile 25 hadoop-hdds in the patch failed.
-1 compile 20 hadoop-ozone in the patch failed.
-1 javac 25 hadoop-hdds in the patch failed.
-1 javac 20 hadoop-ozone in the patch failed.
+1 checkstyle 58 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 770 patch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in the patch failed.
-1 javadoc 20 hadoop-ozone in the patch failed.
-1 findbugs 33 hadoop-hdds in the patch failed.
-1 findbugs 21 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 28 hadoop-hdds in the patch failed.
-1 unit 25 hadoop-ozone in the patch failed.
+1 asflicense 33 The patch does not generate ASF License warnings.
2458
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/Dockerfile
GITHUB PR #1572
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a672f85dc6a7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0d2d6f9
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1572/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer
Copy link
Contributor Author

The build failure does not look like code issue. More like an infra problem.

[INFO] --- exec-maven-plugin:1.3.1:exec (dist) @ hadoop-ozone-dist --- /workdir/hadoop-ozone/dev-support/checks/build.sh: line 20: 44 Killed mvn -B -f pom.ozone.xml -Dmaven.javadoc.skip=true -DskipTests clean install

@elek
Copy link
Member

elek commented Oct 2, 2019

/retest

@anuengineer
Copy link
Contributor Author

Test failures are not related to this patch.

bharatviswa504
bharatviswa504 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@anuengineer anuengineer merged commit d59bcbf into apache:trunk Oct 3, 2019
@anuengineer
Copy link
Contributor Author

@bharatviswa504 Thanks for the review.

asfgit pushed a commit that referenced this pull request Oct 4, 2019
@anuengineer @nandakumar131
HDDS-2226. S3 Secrets should use a strong RNG. (#1572)
ddb395d 
(cherry picked from commit d59bcbf)
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
@anuengineer
HDDS-2226. S3 Secrets should use a strong RNG. (apache#1572)
ef4bc01
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
@anuengineer @RogPodge
HDDS-2226. S3 Secrets should use a strong RNG. (apache#1572)
d0d0116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatviswa504 bharatviswa504 bharatviswa504 approved these changes

Assignees
No one assigned
Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anuengineer @hadoop-yetus @elek @bharatviswa504