Skip to content

HADOOP-16568. S3A FullCredentialsTokenBinding fails if local credentials are unset #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

steveloughran
Copy link
Contributor

Move the local loading to deployUnbonded() (where they are required) and add a safety check when a new DT is requested

Change-Id: I516368c2c4a558a2a86e8cf107f77f1e40338261

@steveloughran
Copy link
Contributor Author

tested: ITests and manually. Obviously those itest tests aren't enough, but I couldn't think of a simple way to verify this

@steveloughran steveloughran added bug fs/s3 changes related to hadoop-aws; submitter must declare test endpoint labels Sep 13, 2019
@steveloughran steveloughran force-pushed the s3/HADOOP-16568-full-DT branch from f3cbdc3 to d6babd1 Compare March 9, 2020 15:58
@steveloughran
Copy link
Contributor Author

@lmccay could I get a quick review of this with the goal of getting it in to Hadoop 3.3.0? It just stops trying to load AWS credentials when deployed with a DT, but only in deployUnbonded. thanks

@steveloughran steveloughran requested a review from lmccay March 9, 2020 16:00
…als are unset.

Move the loading to deployUnbonded (where they are required) and add a safety check when a new DT is requested

Change-Id: I516368c2c4a558a2a86e8cf107f77f1e40338261
@steveloughran steveloughran force-pushed the s3/HADOOP-16568-full-DT branch from d6babd1 to ff9b6a5 Compare June 2, 2020 13:20
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 22m 56s trunk passed
+1 💚 compile 0m 32s trunk passed
+1 💚 checkstyle 0m 23s trunk passed
+1 💚 mvnsite 0m 38s trunk passed
+1 💚 shadedclient 16m 20s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 26s trunk passed
+0 🆗 spotbugs 1m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 58s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 32s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 mvnsite 0m 30s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 52s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 22s the patch passed
+1 💚 findbugs 1m 3s the patch passed
_ Other Tests _
+1 💚 unit 1m 26s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
65m 46s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1441/3/artifact/out/Dockerfile
GITHUB PR #1441
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9fe32c820c2d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9fe4c37
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1441/3/testReport/
Max. process+thread count 342 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1441/3/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Jun 3, 2020
@apache apache deleted a comment from hadoop-yetus Jun 3, 2020
Copy link
Contributor

@lmccay lmccay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@steveloughran steveloughran merged commit 40d63e0 into apache:trunk Jun 3, 2020
@steveloughran
Copy link
Contributor Author

thx.
PS: larry -when are you going to get an interesting icon? I can give you a choice of urban street art if you so desire

asfgit pushed a commit that referenced this pull request Jun 3, 2020
…als are unset. (#1441)

Contributed by Steve Loughran.

Move the loading to deployUnbonded (where they are required) and add a safety check when a new DT is requested

Change-Id: I03c69aa2e16accfccddca756b2771ff832e7dd58
@steveloughran steveloughran deleted the s3/HADOOP-16568-full-DT branch July 13, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fs/s3 changes related to hadoop-aws; submitter must declare test endpoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants