-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-16568. S3A FullCredentialsTokenBinding fails if local credentials are unset #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-16568. S3A FullCredentialsTokenBinding fails if local credentials are unset #1441
Conversation
tested: ITests and manually. Obviously those itest tests aren't enough, but I couldn't think of a simple way to verify this |
f3cbdc3
to
d6babd1
Compare
@lmccay could I get a quick review of this with the goal of getting it in to Hadoop 3.3.0? It just stops trying to load AWS credentials when deployed with a DT, but only in deployUnbonded. thanks |
…als are unset. Move the loading to deployUnbonded (where they are required) and add a safety check when a new DT is requested Change-Id: I516368c2c4a558a2a86e8cf107f77f1e40338261
d6babd1
to
ff9b6a5
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
thx. |
…als are unset. (#1441) Contributed by Steve Loughran. Move the loading to deployUnbonded (where they are required) and add a safety check when a new DT is requested Change-Id: I03c69aa2e16accfccddca756b2771ff832e7dd58
Move the local loading to deployUnbonded() (where they are required) and add a safety check when a new DT is requested
Change-Id: I516368c2c4a558a2a86e8cf107f77f1e40338261