HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1 #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
vinayakumarb
force-pushed
the
HADOOP-13363/HADOOP-16557
branch
2 times, most recently
from
275cc32
to
9220853
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
vinayakumarb
force-pushed
the
HADOOP-13363/HADOOP-16557
branch
from
9220853
to
45f331b
Compare
|
💔 -1 overall
This message was automatically generated. |
All new Javac errors are due to either Generated proto classes are proto dependency itself. Shaded client errors are due to not-using "-Ptest-patch" in the mvn command used to verify the shaded client errors. Used locally and found no errors.
Test "TestLargeBlockReport.testBlockReportExceedsLengthLimit" is related. CodedInputStream's default limit is hardcoded to 2GB from 64MB in 2.5.0. So now excecption thrown before start reading the RPC request itself. |
vinayakumarb
force-pushed
the
HADOOP-13363/HADOOP-16557
branch
from
45f331b
to
433f4f6
Compare
|
💔 -1 overall
This message was automatically generated. |
adamantal
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
LGTM (non-binding) overall.
From jenkins result:
- There's that last tiny little checkstlye that remained
- Regarding the failed tests:
- TestRouterFaultTolerant.testWriteWithFailedSubcluster is tracked in HDFS-14742
- TestDFSZKFailoverController.testManualFailoverWithDFSHAAdmin is a timeout - I see low risk in it
- TestRestartDfsWithFlush: I don't see an open case for this, but I presume it can be quite similar to HADOOP-16238.
- TestRouterHttpDelegationToken and TestRouterWithSecureStartup is handled in HDFS-14609
- I guess the deprecation warnings should be handled in a follow-up patch as you mentioned in the conversation in the jira.
I'm generally ok with this patch, would be happy to see it committed soon.
...t/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestLargeBlockReport.java
Show resolved
Hide resolved
saintstack
reviewed
Sep 17, 2019
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcWritable.java
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/BlockListAsLongs.java
Show resolved
Hide resolved
ayushtkn
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Thanx @vinayakumarb for the work here. I guess you need to update in the Building.txt too the new protobuf version.
Other than that LGTM
saintstack
approved these changes
Sep 19, 2019
Thanks @ayushtkn. updated BUILDING.txt instructions.
Did the quick test, connecting Hadoop-3.2.0 client to Hadoop-3.3.0-SNAPSHOT server with upgraded protobuf. Client was able to communicate successfully to server. |
|
Thanks @adamantal @saintstack @ayushtkn for reviews. |
|
Good. Thanks. |
|
@vinayakumarb - is there a jira etc to track the shadedclient failure and fix? (The missing -Ptest-patch causes protoc-3.7 to not be found which causes the failures?) Also, Thank you for making this change. The protobuf upgrade has been pending for a while. |
|
I doubled-checked the HDFS fsimage format compatibility. Today's trunk build was able to read a 16GB image written by a 2.8.5 namenode without any problem. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…1432) HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1. Contributed by Vinayakumar B.
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…1432) HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1. Contributed by Vinayakumar B.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.