Skip to content

HDDS-2089: Add createPipeline CLI. #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

timmylicheng
Copy link
Contributor

#HDDS-2089 Add createPipeline for ozone scmcli

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 158 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HDDS-1564 Compile Tests _
0 mvndep 45 Maven dependency ordering for branch
+1 mvninstall 828 HDDS-1564 passed
+1 compile 475 HDDS-1564 passed
+1 checkstyle 96 HDDS-1564 passed
+1 mvnsite 0 HDDS-1564 passed
+1 shadedclient 938 branch has no errors when building and testing our client artifacts.
+1 javadoc 189 HDDS-1564 passed
0 spotbugs 468 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 688 HDDS-1564 passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 579 the patch passed
+1 compile 411 the patch passed
+1 javac 411 the patch passed
+1 checkstyle 93 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 690 patch has no errors when building and testing our client artifacts.
+1 javadoc 189 the patch passed
+1 findbugs 701 the patch passed
_ Other Tests _
+1 unit 369 hadoop-hdds in the patch passed.
-1 unit 2715 hadoop-ozone in the patch failed.
+1 asflicense 55 The patch does not generate ASF License warnings.
9437
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestContainerStateMachineFailures
hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
hadoop.ozone.client.rpc.Test2WayCommitInRatis
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/1/artifact/out/Dockerfile
GITHUB PR #1418
JIRA Issue HDDS-2089
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 453a8f9466f1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision HDDS-1564 / 753fc67
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/1/testReport/
Max. process+thread count 5408 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-hdds/tools U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add an acceptance test for the new command?

@timmylicheng
Copy link
Contributor Author

timmylicheng commented Sep 12, 2019

LGTM, can you add an acceptance test for the new command?

I've created a new JIRA for adding acceptance test for all Pipeline related CLI. https://issues.apache.org/jira/browse/HDDS-2115

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HDDS-1564 Compile Tests _
0 mvndep 21 Maven dependency ordering for branch
+1 mvninstall 584 HDDS-1564 passed
+1 compile 378 HDDS-1564 passed
+1 checkstyle 81 HDDS-1564 passed
+1 mvnsite 0 HDDS-1564 passed
+1 shadedclient 876 branch has no errors when building and testing our client artifacts.
+1 javadoc 174 HDDS-1564 passed
0 spotbugs 416 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 608 HDDS-1564 passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 543 the patch passed
+1 compile 388 the patch passed
+1 javac 388 the patch passed
+1 checkstyle 85 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 657 patch has no errors when building and testing our client artifacts.
+1 javadoc 176 the patch passed
+1 findbugs 658 the patch passed
_ Other Tests _
+1 unit 296 hadoop-hdds in the patch passed.
-1 unit 1903 hadoop-ozone in the patch failed.
+1 asflicense 53 The patch does not generate ASF License warnings.
7715
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/2/artifact/out/Dockerfile
GITHUB PR #1418
JIRA Issue HDDS-2089
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f80e9d4d566c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision HDDS-1564 / 753fc67
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/2/testReport/
Max. process+thread count 4872 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-hdds/tools U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1418/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao xiaoyuyao merged commit 326b5ac into apache:HDDS-1564 Sep 12, 2019
@timmylicheng timmylicheng deleted the hdds-2089 branch September 16, 2019 02:29
asfgit pushed a commit that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants