Skip to content

[WIP] HDFS-14801. PrometheusMetricsSink: Better support for NNTop. #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] HDFS-14801. PrometheusMetricsSink: Better support for NNTop. #1392

wants to merge 2 commits into from

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Sep 2, 2019

@aajisaka
HDFS-14801. PrometheusMetricsSink: Better support for NNTop.
cbf55e2
@aajisaka
Make PrometheusMetricsSink faster
f20da1b 
* Fixed some bugs
* Renamed key to be compatible with other metrics
* Match '*' as op
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 1 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1180 trunk passed
+1 compile 1021 trunk passed
+1 checkstyle 43 trunk passed
+1 mvnsite 77 trunk passed
+1 shadedclient 849 branch has no errors when building and testing our client artifacts.
+1 javadoc 63 trunk passed
0 spotbugs 120 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 118 trunk passed
_ Patch Compile Tests _
+1 mvninstall 47 the patch passed
+1 compile 985 the patch passed
+1 javac 985 the patch passed
+1 checkstyle 42 the patch passed
+1 mvnsite 73 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 725 patch has no errors when building and testing our client artifacts.
+1 javadoc 62 the patch passed
+1 findbugs 127 the patch passed
_ Other Tests _
-1 unit 527 hadoop-common in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
6085
Reason Tests
Failed junit tests hadoop.fs.viewfs.TestViewFsTrash
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/1/artifact/out/Dockerfile
GITHUB PR #1392
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5505c380c41a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 040f6e9
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/1/testReport/
Max. process+thread count 1467 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1030 trunk passed
+1 compile 980 trunk passed
+1 checkstyle 50 trunk passed
+1 mvnsite 84 trunk passed
+1 shadedclient 832 branch has no errors when building and testing our client artifacts.
+1 javadoc 71 trunk passed
0 spotbugs 123 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 121 trunk passed
_ Patch Compile Tests _
+1 mvninstall 46 the patch passed
+1 compile 923 the patch passed
+1 javac 923 the patch passed
+1 checkstyle 49 the patch passed
+1 mvnsite 80 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 693 patch has no errors when building and testing our client artifacts.
+1 javadoc 71 the patch passed
+1 findbugs 129 the patch passed
_ Other Tests _
+1 unit 542 hadoop-common in the patch passed.
+1 asflicense 52 The patch does not generate ASF License warnings.
5875
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/2/artifact/out/Dockerfile
GITHUB PR #1392
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8094a8a940de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 040f6e9
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/2/testReport/
Max. process+thread count 1376 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1392/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka changed the title HDFS-14801. PrometheusMetricsSink: Better support for NNTop. [WIP] HDFS-14801. PrometheusMetricsSink: Better support for NNTop. Sep 11, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 20m 10s trunk passed
+1 💚 compile 21m 14s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 18m 17s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 47s trunk passed
+1 💚 mvnsite 1m 25s trunk passed
+1 💚 shadedclient 16m 26s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 35s hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 0m 56s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 2m 13s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 11s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 19m 43s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 19m 43s the patch passed
+1 💚 compile 18m 23s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 18m 23s the patch passed
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 mvnsite 1m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 41s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 38s hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚 javadoc 1m 3s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 2m 29s the patch passed
_ Other Tests _
-1 ❌ unit 9m 31s hadoop-common in the patch passed.
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
154m 3s
Reason Tests
Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/artifact/out/Dockerfile
GITHUB PR #1392
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a9f86d129b02 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e756fe3
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/testReport/
Max. process+thread count 1439 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1392/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

Duplicate of HADOOP-17893 (#3426). Closing

@aajisaka aajisaka closed this Sep 21, 2021
@aajisaka aajisaka deleted the HDFS-14801 branch September 21, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aajisaka @hadoop-yetus