HDDS-1843. Undetectable corruption after restart of a datanode. #1364

bshashikant · 2019-08-28T06:17:32Z

No description provided.

hadoop-yetus · 2019-08-28T14:00:12Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:14Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:15Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:16Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:18Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:19Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:21Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:22Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:24Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:25Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:27Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:28Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:30Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:32Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:33Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:35Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:36Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:44Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:46Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:47Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:49Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:50Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:52Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:53Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:55Z

hadoop-hdds/common/src/main/resources/audit.log

whitespace:end of line

hadoop-yetus · 2019-08-28T14:00:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	67	Maven dependency ordering for branch
+1	mvninstall	620	trunk passed
+1	compile	385	trunk passed
+1	checkstyle	76	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	846	branch has no errors when building and testing our client artifacts.
+1	javadoc	177	trunk passed
0	spotbugs	429	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	629	trunk passed
		_ Patch Compile Tests _
0	mvndep	36	Maven dependency ordering for patch
+1	mvninstall	547	the patch passed
+1	compile	393	the patch passed
+1	cc	393	the patch passed
+1	javac	393	the patch passed
-0	checkstyle	39	hadoop-hdds: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0	checkstyle	42	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	661	patch has no errors when building and testing our client artifacts.
+1	javadoc	175	the patch passed
-1	findbugs	213	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	1060	hadoop-hdds in the patch failed.
-1	unit	2707	hadoop-ozone in the patch failed.
+1	asflicense	52	The patch does not generate ASF License warnings.
		9393

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(ContainerProtos$ContainerCommandRequestProto, DispatcherContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:[line 241]
Failed junit tests	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.container.metrics.TestContainerMetrics
	hadoop.ozone.scm.TestXceiverClientMetrics
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 487bb680b6dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `55cc115`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/whitespace-eol.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/testReport/
Max. process+thread count	5270 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-28T23:22:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	78	Maven dependency ordering for branch
+1	mvninstall	667	trunk passed
+1	compile	426	trunk passed
+1	checkstyle	75	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	956	branch has no errors when building and testing our client artifacts.
+1	javadoc	183	trunk passed
0	spotbugs	432	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	645	trunk passed
		_ Patch Compile Tests _
0	mvndep	39	Maven dependency ordering for patch
+1	mvninstall	561	the patch passed
+1	compile	410	the patch passed
+1	cc	410	the patch passed
+1	javac	410	the patch passed
-0	checkstyle	40	hadoop-hdds: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0	checkstyle	44	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	738	patch has no errors when building and testing our client artifacts.
+1	javadoc	187	the patch passed
-1	findbugs	235	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	1062	hadoop-hdds in the patch failed.
-1	unit	202	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		7267

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(ContainerProtos$ContainerCommandRequestProto, DispatcherContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:[line 241]
Failed junit tests	hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 6ae0c04c33e0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6f2226a`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/diff-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/whitespace-eol.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/testReport/
Max. process+thread count	413 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-28T23:57:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	144	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	81	Maven dependency ordering for branch
+1	mvninstall	688	trunk passed
+1	compile	401	trunk passed
+1	checkstyle	86	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	924	branch has no errors when building and testing our client artifacts.
+1	javadoc	182	trunk passed
0	spotbugs	444	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	666	trunk passed
		_ Patch Compile Tests _
0	mvndep	36	Maven dependency ordering for patch
+1	mvninstall	593	the patch passed
+1	compile	417	the patch passed
+1	cc	417	the patch passed
+1	javac	417	the patch passed
-0	checkstyle	42	hadoop-hdds: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0	checkstyle	40	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	752	patch has no errors when building and testing our client artifacts.
+1	javadoc	179	the patch passed
-1	findbugs	272	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1	findbugs	422	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	1102	hadoop-hdds in the patch failed.
-1	unit	506	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		7750

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(ContainerProtos$ContainerCommandRequestProto, DispatcherContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:[line 241]

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 8d1d475f5d3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6f2226a`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/diff-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/whitespace-eol.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/new-findbugs-hadoop-hdds.html
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/testReport/
Max. process+thread count	1371 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-09-03T00:34:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	25	Maven dependency ordering for branch
+1	mvninstall	580	trunk passed
+1	compile	406	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	908	branch has no errors when building and testing our client artifacts.
+1	javadoc	175	trunk passed
0	spotbugs	473	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	693	trunk passed
		_ Patch Compile Tests _
0	mvndep	37	Maven dependency ordering for patch
+1	mvninstall	609	the patch passed
+1	compile	399	the patch passed
+1	cc	399	the patch passed
+1	javac	399	the patch passed
-0	checkstyle	37	hadoop-hdds: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0	checkstyle	41	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	643	patch has no errors when building and testing our client artifacts.
+1	javadoc	177	the patch passed
-1	findbugs	234	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	275	hadoop-hdds in the patch passed.
-1	unit	2571	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		8591

Reason	Tests
FindBugs	module:hadoop-hdds
	org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(ContainerProtos$ContainerCommandRequestProto, DispatcherContext) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:Long(long) constructor; use Long.valueOf(long) instead At HddsDispatcher.java:[line 241]
Failed junit tests	hadoop.ozone.TestContainerOperations
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.ozone.TestContainerStateMachineIdempotency
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.container.metrics.TestContainerMetrics
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.scm.TestXceiverClientMetrics
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 23e0b2fdc078 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `915cbc9`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/whitespace-eol.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/testReport/
Max. process+thread count	5320 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

...tainer-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java

...-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java

...a/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java

nandakumar131

Overall the patch looks good, added some minor comments.

nandakumar131 · 2019-09-04T15:58:26Z

hadoop-hdds/common/src/main/proto/DatanodeContainerProtocol.proto

Never used, can be removed.

address in the next patch.

nandakumar131 · 2019-09-04T15:59:11Z

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java

computeIfPresent is not needed here, can be replaced with Map#put.

will address in the next patch.

bshashikant · 2019-09-04T18:04:11Z

/retest

mukul1987

The patch generally looks good to me. A couple of questions, they might already be implemented
a) Do we sync the container db's wal on close?
b) Also, for on restart, we should run the scanner, will this identification step run before this?

mukul1987 · 2019-09-04T18:59:20Z

...tainer-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java

Lets make this multi threaded, so that on restart, this state is reached a lot faster.

AFAIK, the missing container determination step is the last step executed as a part of initialization of RaftGroup which calls into loadSnapshot. Just doing it in a separate thread and waiting it in the main thread may not help it to restart faster.

We can change the code to use parallel stream to process the map to make it faster.

hadoop-yetus · 2019-09-04T23:01:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	70	Maven dependency ordering for branch
+1	mvninstall	617	trunk passed
+1	compile	395	trunk passed
+1	checkstyle	78	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	890	branch has no errors when building and testing our client artifacts.
+1	javadoc	176	trunk passed
0	spotbugs	444	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	646	trunk passed
		_ Patch Compile Tests _
0	mvndep	40	Maven dependency ordering for patch
+1	mvninstall	556	the patch passed
+1	compile	391	the patch passed
+1	cc	391	the patch passed
+1	javac	391	the patch passed
+1	checkstyle	86	the patch passed
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedclient	691	patch has no errors when building and testing our client artifacts.
+1	javadoc	180	the patch passed
+1	findbugs	669	the patch passed
		_ Other Tests _
+1	unit	288	hadoop-hdds in the patch passed.
-1	unit	2037	hadoop-ozone in the patch failed.
+1	asflicense	52	The patch does not generate ASF License warnings.
		8110

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.om.TestSecureOzoneManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/5/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 8df624d8e13a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `337e9b7`
Default Java	1.8.0_222
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/5/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/5/testReport/
Max. process+thread count	5375 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bshashikant · 2019-09-05T07:19:34Z

a) Do we sync the container db's wal on close?
-- The entire rocks db is synced as a part of closing the container.
b) Also, for on restart, we should run the scanner, will this identification step run before this?
--- Yes, identification step is executed before the the scrubber starts.

hadoop-yetus · 2019-09-05T09:46:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	71	Maven dependency ordering for branch
+1	mvninstall	720	trunk passed
+1	compile	422	trunk passed
+1	checkstyle	85	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1086	branch has no errors when building and testing our client artifacts.
+1	javadoc	208	trunk passed
0	spotbugs	436	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	702	trunk passed
-0	patch	478	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	540	the patch passed
+1	compile	372	the patch passed
+1	cc	372	the patch passed
+1	javac	372	the patch passed
+1	checkstyle	77	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	751	patch has no errors when building and testing our client artifacts.
+1	javadoc	178	the patch passed
+1	findbugs	654	the patch passed
		_ Other Tests _
+1	unit	263	hadoop-hdds in the patch passed.
-1	unit	2130	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		8527

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/6/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 71935b58ecf5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `f347c34`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/6/testReport/
Max. process+thread count	4726 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-09-05T11:11:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	581	trunk passed
+1	compile	376	trunk passed
+1	checkstyle	81	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	869	branch has no errors when building and testing our client artifacts.
+1	javadoc	178	trunk passed
0	spotbugs	416	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	611	trunk passed
-0	patch	475	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	38	Maven dependency ordering for patch
+1	mvninstall	538	the patch passed
+1	compile	391	the patch passed
+1	cc	391	the patch passed
+1	javac	391	the patch passed
-0	checkstyle	43	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	665	patch has no errors when building and testing our client artifacts.
+1	javadoc	175	the patch passed
+1	findbugs	631	the patch passed
		_ Other Tests _
+1	unit	283	hadoop-hdds in the patch passed.
-1	unit	2556	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		8415

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/8/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 8b805e111dba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `172bcd8`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/8/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/8/testReport/
Max. process+thread count	5406 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

nandakumar131 · 2019-09-06T09:10:38Z

...tainer-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java

This should be LOG.error

nandakumar131 · 2019-09-06T09:21:04Z

@bshashikant you might need to rebase the changes on top of HDDS-1561. Even though there is no conflict, the compilation fails.

hadoop-yetus · 2019-09-06T13:09:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	66	Maven dependency ordering for branch
+1	mvninstall	588	trunk passed
+1	compile	382	trunk passed
+1	checkstyle	81	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	872	branch has no errors when building and testing our client artifacts.
+1	javadoc	179	trunk passed
0	spotbugs	421	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	616	trunk passed
		_ Patch Compile Tests _
0	mvndep	41	Maven dependency ordering for patch
+1	mvninstall	575	the patch passed
+1	compile	389	the patch passed
+1	cc	389	the patch passed
+1	javac	389	the patch passed
+1	checkstyle	83	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	700	patch has no errors when building and testing our client artifacts.
+1	javadoc	177	the patch passed
+1	findbugs	687	the patch passed
		_ Other Tests _
+1	unit	298	hadoop-hdds in the patch passed.
-1	unit	200	hadoop-ozone in the patch failed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		6200

Reason	Tests
Failed junit tests	hadoop.ozone.om.ratis.TestOzoneManagerRatisServer

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/9/artifact/out/Dockerfile
GITHUB PR	#1364
Optional Tests	dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle
uname	Linux 806a3bdb7024 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6e4cdf8`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/9/testReport/
Max. process+thread count	1298 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

supratimdeka

+1

…ibuted by Shashikant Banerjee(#1364).

bshashikant · 2019-09-09T17:15:52Z

Thanks @nandakumar131 @mukul1987 @supratimdeka for the reviews. I have committed this change to trunk.

mukul1987 · 2019-09-10T07:26:47Z

/label ozone

…ibuted by Shashikant Banerjee(apache#1364).

bshashikant requested a review from mukul1987 August 28, 2019 06:17