Skip to content

HDDS-2022. Add additional freon tests #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

elek
Copy link
Member

@elek elek commented Aug 23, 2019

Freon is a generic load generator tool for ozone (ozone freon) which supports multiple generation pattern.

As of now only the random-key-generator is implemented which uses ozone rpc client.

It would be great to add additional tests:

  • Test key generation via s3 interface
  • Test key generation via the hadoop fs interface
  • Test key reads (validation)
  • Test OM with direct RPC calls

See: https://issues.apache.org/jira/browse/HDDS-2022

@elek elek added the ozone label Aug 23, 2019
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @elek. The change looks promising. I noticed an attempt to create duplicate items due to using number of prior successful tasks to identify new ones. Will continue reviewing, but you might want to fix it in the meantime.

@apache apache deleted a comment from hadoop-yetus Aug 29, 2019
@apache apache deleted a comment from hadoop-yetus Aug 29, 2019
@apache apache deleted a comment from hadoop-yetus Aug 29, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 555 trunk passed
+1 compile 368 trunk passed
+1 checkstyle 74 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 858 branch has no errors when building and testing our client artifacts.
+1 javadoc 170 trunk passed
0 spotbugs 412 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 608 trunk passed
_ Patch Compile Tests _
+1 mvninstall 550 the patch passed
+1 compile 394 the patch passed
+1 javac 394 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 686 patch has no errors when building and testing our client artifacts.
+1 javadoc 173 the patch passed
-1 findbugs 443 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 321 hadoop-hdds in the patch passed.
-1 unit 2211 hadoop-ozone in the patch failed.
+1 asflicense 53 The patch does not generate ASF License warnings.
7975
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Failed junit tests hadoop.ozone.client.rpc.TestContainerStateMachineFailures
hadoop.ozone.TestStorageContainerManager
hadoop.hdds.scm.pipeline.TestNode2PipelineMap
hadoop.hdds.scm.pipeline.TestNodeFailure
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy
hadoop.ozone.TestOzoneConfigurationFields
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/4/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 9fa56b5cb164 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c749f62
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/4/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/4/testReport/
Max. process+thread count 4990 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 585 trunk passed
+1 compile 364 trunk passed
+1 checkstyle 73 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 885 branch has no errors when building and testing our client artifacts.
+1 javadoc 167 trunk passed
0 spotbugs 415 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 620 trunk passed
_ Patch Compile Tests _
+1 mvninstall 528 the patch passed
+1 compile 368 the patch passed
+1 javac 368 the patch passed
+1 checkstyle 81 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 679 patch has no errors when building and testing our client artifacts.
+1 javadoc 171 the patch passed
-1 findbugs 447 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 321 hadoop-hdds in the patch passed.
-1 unit 1746 hadoop-ozone in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
7539
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Failed junit tests hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.client.rpc.TestBlockOutputStream
hadoop.ozone.TestOzoneConfigurationFields
hadoop.ozone.client.rpc.TestReadRetries
hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/6/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 0e868ea3a3bd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8c0759d
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/6/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/6/testReport/
Max. process+thread count 4138 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 720 trunk passed
+1 compile 457 trunk passed
+1 checkstyle 82 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1057 branch has no errors when building and testing our client artifacts.
+1 javadoc 168 trunk passed
0 spotbugs 443 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 646 trunk passed
_ Patch Compile Tests _
+1 mvninstall 557 the patch passed
+1 compile 378 the patch passed
+1 javac 378 the patch passed
+1 checkstyle 77 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 721 patch has no errors when building and testing our client artifacts.
+1 javadoc 179 the patch passed
-1 findbugs 466 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 319 hadoop-hdds in the patch passed.
-1 unit 1671 hadoop-ozone in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
8029
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Failed junit tests hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.TestOzoneConfigurationFields
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/8/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 4161aff6ab9d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8c0759d
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/8/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/8/testReport/
Max. process+thread count 5327 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 88 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 636 trunk passed
+1 compile 380 trunk passed
+1 checkstyle 75 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1040 branch has no errors when building and testing our client artifacts.
+1 javadoc 205 trunk passed
0 spotbugs 528 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 779 trunk passed
_ Patch Compile Tests _
+1 mvninstall 718 the patch passed
+1 compile 448 the patch passed
+1 javac 448 the patch passed
+1 checkstyle 99 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 3 The patch has no ill-formed XML file.
+1 shadedclient 843 patch has no errors when building and testing our client artifacts.
+1 javadoc 208 the patch passed
-1 findbugs 497 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 416 hadoop-hdds in the patch passed.
-1 unit 1448 hadoop-ozone in the patch failed.
+1 asflicense 58 The patch does not generate ASF License warnings.
8423
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/7/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux a1a0731336e9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8c0759d
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/7/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/7/testReport/
Max. process+thread count 2376 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 176 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 807 trunk passed
+1 compile 492 trunk passed
+1 checkstyle 99 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1143 branch has no errors when building and testing our client artifacts.
+1 javadoc 224 trunk passed
0 spotbugs 506 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 772 trunk passed
_ Patch Compile Tests _
+1 mvninstall 678 the patch passed
+1 compile 455 the patch passed
+1 javac 455 the patch passed
+1 checkstyle 96 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 4 The patch has no ill-formed XML file.
+1 shadedclient 893 patch has no errors when building and testing our client artifacts.
+1 javadoc 211 the patch passed
-1 findbugs 499 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 408 hadoop-hdds in the patch passed.
-1 unit 3186 hadoop-ozone in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
10640
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Failed junit tests hadoop.ozone.client.rpc.TestDeleteWithSlowFollower
hadoop.ozone.om.TestSecureOzoneManager
hadoop.ozone.client.rpc.Test2WayCommitInRatis
hadoop.ozone.client.rpc.TestBlockOutputStream
hadoop.ozone.TestOzoneConfigurationFields
hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
hadoop.ozone.om.TestOMRatisSnapshots
hadoop.ozone.client.rpc.TestFailureHandlingByClient
hadoop.ozone.TestMiniChaosOzoneCluster
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/5/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 13789faf097b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8c0759d
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/5/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/5/testReport/
Max. process+thread count 3710 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 637 trunk passed
+1 compile 421 trunk passed
+1 checkstyle 70 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 969 branch has no errors when building and testing our client artifacts.
+1 javadoc 181 trunk passed
0 spotbugs 474 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 701 trunk passed
_ Patch Compile Tests _
+1 mvninstall 589 the patch passed
+1 compile 372 the patch passed
+1 javac 372 the patch passed
+1 checkstyle 100 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 732 patch has no errors when building and testing our client artifacts.
+1 javadoc 185 the patch passed
-1 findbugs 452 hadoop-ozone generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
_ Other Tests _
+1 unit 267 hadoop-hdds in the patch passed.
-1 unit 1620 hadoop-ozone in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
7785
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:volume in org.apache.hadoop.ozone.freon.BaseFreonGenerator.ensureVolumeAndBucketExist(OzoneConfiguration, String, String) on exception path Dereferenced at BaseFreonGenerator.java:[line 263]
Unused field:OzoneClientKeyValidator.java
Unused field:OzoneClientKeyValidator.java
Dead store to configuration in org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:org.apache.hadoop.ozone.freon.S3KeyGenerator.call() At S3KeyGenerator.java:[line 78]
Unused field:SameKeyReader.java
Unused field:SameKeyReader.java
Failed junit tests hadoop.hdds.scm.pipeline.TestSCMPipelineManager
hadoop.ozone.om.TestSecureOzoneManager
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/9/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux fbcbc6db13ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 915cbc9
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/9/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/9/testReport/
Max. process+thread count 4967 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek and others added 7 commits September 14, 2019 06:36
…/OzoneClientKeyValidator.java

Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
…/OzoneClientKeyValidator.java

Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
…/HadoopFsValidator.java

Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
…/BaseFreonGenerator.java

Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 153 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 35 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-ozone in trunk failed.
-0 checkstyle 37 The patch fails to run checkstyle in hadoop-ozone
+1 mvnsite 0 trunk passed
+1 shadedclient 990 branch has no errors when building and testing our client artifacts.
-1 javadoc 100 hadoop-ozone in trunk failed.
0 spotbugs 187 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 28 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 35 hadoop-ozone in the patch failed.
-1 compile 25 hadoop-ozone in the patch failed.
-1 javac 25 hadoop-ozone in the patch failed.
-0 checkstyle 38 The patch fails to run checkstyle in hadoop-ozone
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 821 patch has no errors when building and testing our client artifacts.
-1 javadoc 91 hadoop-ozone in the patch failed.
-1 findbugs 28 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 198 hadoop-hdds in the patch failed.
-1 unit 30 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
3684
Reason Tests
Failed junit tests hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.container.keyvalue.TestKeyValueContainer
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/Dockerfile
GITHUB PR #1341
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux e83069eba372 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9a931b8
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/branch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1341/out/maven-branch-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1341/out/maven-patch-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1341/10/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@elek
Copy link
Member Author

elek commented Sep 16, 2019

/retest

Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@elek elek closed this in 15fded2 Sep 18, 2019
@elek
Copy link
Member Author

elek commented Sep 18, 2019

Merged to the trunk. Thanks @adoroszlai and @arp7 the reviews.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants