HDFS-14761. RBF: MountTableResolver cannot invalidate cache correctly #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Aug 22, 2019
| @@ -704,4 +704,26 @@ public void testLocationCache() throws Exception { | |||
| mountTable.removeEntry("/testlocationcache"); | |||
| mountTable.removeEntry("/anothertestlocationcache"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testInvalidateCache() throws Exception { | |||
There was a problem hiding this comment.
Add a comment describing what the case to test is about.
There was a problem hiding this comment.
Thanks for your comments. I have added some comments. Pending jenkins. Please review again.
There was a problem hiding this comment.
The high level description should go as a javadoc.
You can add the particular comments inline.
There was a problem hiding this comment.
Thanks again. New commit here. Pending jenkins.
goiri
approved these changes
Aug 23, 2019
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…apache#1334) HDFS-14761. RBF: MountTableResolver cannot invalidate cache correctly
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…apache#1334) HDFS-14761. RBF: MountTableResolver cannot invalidate cache correctly
Xushaohong
pushed a commit
to Xushaohong/hadoop
that referenced
this pull request
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.