-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. #1316
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
...src/main/java/org/apache/hadoop/ozone/om/request/security/OMRenewDelegationTokenRequest.java
Outdated
Show resolved
Hide resolved
UpdateRenewDelegationTokenRequest.newBuilder() | ||
.setRenewDelegationTokenRequest(renewDelegationTokenRequest) | ||
.setRenewDelegationTokenResponse(renewResponse)) | ||
.setCmdType(getOmRequest().getCmdType()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the cmd type of UpdateRenewDelegationTokenRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being done intentionally so that we don't need new class or some special handling in OMRatisUtils createOMClientRequest().
Same is explained in the code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An UpdateRenewDelegationTokenRequest body with RenewDelegationTokenRequest type in OMRequest is a bit hacky. But I'm OK with it if otherwise takes too much changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya can understand that. Otherwise, we need some changes in createClientRequest in ratis to act upon UpdateRenewDelegationTokenRequest or RenewDelegationTokenRequest to return OMGetDelegationTokenRequest object or have separate new classes for both of them. And for one only preExecute will be needed, for other validateAndUpdateCache only will be needed. So, I will leave this as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is a bit hard to follow. I also had a long discussion with Bharat while reviewing the createDelegationToken patch. I am okay to live with for now to avoid creating yet another request class.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lgtm.
Okay to commit assuming @xiaoyuyao is also +1.
@xiaoyuyao Can I proceed with commit? |
+1 from me as well. Seems the CI is broken pending fix from HDDS-1999/2000. |
Test failures are not related to this patch. |
No description provided.