HDDS-1973. Implement OM RenewDelegationToken request to use Cache and DoubleBuffer. #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatviswa504
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Aug 20, 2019
...src/main/java/org/apache/hadoop/ozone/om/request/security/OMRenewDelegationTokenRequest.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Aug 20, 2019
| UpdateRenewDelegationTokenRequest.newBuilder() | ||
| .setRenewDelegationTokenRequest(renewDelegationTokenRequest) | ||
| .setRenewDelegationTokenResponse(renewResponse)) | ||
| .setCmdType(getOmRequest().getCmdType()) |
There was a problem hiding this comment.
Should we use the cmd type of UpdateRenewDelegationTokenRequest
There was a problem hiding this comment.
This is being done intentionally so that we don't need new class or some special handling in OMRatisUtils createOMClientRequest().
Same is explained in the code comments.
There was a problem hiding this comment.
An UpdateRenewDelegationTokenRequest body with RenewDelegationTokenRequest type in OMRequest is a bit hacky. But I'm OK with it if otherwise takes too much changes.
There was a problem hiding this comment.
Ya can understand that. Otherwise, we need some changes in createClientRequest in ratis to act upon UpdateRenewDelegationTokenRequest or RenewDelegationTokenRequest to return OMGetDelegationTokenRequest object or have separate new classes for both of them. And for one only preExecute will be needed, for other validateAndUpdateCache only will be needed. So, I will leave this as it is.
There was a problem hiding this comment.
I agree this is a bit hard to follow. I also had a long discussion with Bharat while reviewing the createDelegationToken patch. I am okay to live with for now to avoid creating yet another request class.
|
💔 -1 overall
This message was automatically generated. |
arp7
approved these changes
Aug 21, 2019
|
@xiaoyuyao Can I proceed with commit? |
|
+1 from me as well. Seems the CI is broken pending fix from HDDS-1999/2000. |
|
Test failures are not related to this patch. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.