Skip to content

HDDS-1927. Consolidate add/remove Acl into OzoneAclUtil class. Contri… #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xiaoyuyao
Copy link
Contributor

@xiaoyuyao xiaoyuyao commented Aug 9, 2019

What have been changed:

  1. Change OzoneKeyInfo to use OzoneAcl instead of OzoneAclInfo
  2. Adding OzoneAclUtil#addAcl, removeAcl to consolidate the logic applies to both bucket and key.
    Will file a separate ticket to fix volume as it is currently using OzoneAclMap.
  3. Adding TestOzoneAclUtil to cover misc add/remove cases
  4. Fix the defaultAcl merge issue when inheriting by using the OzoneAclUtil#addAcl
  5. Fix failures in TestOzoneRpcClientAbract and its subclasses.

@xiaoyuyao xiaoyuyao self-assigned this Aug 9, 2019
@xiaoyuyao xiaoyuyao added the ozone label Aug 9, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 588 trunk passed
+1 compile 362 trunk passed
+1 checkstyle 71 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 845 branch has no errors when building and testing our client artifacts.
+1 javadoc 148 trunk passed
0 spotbugs 422 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 616 trunk passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 533 the patch passed
+1 compile 355 the patch passed
+1 javac 355 the patch passed
-0 checkstyle 32 hadoop-ozone: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 603 patch has no errors when building and testing our client artifacts.
-1 javadoc 85 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 findbugs 656 the patch passed
_ Other Tests _
+1 unit 295 hadoop-hdds in the patch passed.
-1 unit 1982 hadoop-ozone in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
7544
Reason Tests
Failed junit tests hadoop.ozone.om.TestKeyManagerImpl
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.om.TestOzoneManagerHA
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2fad9f5b2750 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 98dd7c4
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/testReport/
Max. process+thread count 4981 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 32 Maven dependency ordering for branch
+1 mvninstall 610 trunk passed
+1 compile 372 trunk passed
+1 checkstyle 81 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 884 branch has no errors when building and testing our client artifacts.
+1 javadoc 168 trunk passed
0 spotbugs 414 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 611 trunk passed
_ Patch Compile Tests _
0 mvndep 27 Maven dependency ordering for patch
+1 mvninstall 555 the patch passed
+1 compile 379 the patch passed
+1 javac 379 the patch passed
-0 checkstyle 42 hadoop-ozone: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 677 patch has no errors when building and testing our client artifacts.
-1 javadoc 93 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 findbugs 640 the patch passed
_ Other Tests _
+1 unit 292 hadoop-hdds in the patch passed.
-1 unit 1705 hadoop-ozone in the patch failed.
+1 asflicense 54 The patch does not generate ASF License warnings.
7564
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.ozone.om.TestKeyManagerImpl
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2dfcc121f70d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 98dd7c4
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/testReport/
Max. process+thread count 4089 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 33 Maven dependency ordering for branch
+1 mvninstall 588 trunk passed
+1 compile 356 trunk passed
+1 checkstyle 70 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 904 branch has no errors when building and testing our client artifacts.
+1 javadoc 160 trunk passed
0 spotbugs 417 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 610 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 544 the patch passed
+1 compile 362 the patch passed
+1 javac 362 the patch passed
-0 checkstyle 40 hadoop-ozone: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 727 patch has no errors when building and testing our client artifacts.
-1 javadoc 124 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 findbugs 722 the patch passed
_ Other Tests _
+1 unit 355 hadoop-hdds in the patch passed.
-1 unit 2006 hadoop-ozone in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
8051
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.om.TestKeyManagerImpl
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 312c1a2195d3 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ce3c5a3
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/testReport/
Max. process+thread count 5412 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 46 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 577 trunk passed
+1 compile 365 trunk passed
+1 checkstyle 76 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 864 branch has no errors when building and testing our client artifacts.
+1 javadoc 163 trunk passed
0 spotbugs 422 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 611 trunk passed
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 591 the patch passed
+1 compile 391 the patch passed
+1 javac 391 the patch passed
-0 checkstyle 34 hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 686 patch has no errors when building and testing our client artifacts.
-1 javadoc 92 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
-1 findbugs 427 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 306 hadoop-hdds in the patch passed.
-1 unit 52 hadoop-ozone in the patch failed.
+1 asflicense 36 The patch does not generate ASF License warnings.
5870
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of null in org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getFromProtobuf(OzoneManagerProtocolProtos$KeyInfo) Dereferenced at OmKeyInfo.java:null in org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getFromProtobuf(OzoneManagerProtocolProtos$KeyInfo) Dereferenced at OmKeyInfo.java:[line 394]
Failed junit tests hadoop.ozone.om.helpers.TestOmKeyInfo
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ea8778af37e0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / fba222a
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/testReport/
Max. process+thread count 487 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao
Copy link
Contributor Author

/retest

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 46 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 595 trunk passed
+1 compile 371 trunk passed
+1 checkstyle 74 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 864 branch has no errors when building and testing our client artifacts.
+1 javadoc 165 trunk passed
0 spotbugs 420 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 616 trunk passed
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 553 the patch passed
+1 compile 382 the patch passed
+1 javac 382 the patch passed
-0 checkstyle 43 hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 681 patch has no errors when building and testing our client artifacts.
-1 javadoc 94 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
-1 findbugs 433 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 285 hadoop-hdds in the patch passed.
-1 unit 54 hadoop-ozone in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
5855
Reason Tests
FindBugs module:hadoop-ozone
Possible null pointer dereference of null in org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getFromProtobuf(OzoneManagerProtocolProtos$KeyInfo) Dereferenced at OmKeyInfo.java:null in org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getFromProtobuf(OzoneManagerProtocolProtos$KeyInfo) Dereferenced at OmKeyInfo.java:[line 394]
Failed junit tests hadoop.ozone.om.helpers.TestOmKeyInfo
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux fb697dc901b3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e69db45
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/testReport/
Max. process+thread count 557 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 47 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 586 trunk passed
+1 compile 371 trunk passed
+1 checkstyle 76 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 854 branch has no errors when building and testing our client artifacts.
+1 javadoc 163 trunk passed
0 spotbugs 420 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 608 trunk passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 536 the patch passed
+1 compile 344 the patch passed
+1 javac 344 the patch passed
+1 checkstyle 66 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 663 patch has no errors when building and testing our client artifacts.
-1 javadoc 84 hadoop-ozone generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 findbugs 666 the patch passed
_ Other Tests _
+1 unit 303 hadoop-hdds in the patch passed.
-1 unit 51 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
5692
Reason Tests
Failed junit tests hadoop.ozone.om.helpers.TestOmKeyInfo
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/6/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5e12fa305c5a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e69db45
Default Java 1.8.0_212
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/6/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/6/testReport/
Max. process+thread count 490 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 591 trunk passed
+1 compile 351 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 819 branch has no errors when building and testing our client artifacts.
+1 javadoc 148 trunk passed
0 spotbugs 430 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 625 trunk passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 547 the patch passed
+1 compile 351 the patch passed
+1 javac 351 the patch passed
+1 checkstyle 65 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 617 patch has no errors when building and testing our client artifacts.
+1 javadoc 155 the patch passed
+1 findbugs 638 the patch passed
_ Other Tests _
+1 unit 309 hadoop-hdds in the patch passed.
-1 unit 1837 hadoop-ozone in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
7367
Reason Tests
Failed junit tests hadoop.ozone.dn.scrubber.TestDataScrubber
hadoop.hdds.scm.pipeline.TestNode2PipelineMap
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
hadoop.ozone.web.TestOzoneWebAccess
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/8/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 49374ebf6f2e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1c5b286
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/8/testReport/
Max. process+thread count 3686 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 31 Maven dependency ordering for branch
+1 mvninstall 607 trunk passed
+1 compile 365 trunk passed
+1 checkstyle 63 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 824 branch has no errors when building and testing our client artifacts.
+1 javadoc 153 trunk passed
0 spotbugs 430 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 627 trunk passed
_ Patch Compile Tests _
0 mvndep 19 Maven dependency ordering for patch
+1 mvninstall 551 the patch passed
+1 compile 363 the patch passed
+1 javac 363 the patch passed
+1 checkstyle 64 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 625 patch has no errors when building and testing our client artifacts.
-1 javadoc 84 hadoop-ozone generated 3 new + 20 unchanged - 0 fixed = 23 total (was 20)
+1 findbugs 641 the patch passed
_ Other Tests _
+1 unit 305 hadoop-hdds in the patch passed.
-1 unit 2081 hadoop-ozone in the patch failed.
+1 asflicense 54 The patch does not generate ASF License warnings.
7725
Reason Tests
Failed junit tests hadoop.ozone.TestStorageContainerManager
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestBlockOutputStream
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/7/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 03d7420c6d75 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1c5b286
Default Java 1.8.0_212
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/7/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/7/testReport/
Max. process+thread count 4501 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao xiaoyuyao force-pushed the HDDS-1927 branch 2 times, most recently from 87cfbf7 to aef6038 Compare August 11, 2019 15:04
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 588 trunk passed
+1 compile 390 trunk passed
+1 checkstyle 59 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 815 branch has no errors when building and testing our client artifacts.
+1 javadoc 168 trunk passed
0 spotbugs 410 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 601 trunk passed
_ Patch Compile Tests _
0 mvndep 19 Maven dependency ordering for patch
+1 mvninstall 568 the patch passed
+1 compile 358 the patch passed
+1 javac 358 the patch passed
+1 checkstyle 63 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 631 patch has no errors when building and testing our client artifacts.
+1 javadoc 147 the patch passed
+1 findbugs 620 the patch passed
_ Other Tests _
+1 unit 289 hadoop-hdds in the patch passed.
-1 unit 2273 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
7866
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.hdds.scm.pipeline.TestNodeFailure
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.scm.node.TestQueryNode
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
hadoop.hdds.scm.pipeline.TestNode2PipelineMap
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/9/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 86dd0b03e939 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cf5d895
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/9/testReport/
Max. process+thread count 4968 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 566 trunk passed
+1 compile 344 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 808 branch has no errors when building and testing our client artifacts.
+1 javadoc 149 trunk passed
0 spotbugs 439 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 636 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 537 the patch passed
+1 compile 354 the patch passed
+1 javac 354 the patch passed
+1 checkstyle 72 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 616 patch has no errors when building and testing our client artifacts.
+1 javadoc 153 the patch passed
+1 findbugs 643 the patch passed
_ Other Tests _
+1 unit 285 hadoop-hdds in the patch passed.
-1 unit 2520 hadoop-ozone in the patch failed.
+1 asflicense 46 The patch does not generate ASF License warnings.
8029
Reason Tests
Failed junit tests hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestCommitWatcher
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux d45fbfaf9971 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cf5d895
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/testReport/
Max. process+thread count 4431 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/10/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer
Copy link
Contributor

I am +1 on these changes, and thanks for fixing the Findbugs issue. Can you please rebase and post a new patch. I will go ahead and commit it then. @bharatviswa504

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 26 Maven dependency ordering for branch
+1 mvninstall 646 trunk passed
+1 compile 384 trunk passed
+1 checkstyle 66 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 845 branch has no errors when building and testing our client artifacts.
+1 javadoc 178 trunk passed
0 spotbugs 461 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 676 trunk passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 541 the patch passed
+1 compile 357 the patch passed
+1 javac 357 the patch passed
+1 checkstyle 68 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 708 patch has no errors when building and testing our client artifacts.
+1 javadoc 152 the patch passed
+1 findbugs 630 the patch passed
_ Other Tests _
+1 unit 286 hadoop-hdds in the patch passed.
-1 unit 1902 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
7722
Reason Tests
Failed junit tests hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/11/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ac55c9f1a8c5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4f925af
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/11/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/11/testReport/
Max. process+thread count 5414 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/11/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 627 trunk passed
+1 compile 412 trunk passed
+1 checkstyle 80 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 933 branch has no errors when building and testing our client artifacts.
+1 javadoc 191 trunk passed
0 spotbugs 516 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 733 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 560 the patch passed
+1 compile 391 the patch passed
+1 javac 391 the patch passed
+1 checkstyle 73 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 724 patch has no errors when building and testing our client artifacts.
+1 javadoc 167 the patch passed
+1 findbugs 700 the patch passed
_ Other Tests _
+1 unit 344 hadoop-hdds in the patch passed.
-1 unit 1778 hadoop-ozone in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
7996
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/12/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 235e544c5180 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6244502
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/12/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/12/testReport/
Max. process+thread count 4457 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/12/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor Author

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments inline...

@xiaoyuyao
Copy link
Contributor Author

/retest

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 623 trunk passed
+1 compile 355 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 875 branch has no errors when building and testing our client artifacts.
+1 javadoc 149 trunk passed
0 spotbugs 424 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 615 trunk passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 541 the patch passed
+1 compile 351 the patch passed
+1 javac 351 the patch passed
+1 checkstyle 68 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 626 patch has no errors when building and testing our client artifacts.
+1 javadoc 145 the patch passed
+1 findbugs 622 the patch passed
_ Other Tests _
+1 unit 291 hadoop-hdds in the patch passed.
-1 unit 2153 hadoop-ozone in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
7767
Reason Tests
Failed junit tests hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestContainerStateMachineFailures
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.client.rpc.TestReadRetries
hadoop.ozone.om.TestOzoneManager
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/14/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a8aa7ab58f22 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 10b4997
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/14/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/14/testReport/
Max. process+thread count 4118 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/14/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 80 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 595 trunk passed
+1 compile 366 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 942 branch has no errors when building and testing our client artifacts.
+1 javadoc 166 trunk passed
0 spotbugs 477 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 683 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 608 the patch passed
+1 compile 425 the patch passed
+1 javac 425 the patch passed
+1 checkstyle 85 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 769 patch has no errors when building and testing our client artifacts.
+1 javadoc 179 the patch passed
+1 findbugs 704 the patch passed
_ Other Tests _
+1 unit 354 hadoop-hdds in the patch passed.
-1 unit 2471 hadoop-ozone in the patch failed.
+1 asflicense 60 The patch does not generate ASF License warnings.
8789
Reason Tests
Failed junit tests hadoop.ozone.scm.node.TestQueryNode
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/13/artifact/out/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4da7e5903e79 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 10b4997
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/13/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/13/testReport/
Max. process+thread count 4816 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1263/13/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor

+1. Once can you verify test results?
For acceptance, it is opening in GitHub, so not able to verify the results. IT failures mostly looks unrelated.

@anuengineer
Copy link
Contributor

+1, I have verified the test failures and at a high level does not seem to be related to this patch. I am going to commit this patch now. We can follow up with other JIRAs if needed to fix the test issues if we discover they are indeed related to this.
@xiaoyuyao @bharatviswa504

@anuengineer
Copy link
Contributor

Committed to trunk. Thanks for the reviews and Contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants