-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1810. SCM command to Activate and Deactivate pipelines. #1224
Conversation
💔 -1 overall
This message was automatically generated. |
Will deactive trigger close containers on the pipeline? what is the difference between close and recreate? |
No, we will not close the containers. We will not do anything to the pipeline other than moving it out of allocation path.
Activate and de-activate is used mainly for debugging purpose, we don't want to create a new pipeline here. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
3caf526
to
41fa9f8
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Thanks @nandakumar131 for working on this. The changes look good to me and the feature is good too have for debugging purpose. I am +1 on the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 after fixing the small typo.
RpcController controller, DeactivatePipelineRequestProto request) | ||
throws ServiceException { | ||
try (Scope ignored = TracingUtil | ||
.importAndCreateScope("activatePipeline", request.getTraceID())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.importAndCreateScope("activatePipeline", request.getTraceID())) { | |
.importAndCreateScope("deactivatePipeline", request.getTraceID())) { |
💔 -1 overall
This message was automatically generated. |
Thanks @elek for the review, I will fix the typo while committing. |
It will be useful to have scm command to temporarily deactivate and re-activate a pipeline. This will help us a lot in debugging a pipeline.