HDDS-1788. Fix kerberos principal error in Ozone Recon #1201
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
@swagle @avijayanhwx @anuengineer Please review when you find time. Thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
I am not sure I understand the patch well enough. @xiaoyuyao @arp7 @elek can you guys please take a look ? |
There was a problem hiding this comment.
I think some time back we debugged this issue and see that configuration object in recon http server is not having correct configuration values. But one question I have is previously also there is a provider for OzoneConfiguration, and now we have changed it to Configuration. How this is solving that issue by changing to Configuration I have not got that part, care to explain.
|
Hi @bharatviswa504, OzoneConfigurationProvider is changed to ConfigurationProvider in this patch to have the correct I understand that its not very clear because this class is not part of this PR. The issue was that injection was not working in ReconHttpServer - https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/ReconHttpServer.java#L34 because of the use of Configuration object. Now, with refactoring Please let me know if you have any more questions. |
|
💔 -1 overall
This message was automatically generated. |
|
The unit test, integration test and checkstyle failures are not related to this patch. |
|
Thank You @vivekratnavel for the fix and the explanation. I think, we need to fix the title for this jira, as this is not adding Kerberos support to Ozone. It is fixing ConfigurationProvider, so that injection works. And fixing this will fix ReconServer start. As this will fix passing correct configuration to ReconHttpServer. So, this means it fix Kerberos/Non-Kerberos and picking correct configuration in ReconHttpServer. Can you change the title accordingly, and update the Jira. It will be helpful for future reference. |
bharatviswa504
approved these changes
Aug 2, 2019
vivekratnavel
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
Thank You @vivekratnavel for the contribution. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recon fails to come up in a secure cluster with the following error:
This patch addresses this issue and enables Recon to come up in clusters secured by kerberos. I have manually tested the patch by creating the recon jar and replacing an old jar in a live secure CM deployed cluster and verified that Recon starts successfully and is able to login successfully with the kerberos ticket. Also updated ozonesecure docker-compose file to add recon and verified that recon is able to come up successfully. This patch also fixes various typos found in other parts of the source code not related to the title of this JIRA.