Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-1832 : Improve logging for PipelineActions handling in SCM and datanode. #1200

Merged
merged 1 commit into from
Aug 2, 2019
Merged

HDDS-1832 : Improve logging for PipelineActions handling in SCM and datanode. #1200

merged 1 commit into from
Aug 2, 2019

Conversation

avijayanhwx
Copy link
Contributor

Added logging.

@vivekratnavel
Copy link
Contributor

+1 LGTM (non-binding).

@vivekratnavel
Copy link
Contributor

/label ozone

@elek elek added the ozone label Aug 1, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 107 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 633 trunk passed
+1 compile 399 trunk passed
+1 checkstyle 77 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1031 branch has no errors when building and testing our client artifacts.
+1 javadoc 166 trunk passed
0 spotbugs 433 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 631 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 559 the patch passed
+1 compile 374 the patch passed
+1 javac 374 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 736 patch has no errors when building and testing our client artifacts.
+1 javadoc 186 the patch passed
+1 findbugs 719 the patch passed
_ Other Tests _
-1 unit 362 hadoop-hdds in the patch failed.
-1 unit 1965 hadoop-ozone in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
8262
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.pipeline.TestPipelineClose
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/1/artifact/out/Dockerfile
GITHUB PR #1200
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 52369254f8ef 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b008072
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/1/testReport/
Max. process+thread count 3922 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 11 Maven dependency ordering for branch
+1 mvninstall 628 trunk passed
+1 compile 370 trunk passed
+1 checkstyle 70 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 968 branch has no errors when building and testing our client artifacts.
+1 javadoc 171 trunk passed
0 spotbugs 480 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 692 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 572 the patch passed
+1 compile 379 the patch passed
+1 javac 379 the patch passed
+1 checkstyle 79 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 751 patch has no errors when building and testing our client artifacts.
+1 javadoc 182 the patch passed
+1 findbugs 692 the patch passed
_ Other Tests _
-1 unit 345 hadoop-hdds in the patch failed.
-1 unit 2127 hadoop-ozone in the patch failed.
+1 asflicense 56 The patch does not generate ASF License warnings.
8337
Reason Tests
Failed junit tests hadoop.hdds.scm.block.TestBlockManager
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.om.TestScmSafeMode
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/2/artifact/out/Dockerfile
GITHUB PR #1200
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 14a028e78af8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / f86de6f
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/2/testReport/
Max. process+thread count 5317 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1200/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bshashikant
Copy link
Contributor

Thanks @avijayanhwx for working on this. The change looks good to me. +1

@bshashikant bshashikant merged commit 6e8c841 into apache:trunk Aug 2, 2019
avijayanhwx added a commit to avijayanhwx/hadoop that referenced this pull request Aug 2, 2019
@avijayanhwx
Revert "HDDS-1832 : Improve logging for PipelineActions handling in S…
6e8abf1 
…CM and datanode. (apache#1200)"

This reverts commit 6e8c841.
@avijayanhwx avijayanhwx mentioned this pull request Aug 2, 2019
Closed
mukul1987
mukul1987 reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @avijayanhwx . Lets log these as errors as these would happen on errors.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
@avijayanhwx
HDDS-1832 : Improve logging for PipelineActions handling in SCM and d…
a94d7e2 
…atanode. (apache#1200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukul1987 mukul1987 mukul1987 left review comments

Assignees
No one assigned
Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@avijayanhwx @vivekratnavel @hadoop-yetus @bshashikant @mukul1987 @elek