HDDS-1882. TestReplicationManager failed with NPE in ReplicationManager

[ChenSammi]

https://issues.apache.org/jira/browse/HDDS-1882

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	139	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	741	trunk passed
+1	compile	439	trunk passed
+1	checkstyle	97	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1154	branch has no errors when building and testing our client artifacts.
+1	javadoc	231	trunk passed
0	spotbugs	535	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	793	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	720	the patch passed
+1	compile	378	the patch passed
+1	javac	378	the patch passed
+1	checkstyle	75	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	727	patch has no errors when building and testing our client artifacts.
+1	javadoc	163	the patch passed
+1	findbugs	647	the patch passed
		_ Other Tests _
+1	unit	344	hadoop-hdds in the patch passed.
-1	unit	2102	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		8962

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.om.TestOzoneManagerHA

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/1/artifact/out/Dockerfile
GITHUB PR	#1197
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 33b7746af7df 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d4ab9ae
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/1/testReport/
Max. process+thread count	4454 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	598	trunk passed
+1	compile	363	trunk passed
+1	checkstyle	67	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	820	branch has no errors when building and testing our client artifacts.
+1	javadoc	156	trunk passed
0	spotbugs	439	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	643	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	553	the patch passed
+1	compile	367	the patch passed
+1	javac	367	the patch passed
+1	checkstyle	68	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	618	patch has no errors when building and testing our client artifacts.
+1	javadoc	155	the patch passed
+1	findbugs	671	the patch passed
		_ Other Tests _
+1	unit	283	hadoop-hdds in the patch passed.
-1	unit	1600	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7197

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.om.TestOzoneManagerHA

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/2/artifact/out/Dockerfile
GITHUB PR	#1197
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 22bfc1a696da 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / a7371a7
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/2/testReport/
Max. process+thread count	5327 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1197/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[nandakumar131]

+1, LGTM

[ChenSammi]

Thanks @nandakumar131 for review the patch.