HDDS-1878. checkstyle error in ContainerStateMachine

[adoroszlai]

What changes were proposed in this pull request?

Fix checkstyle error due to too long line.

Unfortunately at 71 characters DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS_DEFAULT is too long for the 80-char limit even with static imports, so it has to be shortened. I figured that RATIS would be the least useful part, implied by STATEMACHINE, so I removed that.

https://issues.apache.org/jira/browse/HDDS-1878

How was this patch tested?

$ mvn -Phdds -DskipTests -am -pl :hadoop-hdds-container-service clean package
$ ./hadoop-ozone/dev-support/checks/checkstyle.sh

[adoroszlai]

/label ozone

[adoroszlai]

@lokeshj1703 please review

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	66	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	624	trunk passed
+1	compile	372	trunk passed
+1	checkstyle	69	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	878	branch has no errors when building and testing our client artifacts.
+1	javadoc	162	trunk passed
0	spotbugs	429	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	626	trunk passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	560	the patch passed
+1	compile	367	the patch passed
+1	javac	367	the patch passed
+1	checkstyle	36	hadoop-hdds: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1	checkstyle	41	The patch passed checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	669	patch has no errors when building and testing our client artifacts.
+1	javadoc	158	the patch passed
+1	findbugs	637	the patch passed
		_ Other Tests _
-1	unit	401	hadoop-hdds in the patch failed.
-1	unit	2039	hadoop-ozone in the patch failed.
+1	asflicense	52	The patch does not generate ASF License warnings.
		7949

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/1/artifact/out/Dockerfile
GITHUB PR	#1195
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cde7178a0bc8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d4ab9ae
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/1/testReport/
Max. process+thread count	4160 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[lokeshj1703]

@adoroszlai Thanks for working on this! The patch looks good to me. The "RATIS" keyword in the config is very useful to find all ratis related configs in the ScmConfigKeys file. Can we rather replace TRANSACTIONS to TXNS if it sounds ok to you?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	75	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	16	Maven dependency ordering for branch
+1	mvninstall	587	trunk passed
+1	compile	367	trunk passed
+1	checkstyle	71	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	931	branch has no errors when building and testing our client artifacts.
+1	javadoc	164	trunk passed
0	spotbugs	433	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	628	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	554	the patch passed
+1	compile	371	the patch passed
+1	javac	371	the patch passed
+1	checkstyle	36	hadoop-hdds: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1	checkstyle	39	The patch passed checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	715	patch has no errors when building and testing our client artifacts.
+1	javadoc	163	the patch passed
+1	findbugs	648	the patch passed
		_ Other Tests _
-1	unit	348	hadoop-hdds in the patch failed.
-1	unit	1931	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7872

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/2/artifact/out/Dockerfile
GITHUB PR	#1195
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2948a352e3c7 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / a6f47b5
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/2/testReport/
Max. process+thread count	4476 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[adoroszlai]

Can we rather replace TRANSACTIONS to TXNS if it sounds ok to you?

@lokeshj1703 sure, using a common abbreviation is fine. Can you please take a look at the updated patch? Thanks.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	154	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	36	Maven dependency ordering for branch
+1	mvninstall	812	trunk passed
+1	compile	442	trunk passed
+1	checkstyle	95	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1138	branch has no errors when building and testing our client artifacts.
+1	javadoc	233	trunk passed
0	spotbugs	547	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	824	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	586	the patch passed
+1	compile	402	the patch passed
+1	javac	402	the patch passed
+1	checkstyle	34	hadoop-hdds: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1	checkstyle	38	The patch passed checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	760	patch has no errors when building and testing our client artifacts.
-1	javadoc	73	hadoop-hdds generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)
+1	findbugs	687	the patch passed
		_ Other Tests _
+1	unit	355	hadoop-hdds in the patch passed.
-1	unit	260	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		7237

Reason	Tests
Failed junit tests	hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/3/artifact/out/Dockerfile
GITHUB PR	#1195
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d780ed664168 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f86de6f
Default Java	1.8.0_212
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/3/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/3/testReport/
Max. process+thread count	423 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[lokeshj1703]

@adoroszlai Thanks for updating the PR! The patch looks good to me. There are a few javadoc errors. +1 o.w.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	66	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	678	trunk passed
+1	compile	380	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	846	branch has no errors when building and testing our client artifacts.
+1	javadoc	157	trunk passed
0	spotbugs	459	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	673	trunk passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	579	the patch passed
+1	compile	395	the patch passed
+1	javac	395	the patch passed
+1	checkstyle	32	hadoop-hdds: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1	checkstyle	37	The patch passed checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	678	patch has no errors when building and testing our client artifacts.
+1	javadoc	156	the patch passed
+1	findbugs	697	the patch passed
		_ Other Tests _
-1	unit	365	hadoop-hdds in the patch failed.
-1	unit	3391	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		9456

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.ozShell.TestOzoneShell

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/4/artifact/out/Dockerfile
GITHUB PR	#1195
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8f631005b725 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 95fc38f
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/4/testReport/
Max. process+thread count	3869 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1195/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[adoroszlai]

Thanks @bshashikant for merging the fix.