HDDS-1619. Support volume acl operations for OM HA. Contributed by…

[xiaoyuyao]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	515	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	636	trunk passed
+1	compile	375	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	845	branch has no errors when building and testing our client artifacts.
+1	javadoc	171	trunk passed
0	spotbugs	450	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	665	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	581	the patch passed
+1	compile	395	the patch passed
+1	javac	395	the patch passed
+1	checkstyle	70	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	650	patch has no errors when building and testing our client artifacts.
+1	javadoc	155	the patch passed
+1	findbugs	702	the patch passed
		_ Other Tests _
+1	unit	288	hadoop-hdds in the patch passed.
-1	unit	1342	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7647

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.om.snapshot.TestOzoneManagerSnapshotProvider
	hadoop.ozone.om.TestOmMetrics
	hadoop.ozone.om.TestOzoneManagerRestInterface

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/1/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 3f3d3e25ea16 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ecb9f81
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/1/testReport/
Max. process+thread count	2333 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bharatviswa504]

I have a few comments.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	522	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	660	trunk passed
+1	compile	406	trunk passed
+1	checkstyle	66	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	848	branch has no errors when building and testing our client artifacts.
+1	javadoc	155	trunk passed
0	spotbugs	461	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	682	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	575	the patch passed
+1	compile	380	the patch passed
+1	javac	380	the patch passed
-0	checkstyle	35	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	680	patch has no errors when building and testing our client artifacts.
+1	javadoc	158	the patch passed
+1	findbugs	679	the patch passed
		_ Other Tests _
-1	unit	293	hadoop-hdds in the patch failed.
-1	unit	1821	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		8196

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux adb770c5f444 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 68f9f2d
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/testReport/
Max. process+thread count	4495 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	126	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	775	trunk passed
+1	compile	418	trunk passed
+1	checkstyle	86	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	928	branch has no errors when building and testing our client artifacts.
+1	javadoc	169	trunk passed
0	spotbugs	441	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	643	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	573	the patch passed
+1	compile	366	the patch passed
+1	javac	366	the patch passed
-0	checkstyle	38	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	803	patch has no errors when building and testing our client artifacts.
+1	javadoc	203	the patch passed
+1	findbugs	770	the patch passed
		_ Other Tests _
-1	unit	386	hadoop-hdds in the patch failed.
-1	unit	2017	hadoop-ozone in the patch failed.
+1	asflicense	56	The patch does not generate ASF License warnings.
		8571

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2c8c0b8a3040 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 68f9f2d
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/testReport/
Max. process+thread count	4125 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	609	trunk passed
+1	compile	351	trunk passed
+1	checkstyle	63	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	799	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	418	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	614	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	535	the patch passed
+1	compile	353	the patch passed
+1	javac	353	the patch passed
+1	checkstyle	69	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	646	patch has no errors when building and testing our client artifacts.
+1	javadoc	161	the patch passed
+1	findbugs	677	the patch passed
		_ Other Tests _
-1	unit	286	hadoop-hdds in the patch failed.
-1	unit	2603	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		8165

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/4/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ae40e9d71f97 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 7849bdc
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/4/testReport/
Max. process+thread count	3852 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bharatviswa504]

To handle Non-HA also with new HA code, we have done some changes in HDDS-1856. So, this Jira needs a few more changes like adding to double-buffer and setFlushFuture in validateAndUpdateCache.

[xiaoyuyao]

bq. To handle Non-HA also with new HA code, we have done some changes in HDDS-1856. So, this Jira needs a few more changes like adding to double-buffer and setFlushFuture in validateAndUpdateCache.

Thanks for the heads up, @bharatviswa504 . I've rebase the change and also added removeAcl and setAcl for volume.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	630	trunk passed
+1	compile	377	trunk passed
+1	checkstyle	70	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	856	branch has no errors when building and testing our client artifacts.
+1	javadoc	157	trunk passed
0	spotbugs	460	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	672	trunk passed
-0	patch	491	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	585	the patch passed
+1	compile	378	the patch passed
+1	javac	378	the patch passed
-0	checkstyle	37	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	642	patch has no errors when building and testing our client artifacts.
+1	javadoc	153	the patch passed
+1	findbugs	631	the patch passed
		_ Other Tests _
-1	unit	289	hadoop-hdds in the patch failed.
-1	unit	1582	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7338

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 427416941c56 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b008072
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/testReport/
Max. process+thread count	5180 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	151	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	829	trunk passed
+1	compile	497	trunk passed
+1	checkstyle	92	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1038	branch has no errors when building and testing our client artifacts.
+1	javadoc	167	trunk passed
0	spotbugs	433	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	631	trunk passed
-0	patch	475	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	555	the patch passed
+1	compile	375	the patch passed
+1	javac	375	the patch passed
-0	checkstyle	40	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	728	patch has no errors when building and testing our client artifacts.
+1	javadoc	167	the patch passed
+1	findbugs	650	the patch passed
		_ Other Tests _
-1	unit	330	hadoop-hdds in the patch failed.
-1	unit	2710	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		9205

Reason	Tests
Failed junit tests	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 191ee7e7469d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b008072
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/testReport/
Max. process+thread count	5401 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	138	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	769	trunk passed
+1	compile	436	trunk passed
+1	checkstyle	92	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1109	branch has no errors when building and testing our client artifacts.
+1	javadoc	217	trunk passed
0	spotbugs	528	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	776	trunk passed
-0	patch	582	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	732	the patch passed
+1	compile	433	the patch passed
+1	javac	433	the patch passed
-0	checkstyle	53	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	854	patch has no errors when building and testing our client artifacts.
+1	javadoc	201	the patch passed
+1	findbugs	734	the patch passed
		_ Other Tests _
-1	unit	381	hadoop-hdds in the patch failed.
-1	unit	2544	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		9750

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.TestContainerStateMachineIdempotency
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux dc459edc1d0b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b008072
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/testReport/
Max. process+thread count	3941 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	164	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	717	trunk passed
+1	compile	410	trunk passed
+1	checkstyle	92	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	975	branch has no errors when building and testing our client artifacts.
+1	javadoc	158	trunk passed
0	spotbugs	441	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	636	trunk passed
-0	patch	481	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	560	the patch passed
+1	compile	417	the patch passed
+1	javac	417	the patch passed
-0	checkstyle	39	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	717	patch has no errors when building and testing our client artifacts.
+1	javadoc	162	the patch passed
+1	findbugs	666	the patch passed
		_ Other Tests _
-1	unit	350	hadoop-hdds in the patch failed.
-1	unit	1883	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		8180

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e1345a14a265 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b008072
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/testReport/
Max. process+thread count	4027 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	582	trunk passed
+1	compile	360	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	805	branch has no errors when building and testing our client artifacts.
+1	javadoc	148	trunk passed
0	spotbugs	419	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	606	trunk passed
-0	patch	456	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	565	the patch passed
+1	compile	367	the patch passed
+1	javac	367	the patch passed
+1	checkstyle	74	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	657	patch has no errors when building and testing our client artifacts.
+1	javadoc	156	the patch passed
+1	findbugs	691	the patch passed
		_ Other Tests _
+1	unit	290	hadoop-hdds in the patch passed.
-1	unit	2975	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		8582

Reason	Tests
Failed junit tests	hadoop.hdds.scm.pipeline.TestNodeFailure
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/16/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 21d94a3cc585 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 22430c1
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/16/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/16/testReport/
Max. process+thread count	4167 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/16/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bharatviswa504]

@xiaoyuyao
One comment which is missing in the PR is
We should set success with operationResult flag, because onInit() sets it to true by default.
With this, this flag will be checked as one of the condition in OMVolumeAclResponse, and do the DB Batch.

[bharatviswa504]

+1 LGTM. Pending CI.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	106	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	746	trunk passed
+1	compile	454	trunk passed
+1	checkstyle	94	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1069	branch has no errors when building and testing our client artifacts.
+1	javadoc	198	trunk passed
0	spotbugs	547	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	806	trunk passed
-0	patch	590	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	676	the patch passed
+1	compile	431	the patch passed
+1	javac	431	the patch passed
-0	checkstyle	50	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	752	patch has no errors when building and testing our client artifacts.
+1	javadoc	187	the patch passed
+1	findbugs	786	the patch passed
		_ Other Tests _
+1	unit	403	hadoop-hdds in the patch passed.
-1	unit	2445	hadoop-ozone in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		9440

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.om.TestScmSafeMode

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/17/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 3816b0f834b7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 11f750e
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/17/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/17/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/17/testReport/
Max. process+thread count	5065 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/17/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	572	trunk passed
+1	compile	347	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	831	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	444	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	650	trunk passed
-0	patch	481	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	567	the patch passed
+1	compile	372	the patch passed
+1	javac	372	the patch passed
-0	checkstyle	36	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	621	patch has no errors when building and testing our client artifacts.
+1	javadoc	166	the patch passed
+1	findbugs	656	the patch passed
		_ Other Tests _
+1	unit	307	hadoop-hdds in the patch passed.
-1	unit	1989	hadoop-ozone in the patch failed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		7607

Reason	Tests
Failed junit tests	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/18/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2e8fae687387 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 3cc0ace
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/18/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/18/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/18/testReport/
Max. process+thread count	4507 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/18/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	600	trunk passed
+1	compile	376	trunk passed
+1	checkstyle	77	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	930	branch has no errors when building and testing our client artifacts.
+1	javadoc	179	trunk passed
0	spotbugs	442	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	646	trunk passed
-0	patch	481	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	557	the patch passed
+1	compile	379	the patch passed
+1	javac	379	the patch passed
+1	checkstyle	71	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	764	patch has no errors when building and testing our client artifacts.
+1	javadoc	164	the patch passed
+1	findbugs	688	the patch passed
		_ Other Tests _
+1	unit	332	hadoop-hdds in the patch passed.
-1	unit	1734	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		7733

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.om.TestKeyManagerImpl
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/21/artifact/out/Dockerfile
GITHUB PR	#1147
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 64248867938f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 397a563
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/21/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/21/testReport/
Max. process+thread count	4798 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1147/21/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[xiaoyuyao]

Thanks @bharatviswa504 for the review and discussions. I've merged the PR to trunk.