SUBMARINE-72 Kill and destroy the job through the submarine client #1090

pingsutw · 2019-07-14T07:00:26Z

No description provided.

hadoop-yetus · 2019-07-19T11:38:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1481	trunk passed
+1	compile	39	trunk passed
+1	checkstyle	27	trunk passed
+1	mvnsite	40	trunk passed
+1	shadedclient	968	branch has no errors when building and testing our client artifacts.
+1	javadoc	28	trunk passed
0	spotbugs	61	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	56	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	35	the patch passed
+1	compile	29	the patch passed
+1	javac	29	the patch passed
-0	checkstyle	17	hadoop-submarine/hadoop-submarine-core: The patch generated 8 new + 13 unchanged - 0 fixed = 21 total (was 13)
+1	mvnsite	30	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	995	patch has no errors when building and testing our client artifacts.
+1	javadoc	26	the patch passed
-1	findbugs	61	hadoop-submarine/hadoop-submarine-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	55	hadoop-submarine-core in the patch passed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		4110

Reason	Tests
FindBugs	module:hadoop-submarine/hadoop-submarine-core
	The method name org.apache.hadoop.yarn.submarine.client.cli.KillJobCli.KillJob() doesn't start with a lower case letter At KillJobCli.java:start with a lower case letter At KillJobCli.java:[lines 76-87]

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/1/artifact/out/Dockerfile
GITHUB PR	#1090
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f527ceed0e18 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4e66cb9`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/1/artifact/out/diff-checkstyle-hadoop-submarine_hadoop-submarine-core.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/1/artifact/out/new-findbugs-hadoop-submarine_hadoop-submarine-core.html
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/1/testReport/
Max. process+thread count	308 (vs. ulimit of 5500)
modules	C: hadoop-submarine/hadoop-submarine-core U: hadoop-submarine/hadoop-submarine-core
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-26T13:12:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	59	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1120	trunk passed
+1	compile	40	trunk passed
+1	checkstyle	19	trunk passed
+1	mvnsite	29	trunk passed
+1	shadedclient	692	branch has no errors when building and testing our client artifacts.
+1	javadoc	19	trunk passed
0	spotbugs	40	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	37	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	23	the patch passed
+1	compile	18	the patch passed
+1	javac	18	the patch passed
-0	checkstyle	12	hadoop-submarine/hadoop-submarine-core: The patch generated 8 new + 13 unchanged - 0 fixed = 21 total (was 13)
+1	mvnsite	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	693	patch has no errors when building and testing our client artifacts.
+1	javadoc	19	the patch passed
-1	findbugs	42	hadoop-submarine/hadoop-submarine-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	43	hadoop-submarine-core in the patch passed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		2997

Reason	Tests
FindBugs	module:hadoop-submarine/hadoop-submarine-core
	The method name org.apache.hadoop.yarn.submarine.client.cli.KillJobCli.KillJob() doesn't start with a lower case letter At KillJobCli.java:start with a lower case letter At KillJobCli.java:[lines 76-87]

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/2/artifact/out/Dockerfile
GITHUB PR	#1090
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4bec03bbdaa8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c0a0c35
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/2/artifact/out/diff-checkstyle-hadoop-submarine_hadoop-submarine-core.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/2/artifact/out/new-findbugs-hadoop-submarine_hadoop-submarine-core.html
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/2/testReport/
Max. process+thread count	447 (vs. ulimit of 5500)
modules	C: hadoop-submarine/hadoop-submarine-core U: hadoop-submarine/hadoop-submarine-core
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

...oop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/KillJobCli.java

jojochuang · 2019-07-30T17:17:21Z

...oop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/KillJobCli.java

+
+    if (appAdminClient.actionStop(jobName) != 0
+        || appAdminClient.actionDestroy(jobName) != 0) {
+      LOG.error("Fail to kill job !");


It is generally preferred to log additional information, in order to help troubleshoot why the job doesn't get killed.

Additional info meaning: whether the job fails to be killed because it was unable to stop the job or because it was unable to destroy the job.

pingsutw · 2019-07-31T18:35:15Z

Update the patch

KIlljob() -> killjob(), because the function should start with a lower case letter
LOG before print usage
print additional information if appAdminClient stop or destroy job error

hadoop-yetus · 2019-08-02T01:04:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1102	trunk passed
+1	compile	23	trunk passed
+1	checkstyle	14	trunk passed
+1	mvnsite	26	trunk passed
+1	shadedclient	662	branch has no errors when building and testing our client artifacts.
+1	javadoc	19	trunk passed
0	spotbugs	40	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	37	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	29	the patch passed
+1	compile	20	the patch passed
+1	javac	20	the patch passed
-0	checkstyle	11	hadoop-submarine/hadoop-submarine-core: The patch generated 8 new + 13 unchanged - 0 fixed = 21 total (was 13)
+1	mvnsite	20	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	704	patch has no errors when building and testing our client artifacts.
+1	javadoc	18	the patch passed
+1	findbugs	44	the patch passed
		_ Other Tests _
+1	unit	41	hadoop-submarine-core in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		2927

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/3/artifact/out/Dockerfile
GITHUB PR	#1090
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 788d0d9c59be 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `17e8cf5`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/3/artifact/out/diff-checkstyle-hadoop-submarine_hadoop-submarine-core.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/3/testReport/
Max. process+thread count	446 (vs. ulimit of 5500)
modules	C: hadoop-submarine/hadoop-submarine-core U: hadoop-submarine/hadoop-submarine-core
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T03:06:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1181	trunk passed
+1	compile	26	trunk passed
+1	checkstyle	21	trunk passed
+1	mvnsite	31	trunk passed
+1	shadedclient	722	branch has no errors when building and testing our client artifacts.
+1	javadoc	21	trunk passed
0	spotbugs	38	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	36	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	22	the patch passed
+1	compile	21	the patch passed
+1	javac	21	the patch passed
-0	checkstyle	12	hadoop-submarine/hadoop-submarine-core: The patch generated 7 new + 13 unchanged - 0 fixed = 20 total (was 13)
+1	mvnsite	23	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	689	patch has no errors when building and testing our client artifacts.
+1	javadoc	15	the patch passed
+1	findbugs	42	the patch passed
		_ Other Tests _
+1	unit	48	hadoop-submarine-core in the patch passed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		3058

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/4/artifact/out/Dockerfile
GITHUB PR	#1090
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 52b7ac7aacf8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `70b4617`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/4/artifact/out/diff-checkstyle-hadoop-submarine_hadoop-submarine-core.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/4/testReport/
Max. process+thread count	447 (vs. ulimit of 5500)
modules	C: hadoop-submarine/hadoop-submarine-core U: hadoop-submarine/hadoop-submarine-core
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

jojochuang · 2019-08-08T03:53:46Z

LGTM +1

pingsutw · 2019-08-08T04:12:30Z

@jojochuang Thanks, I'm going to rebase to hadoopsubmarine/submarine

hadoop-yetus · 2019-08-08T10:24:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#1090 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1090
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1090/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@shanthoosh

…pache#1090) * SAMZA-2260: Standalone and coordinator metadata store lifecycle * Trigger build again * Address PR comments from @shanthoosh

…pache#1090) Contributed by kevin su.

jojochuang reviewed Jul 30, 2019

View reviewed changes

pingsutw force-pushed the SUBMARINE-72 branch from f215c18 to eda2ac7 Compare July 31, 2019 10:34

pingsutw added 2 commits August 1, 2019 00:50

SUBMARINE-72 Kill and destroy the job through the submarine client

5f8ac9d

Add more information in log

1d34b59

pingsutw force-pushed the SUBMARINE-72 branch from eda2ac7 to 1d34b59 Compare July 31, 2019 18:26

fix typo in testKillJob

9a0f044

jojochuang merged commit 00b5a27 into apache:trunk Aug 8, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

SUBMARINE-72. Kill and destroy the job through the submarine client (a…

0373615

…pache#1090) Contributed by kevin su.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SUBMARINE-72 Kill and destroy the job through the submarine client #1090

SUBMARINE-72 Kill and destroy the job through the submarine client #1090

Uh oh!

pingsutw commented Jul 14, 2019

Uh oh!

hadoop-yetus commented Jul 19, 2019

Uh oh!

hadoop-yetus commented Jul 26, 2019

Uh oh!

Uh oh!

jojochuang Jul 30, 2019

Uh oh!

jojochuang Jul 30, 2019

Uh oh!

pingsutw commented Jul 31, 2019 •

edited

Loading

Uh oh!

hadoop-yetus commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

jojochuang commented Aug 8, 2019

Uh oh!

pingsutw commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

Uh oh!

SUBMARINE-72 Kill and destroy the job through the submarine client #1090

SUBMARINE-72 Kill and destroy the job through the submarine client #1090

Uh oh!

Conversation

pingsutw commented Jul 14, 2019

Uh oh!

hadoop-yetus commented Jul 19, 2019

Uh oh!

hadoop-yetus commented Jul 26, 2019

Uh oh!

Uh oh!

jojochuang Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

jojochuang Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

pingsutw commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

jojochuang commented Aug 8, 2019

Uh oh!

pingsutw commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

Uh oh!

pingsutw commented Jul 31, 2019 •

edited

Loading