HDDS-1779. TestWatchForCommit tests are flaky. #1071

bshashikant · 2019-07-10T12:24:00Z

No description provided.

supratimdeka

+1
I have not reviewed the new file. As it is just code movement per our discussion.
Approving, pl consider the change I have suggested and remove the debug println.

...ne/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestWatchForCommit.java

supratimdeka · 2019-07-12T04:55:39Z

...ne/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestWatchForCommit.java

+      // as well as there is no logIndex generate in Ratis.
+      // The basic idea here is just to test if its throws an exception.
+      xceiverClient
+          .watchForCommit(index + new Random().nextInt(100) + 10, 20000);


instead of a Random increment, why not increment by a fixed number everytime - say 100 or 110? This applies to all the other modified test cases as well.

The idea here is to run the test each time with unique number so any possible hacks/errors get caught if any.

hadoop-yetus · 2019-07-12T19:07:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	57	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	473	trunk passed
+1	compile	269	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	864	branch has no errors when building and testing our client artifacts.
+1	javadoc	163	trunk passed
0	spotbugs	316	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	505	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	450	the patch passed
+1	compile	268	the patch passed
+1	javac	268	the patch passed
-0	checkstyle	42	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	682	patch has no errors when building and testing our client artifacts.
+1	javadoc	162	the patch passed
+1	findbugs	520	the patch passed
		_ Other Tests _
+1	unit	338	hadoop-hdds in the patch passed.
-1	unit	2469	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7595

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/Dockerfile
GITHUB PR	#1071
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d6815f71900a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4a70a0d`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/testReport/
Max. process+thread count	5231 (vs. ulimit of 5500)
modules	C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

supratimdeka

+1

…well as ceckstyle issues.

hadoop-yetus · 2019-07-16T13:53:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	95	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	537	trunk passed
+1	compile	265	trunk passed
+1	checkstyle	78	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1049	branch has no errors when building and testing our client artifacts.
+1	javadoc	194	trunk passed
0	spotbugs	338	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	547	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	495	the patch passed
+1	compile	285	the patch passed
+1	javac	285	the patch passed
-0	checkstyle	45	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	781	patch has no errors when building and testing our client artifacts.
+1	javadoc	277	the patch passed
+1	findbugs	589	the patch passed
		_ Other Tests _
+1	unit	336	hadoop-hdds in the patch passed.
-1	unit	2192	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		8010

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.ozone.web.TestOzoneVolumes
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.dn.scrubber.TestDataScrubber
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.client.rpc.TestKeyInputStream
	hadoop.ozone.client.rpc.TestContainerStateMachine

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/Dockerfile
GITHUB PR	#1071
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e3a0d0644ba4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 1502e6a
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/testReport/
Max. process+thread count	5245 (vs. ulimit of 5500)
modules	C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-18T06:50:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	485	trunk passed
+1	compile	266	trunk passed
+1	checkstyle	70	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	807	branch has no errors when building and testing our client artifacts.
+1	javadoc	163	trunk passed
0	spotbugs	317	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	510	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	437	the patch passed
+1	compile	258	the patch passed
+1	javac	258	the patch passed
+1	checkstyle	80	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	685	patch has no errors when building and testing our client artifacts.
+1	javadoc	163	the patch passed
+1	findbugs	526	the patch passed
		_ Other Tests _
-1	unit	300	hadoop-hdds in the patch failed.
-1	unit	1690	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		6705

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/Dockerfile
GITHUB PR	#1071
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux eb6c64493a2f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3dc256e`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/testReport/
Max. process+thread count	5340 (vs. ulimit of 5500)
modules	C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

mukul1987

+1, looks good to me.

bshashikant · 2019-07-18T14:28:17Z

Thanks @mukul1987 and @supratimdeka for the review. I have committed the change to trunk.

…nt Banerjee. (#1071)

* Using jsonserde to write metadata file * Getting rid of public static class

…nt Banerjee. (apache#1071)

HDDS-1779. TestWatchForCommit tests are flaky.

68f9369

bshashikant requested a review from mukul1987 July 10, 2019 12:24

bshashikant added the ozone label Jul 10, 2019

supratimdeka approved these changes Jul 12, 2019

View reviewed changes

bshashikant added 2 commits July 12, 2019 17:18

Addressed review comments.

446cb7d

Fix few more failed tests by increasing the retry interval.

04f2adf

supratimdeka approved these changes Jul 15, 2019

View reviewed changes

Fixed leader election timeout value wic was causing test failures as …

420cca4

…well as ceckstyle issues.

Addressed Chheckstyle issues.

e8e074e

mukul1987 approved these changes Jul 18, 2019

View reviewed changes

bshashikant closed this Jul 18, 2019

bshashikant deleted the HDDS-1779 branch July 18, 2019 14:28

asfgit pushed a commit that referenced this pull request Jul 18, 2019

HDDS-1779. TestWatchForCommit tests are flaky.Contributed by Shashika…

8ef2365

…nt Banerjee. (#1071)

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019

SAMZA-2239 : Using jsonserde to write metadata file (apache#1071)

8621db6

* Using jsonserde to write metadata file * Getting rid of public static class

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1779. TestWatchForCommit tests are flaky.Contributed by Shashika…

37910ee

…nt Banerjee. (apache#1071)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1779. TestWatchForCommit tests are flaky. #1071

HDDS-1779. TestWatchForCommit tests are flaky. #1071

Uh oh!

bshashikant commented Jul 10, 2019

Uh oh!

supratimdeka left a comment

Uh oh!

Uh oh!

supratimdeka Jul 12, 2019

Uh oh!

bshashikant Jul 12, 2019

Uh oh!

hadoop-yetus commented Jul 12, 2019

Uh oh!

supratimdeka left a comment

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

hadoop-yetus commented Jul 18, 2019

Uh oh!

mukul1987 left a comment

Uh oh!

bshashikant commented Jul 18, 2019 •

edited

Loading

Uh oh!

Uh oh!

HDDS-1779. TestWatchForCommit tests are flaky. #1071

HDDS-1779. TestWatchForCommit tests are flaky. #1071

Uh oh!

Conversation

bshashikant commented Jul 10, 2019

Uh oh!

supratimdeka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

supratimdeka Jul 12, 2019

Choose a reason for hiding this comment

Uh oh!

bshashikant Jul 12, 2019

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 12, 2019

Uh oh!

supratimdeka left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

hadoop-yetus commented Jul 18, 2019

Uh oh!

mukul1987 left a comment

Choose a reason for hiding this comment

Uh oh!

bshashikant commented Jul 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bshashikant commented Jul 18, 2019 •

edited

Loading