You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RPC returns a denied reply, the code should not check for a verifier. It is a bug as it doesn't match the RPC protocol. (See Page 33 from NFS Illustrated book).
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1052
trunk passed
+1
compile
1183
trunk passed
+1
checkstyle
20
trunk passed
+1
mvnsite
29
trunk passed
+1
shadedclient
682
branch has no errors when building and testing our client artifacts.
+1
javadoc
22
trunk passed
0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
38
trunk passed
_ Patch Compile Tests _
+1
mvninstall
20
the patch passed
+1
compile
996
the patch passed
+1
javac
996
the patch passed
+1
checkstyle
24
the patch passed
+1
mvnsite
29
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
633
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1029
trunk passed
+1
compile
998
trunk passed
+1
checkstyle
21
trunk passed
+1
mvnsite
30
trunk passed
+1
shadedclient
694
branch has no errors when building and testing our client artifacts.
+1
javadoc
25
trunk passed
0
spotbugs
38
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
35
trunk passed
_ Patch Compile Tests _
+1
mvninstall
18
the patch passed
+1
compile
972
the patch passed
+1
javac
972
the patch passed
+1
checkstyle
17
the patch passed
+1
mvnsite
31
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
615
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1175
trunk passed
+1
compile
1067
trunk passed
+1
checkstyle
23
trunk passed
+1
mvnsite
32
trunk passed
+1
shadedclient
173
branch has no errors when building and testing our client artifacts.
+1
javadoc
27
trunk passed
0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
41
trunk passed
_ Patch Compile Tests _
+1
mvninstall
20
the patch passed
+1
compile
1046
the patch passed
+1
javac
1046
the patch passed
+1
checkstyle
24
the patch passed
+1
mvnsite
32
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
727
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1068
trunk passed
+1
compile
1031
trunk passed
+1
checkstyle
26
trunk passed
+1
mvnsite
29
trunk passed
+1
shadedclient
785
branch has no errors when building and testing our client artifacts.
+1
javadoc
27
trunk passed
0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
38
trunk passed
_ Patch Compile Tests _
+1
mvninstall
21
the patch passed
+1
compile
1009
the patch passed
+1
javac
1009
the patch passed
+1
checkstyle
25
the patch passed
+1
mvnsite
31
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
634
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1051
trunk passed
+1
compile
1051
trunk passed
+1
checkstyle
21
trunk passed
+1
mvnsite
25
trunk passed
+1
shadedclient
669
branch has no errors when building and testing our client artifacts.
+1
javadoc
25
trunk passed
0
spotbugs
38
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
37
trunk passed
_ Patch Compile Tests _
+1
mvninstall
17
the patch passed
+1
compile
989
the patch passed
+1
javac
989
the patch passed
+1
checkstyle
18
the patch passed
+1
mvnsite
26
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
637
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1180
trunk passed
+1
compile
1059
trunk passed
+1
checkstyle
19
trunk passed
+1
mvnsite
27
trunk passed
+1
shadedclient
689
branch has no errors when building and testing our client artifacts.
+1
javadoc
27
trunk passed
0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
40
trunk passed
_ Patch Compile Tests _
+1
mvninstall
18
the patch passed
+1
compile
1119
the patch passed
+1
javac
1119
the patch passed
+1
checkstyle
19
the patch passed
+1
mvnsite
28
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
632
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1406
trunk passed
+1
compile
1347
trunk passed
+1
checkstyle
32
trunk passed
+1
mvnsite
39
trunk passed
+1
shadedclient
907
branch has no errors when building and testing our client artifacts.
+1
javadoc
29
trunk passed
0
spotbugs
47
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
45
trunk passed
_ Patch Compile Tests _
+1
mvninstall
24
the patch passed
+1
compile
1079
the patch passed
+1
javac
1079
the patch passed
+1
checkstyle
24
the patch passed
+1
mvnsite
29
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
717
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1098
trunk passed
+1
compile
1031
trunk passed
+1
checkstyle
32
trunk passed
+1
mvnsite
37
trunk passed
+1
shadedclient
757
branch has no errors when building and testing our client artifacts.
+1
javadoc
34
trunk passed
0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
45
trunk passed
_ Patch Compile Tests _
+1
mvninstall
22
the patch passed
+1
compile
994
the patch passed
+1
javac
994
the patch passed
+1
checkstyle
31
the patch passed
+1
mvnsite
37
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
665
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1221
trunk passed
+1
compile
1211
trunk passed
+1
checkstyle
26
trunk passed
+1
mvnsite
32
trunk passed
+1
shadedclient
815
branch has no errors when building and testing our client artifacts.
+1
javadoc
26
trunk passed
0
spotbugs
45
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
41
trunk passed
_ Patch Compile Tests _
+1
mvninstall
23
the patch passed
+1
compile
1067
the patch passed
+1
javac
1067
the patch passed
+1
checkstyle
25
the patch passed
+1
mvnsite
31
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
753
patch has no errors when building and testing our client artifacts.
Author: Jacob Maes <jmaes@linkedin.com>
Reviewers: Prateek Maheshwari <pmaheshw@linkedin.com>,Xinyu Liu <xiliu@linkedin.com>
Closesapache#106 from jmakes/samza-1089-2
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RPC returns a denied reply, the code should not check for a verifier. It is a bug as it doesn't match the RPC protocol. (See Page 33 from NFS Illustrated book).