HDDS-1764. Fix hidden errors in acceptance tests #1059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit makes the original problem more visible. After the first build, the next commit will fix the problem itself. |
|
💔 -1 overall
This message was automatically generated. |
|
/retest |
|
I don't know what is the final answer to avoid similar problems (obviously, the intermittent test failures are very dangerous). As of now, I improved the error message (first commit). You can see the result in the acceptance tests of the first test: compose files are fixed in the second commit. |
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @elek for fixing this. The change LGTM. Can you resolve the conflicts? +1 after that. |
|
Thanks the review @xiaoyuyao I rebased it and will merge it soon. I cross-checked it with your PR (#1066) and found that I didn't notice ozonesecure-mr (which was also fixed in your patch). I also added this line of change. (ps: after committing the other patch with ozone-mr acceptance tests, it can be copied to support ozonesecure-mr to keep it stable....) |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…sks original exception Failures cleaning up the staging directory on another exception were masking the original exception making troubleshooting difficult. Add some logging and an extra try/catch around the cleanup. Author: thunderstumpges <tstumpges@ntent.com> Reviewers: Daniel Nishimura <dnishimura@linkedin.com> Closes apache#1059 from thunderstumpges/try-catch-on-staging-cleanup
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[~bharatviswa] pinged me offline with the problem that in some cases the smoketest is failing even if the reports are green:
The root cause is a few typo after HDDS-1698, which can be fixed with the uploaded PR.
What is the problem?
In case of any error during the test execution the smoketest is failed. In this case because the typo in two docker-compose.yaml files two of the tests can't be started.
But there is no separated robot test report and the error is visible only in the console.
How did it happen?
The ACL work improved some intermittency in the acceptance tests. HDDS-1698 is committed because the acceptance tests were failed with ACL errors which hide the real error (the test was red anyway).
See: https://issues.apache.org/jira/browse/HDDS-1764