Skip to content

HADOOP-16409. Allow authoritative mode on non-qualified paths. #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

mackrorysd
Copy link
Contributor

This addresses whitespace nits from Gabor's review of #1043, and allows non-qualified paths to be specified in the config.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1085 trunk passed
+1 compile 30 trunk passed
+1 checkstyle 23 trunk passed
+1 mvnsite 41 trunk passed
+1 shadedclient 684 branch has no errors when building and testing our client artifacts.
+1 javadoc 28 trunk passed
0 spotbugs 58 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 55 trunk passed
_ Patch Compile Tests _
+1 mvninstall 31 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
-0 checkstyle 16 hadoop-tools/hadoop-aws: The patch generated 1 new + 40 unchanged - 0 fixed = 41 total (was 40)
+1 mvnsite 32 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 707 patch has no errors when building and testing our client artifacts.
+1 javadoc 20 the patch passed
+1 findbugs 56 the patch passed
_ Other Tests _
+1 unit 285 hadoop-aws in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
3267
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/artifact/out/Dockerfile
GITHUB PR #1054
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux fff5b7977c40 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8965ddc
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1054/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link

@bgaborg bgaborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 3 nits with newlines, otherwise ok. will commit after those are cleared and I ran all the tests.

@bgaborg
Copy link

bgaborg commented Jul 8, 2019

Test result against ireland: 4 known testMRJob failures, no others.
+1 on this.

@bgaborg bgaborg merged commit de6b7bc into apache:trunk Jul 8, 2019
shanthoosh added a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…pache#1054)

* Fix zookeeper base path in standalone integration tests.

* Fix the version number in the executable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants