-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-9655: add a UT for lost applicationPriority in FederationInterceptor #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
Can you make the title a little more descriptive? |
|
@goiri Thanks. |
|
💔 -1 overall
This message was automatically generated. |
|
The title looks good. |
|
@goiri The actual priority default is 0. Because the error is NPE,so I just check that it is not null. |
|
We can still check for 0, right? |
|
sure, I fix it. delete check not null, add the actual priority |
…y in FederationInterceptor
|
🎊 +1 overall
This message was automatically generated. |
|
I'm confused now, don't we need: |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
apache#1036) * Adding a test case with case * Added few more boolean check test cases
|
💔 -1 overall
This message was automatically generated. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
I add a UT in TestFederationInterceptor#testAllocateResponse。