Skip to content

Conversation

@avijayanhwx
Copy link
Contributor

@avijayanhwx avijayanhwx commented Jun 28, 2019

…k while running a hadoop command to write to Ozone.

Metrics system needs to be initialized for the sink configs to be picked up.

Manually tested the change. After this change, if the hadoop-metrics2.properties contains properties like such, client metrics will be pushed to sink.

xceiverclientmetrics.period=10
xceiverclientmetrics.sink.<sink_name>.plugin.urls=/path/to/JAR
xceiverclientmetrics.sink.<sink_name>.interval=10

…k while running a hadoop command to write to Ozone.
@avijayanhwx
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Jun 28, 2019
@bharatviswa504
Copy link
Contributor

Hi @avijayanhwx
Thanks for the contribution.
Is there someplace, we can document this? so that it will be easy to find out this information.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 30 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 494 trunk passed
+1 compile 254 trunk passed
+1 checkstyle 73 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 840 branch has no errors when building and testing our client artifacts.
+1 javadoc 161 trunk passed
0 spotbugs 310 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 503 trunk passed
_ Patch Compile Tests _
+1 mvninstall 436 the patch passed
+1 compile 264 the patch passed
+1 javac 264 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 682 patch has no errors when building and testing our client artifacts.
+1 javadoc 159 the patch passed
+1 findbugs 531 the patch passed
_ Other Tests _
+1 unit 243 hadoop-hdds in the patch passed.
-1 unit 1195 hadoop-ozone in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
6163
Reason Tests
Failed junit tests hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.container.server.TestSecureContainerServer
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/1/artifact/out/Dockerfile
GITHUB PR #1034
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 37c53f8b9574 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 29465bf
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/1/testReport/
Max. process+thread count 5341 (vs. ulimit of 5500)
modules C: hadoop-hdds/client U: hadoop-hdds/client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 473 trunk passed
+1 compile 259 trunk passed
+1 checkstyle 73 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 853 branch has no errors when building and testing our client artifacts.
+1 javadoc 149 trunk passed
0 spotbugs 311 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 511 trunk passed
_ Patch Compile Tests _
+1 mvninstall 438 the patch passed
+1 compile 262 the patch passed
+1 javac 262 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 671 patch has no errors when building and testing our client artifacts.
+1 javadoc 161 the patch passed
+1 findbugs 516 the patch passed
_ Other Tests _
-1 unit 247 hadoop-hdds in the patch failed.
-1 unit 1258 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
6179
Reason Tests
Failed junit tests hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.container.server.TestSecureContainerServer
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/2/artifact/out/Dockerfile
GITHUB PR #1034
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6647914cd691 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d203045
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/2/testReport/
Max. process+thread count 5146 (vs. ulimit of 5500)
modules C: hadoop-hdds/client U: hadoop-hdds/client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1034/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

As discussed offline, @avijayanhwx will write a cwiki article to document the steps.

@bharatviswa504 bharatviswa504 merged commit 303a7f8 into apache:trunk Jul 17, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…emote table (apache#1034)

* SAMZA-2185: Added ability to expose remote store specific features in remote table
* Updated based on review comments
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
…k while running a hadoop command to write to Ozone. (apache#1034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants