-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-9643. Federation: Add subClusterID in nodes page of Router web #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
💔 -1 overall
This message was automatically generated. |
| YarnConfiguration.RM_RESOURCE_TRACKER_ADDRESS, | ||
| YarnConfiguration.DEFAULT_RM_RESOURCE_TRACKER_ADDRESS, | ||
| server.getListenerAddress()); | ||
| clusterId = conf.get(YarnConfiguration.RM_CLUSTER_ID, "default-cluster"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"default-cluster" should be a constant somewhere.
Probably "_DEFAULT".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @goiri , I will use YarnConfiguration.DEFAULT_RM_CLUSTER_ID
| } | ||
|
|
||
| @Override | ||
| public String getClusterID() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a test in TestNodesListManager
|
add constant and test. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| int usedMemory = (int) info.getUsedMemory(); | ||
| int availableMemory = (int) info.getAvailableMemory(); | ||
| TR<TBODY<TABLE<Hamlet>>> row = tbody.tr(); | ||
| row.td().__(info.getClusterId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you attach a screenshot with the end result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I lost the screenshot
In nodes page of router web, there only are node info, No cluster id corresponding to the node.