HDFS-13694. Making md5 computing being in parallel with image loading. #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 25, 2019
| void load(File file) throws IOException { | ||
| long start = Time.monotonicNow(); | ||
| imgDigest = MD5FileUtils.computeMd5ForFile(file); | ||
| FSImageFormatProtobuf.Loader.DigestThread dt = |
There was a problem hiding this comment.
Can you just use DigestThread? Instead of the full declaration.
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
| @@ -172,13 +172,55 @@ public LoaderContext getLoaderContext() { | |||
| return ctx; | |||
| } | |||
|
|
|||
| private class DigestThread extends Thread { | |||
There was a problem hiding this comment.
I think the common approach is to define this as static.
| @@ -172,13 +172,55 @@ public LoaderContext getLoaderContext() { | |||
| return ctx; | |||
| } | |||
|
|
|||
| private class DigestThread extends Thread { | |||
There was a problem hiding this comment.
Javadoc mentioning that this a thread for parallel MD5 computing to increase performance when loading.
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Outdated
Show resolved
Hide resolved
| if (t instanceof IOException) { | ||
| ioe = (IOException) t; | ||
| } else { | ||
| ioe = new IOException(t); |
There was a problem hiding this comment.
Do we have unit tests throwing these exceptions?
goiri
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
@goiri I have updated this patch as your comments. The exists unit test is coverage in this area.Could you have time to help review this patch? Thank you. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 26, 2019
| * a thread for parallel MD5 computing to increase performance when loading | ||
| */ | ||
| private static class DigestThread extends Thread { | ||
| volatile private IOException ioe = null; |
There was a problem hiding this comment.
Javadocs of the style:
/** Exception thrown when computing the diggest if it cannot be calculated. /
private volatile IOException ioe = null;
/* Calculated digest if there are no error. */
private volatile MD5Hash digest = null;
Note that I think the style says "private volatile"
| private static class DigestThread extends Thread { | ||
| volatile private IOException ioe = null; | ||
| volatile private MD5Hash digest = null; | ||
| private File file; |
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
leosunli
force-pushed
the
trunk
branch
2 times, most recently
from
3ac739c to
db3ca99
Compare
|
@goiri I have updated this patch. Could you continue to help review this patch? Thank you. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 27, 2019
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DigestThread{" + "ThreadName=" + getName() + ", digest=" |
| void load(File file) throws IOException { | ||
| long start = Time.monotonicNow(); | ||
| imgDigest = MD5FileUtils.computeMd5ForFile(file); | ||
| DigestThread dt = new DigestThread(file); | ||
| dt.setName(file.getName() + " computed MD5 Thread"); |
There was a problem hiding this comment.
You can do this setter and the daemon one in the constructor of the class.
The text should be something like "file.getName() + " MD5 compute"
(No need for the word Thread specifically.)
|
@goiri Thanks for your comments. I update this patch. Could you continue to review it? Thank you. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 28, 2019
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
Show resolved
Hide resolved
goiri
approved these changes
Jun 28, 2019
|
@goiri I have added Javadoc explaining the overall idea and updated patch.Could you help review this patch? Thank you again. |
|
💔 -1 overall
This message was automatically generated. |
|
Can we fix the checkstyle warnings? |
Signed-off-by: sunlisheng <sunlisheng@xiaomi.com>
|
💔 -1 overall
This message was automatically generated. |
|
Thank @goiri for your suggestion. I have fixed the checkstyle warnings. Could you have time to review this patch ? Thank you. |
goiri
approved these changes
Jul 2, 2019
|
LGTM |
|
Hi @goiri, If you think this patch no problem, could you help merge it to trunk ? Thank you. |
|
Merged and updated the JIRA. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
… from the coordinator stream. (apache#1010)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sunlisheng sunlisheng@xiaomi.com