Skip to content

HDDS-1719 : Increase ratis log segment size to 1MB. #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

avijayanhwx
Copy link
Contributor

While testing out ozone with long running clients which continuously write data, it was noted ratis logs were rolled 1-2 times every second. This adds unnecessary overhead to the pipeline thereby affecting write throughput. Increasing the size of the log segment to 1MB will decrease the overhead.

@avijayanhwx
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Jun 21, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 472 trunk passed
+1 compile 264 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 823 branch has no errors when building and testing our client artifacts.
+1 javadoc 160 trunk passed
0 spotbugs 302 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 494 trunk passed
_ Patch Compile Tests _
+1 mvninstall 423 the patch passed
+1 compile 268 the patch passed
+1 javac 268 the patch passed
+1 checkstyle 63 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 620 patch has no errors when building and testing our client artifacts.
+1 javadoc 161 the patch passed
+1 findbugs 520 the patch passed
_ Other Tests _
+1 unit 260 hadoop-hdds in the patch passed.
-1 unit 1196 hadoop-ozone in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
6031
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/1/artifact/out/Dockerfile
GITHUB PR #1005
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 498ebd5ab9f3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8194a11
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/1/testReport/
Max. process+thread count 4998 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 68 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 735 trunk passed
+1 compile 258 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 928 branch has no errors when building and testing our client artifacts.
+1 javadoc 162 trunk passed
0 spotbugs 331 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 539 trunk passed
_ Patch Compile Tests _
+1 mvninstall 468 the patch passed
+1 compile 260 the patch passed
+1 javac 260 the patch passed
+1 checkstyle 75 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 699 patch has no errors when building and testing our client artifacts.
+1 javadoc 156 the patch passed
+1 findbugs 524 the patch passed
_ Other Tests _
-1 unit 173 hadoop-hdds in the patch failed.
-1 unit 1593 hadoop-ozone in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
6938
Reason Tests
Failed junit tests hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestBCSID
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/2/artifact/out/Dockerfile
GITHUB PR #1005
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 9303dc1db644 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8194a11
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/2/testReport/
Max. process+thread count 5408 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1005/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@anuengineer anuengineer merged commit 81d2f1b into apache:trunk Jun 24, 2019
@anuengineer
Copy link
Contributor

@avijayanhwx Thanks for the contribution. @jiwq Thanks for the review. I have committed this patch to the trunk.

bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
* HDDS-1719 : Increase ratis log segment size to 1MB.

* HDDS-1719 : Increase ratis log segment size to 1MB.
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…for stores and side-input-stores

After Samza 1.1, the offset file for stores and sideinputs has been unified and is versioned.
However, this Jira adds the logic in code to read and write both this new and old format. Because of this apps can switch between 1.0 and 1.1 versions seamlessly.

Note that the old format and filenames for store and side-input offset differed.

Author: Ray Matharu <rmatharu@linkedin.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>

Closes apache#1005 from rmatharu/bugfix-offset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants