addressing review comments

apache · Aug 5, 2022 · e6292d5 · e6292d5
1 parent 127d230
commit e6292d5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...ject/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/IOStatisticsContext.java b/...ject/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/IOStatisticsContext.java
@@ -86,8 +86,8 @@ static void setThreadIOStatisticsContext(
    *
    * @return if the thread-level IO statistics enabled.
    */
-  static boolean getIOStatisticsThreadLevelEnabled() {
-    return IOStatisticsContextIntegration.getIOStatisticsThreadLevelEnabled();
+  static boolean enabled() {
+    return IOStatisticsContextIntegration.isIOStatisticsThreadLevelEnabled();
   }
 
 }
diff --git a/...on/src/main/java/org/apache/hadoop/fs/statistics/impl/IOStatisticsContextIntegration.java b/...on/src/main/java/org/apache/hadoop/fs/statistics/impl/IOStatisticsContextIntegration.java
@@ -85,7 +85,7 @@ public final class IOStatisticsContextIntegration {
    *
    * @return if the thread-level IO statistics enabled.
    */
-  public static boolean getIOStatisticsThreadLevelEnabled() {
+  public static boolean isIOStatisticsThreadLevelEnabled() {
     return isThreadIOStatsEnabled;
   }
 

diff --git a/...-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AIOStatisticsContext.java b/...-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AIOStatisticsContext.java
@@ -153,7 +153,8 @@ public void testS3AInputStreamIOStatisticsContext()
    * @return thread context
    */
   private static IOStatisticsContext getAndResetThreadStatisticsContext() {
-    assertTrue(IOStatisticsContext.getIOStatisticsThreadLevelEnabled());
+    assertTrue("thread-level IOStatistics should be enabled by default",
+        IOStatisticsContext.enabled());
     IOStatisticsContext context =
         IOStatisticsContext.getCurrentIOStatisticsContext();
     context.reset();