Skip to content

Commit

Permalink
Addendum HADOOP-17770 WASB : Support disabling buffered reads in posi…
Browse files Browse the repository at this point in the history
…tional reads - Added the invalid SpotBugs warning to findbugs-exclude.xml (#3223)
  • Loading branch information
anoopsjohn authored Jul 25, 2021
1 parent 4c35466 commit dd8e540
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,17 @@
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>

<!-- This field is instance of BlockBlobInputStream and read(long, byte[], int, int)
calls it's Super class method when 'fs.azure.block.blob.buffered.pread.disable'
is configured false. Super class FSInputStream's implementation is having
proper synchronization.
When 'fs.azure.block.blob.buffered.pread.disable' is true, we want a lock free
implementation of blob read. Here we don't use any of the InputStream's
shared resource (buffer) and also don't change any cursor position etc.
So its safe to go with unsynchronized way of read. -->
<Match>
<Class name="org.apache.hadoop.fs.azure.NativeAzureFileSystem$NativeAzureFsInputStream" />
<Field name="in" />
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>
</FindBugsFilter>

0 comments on commit dd8e540

Please sign in to comment.