HDFS-15931 : Fix non-static inner classes for better memory management (#2830). Contributed by Viraj Jasani

Signed-off-by: Mingliang Liu <liuml07@apache.org>

Author: virajjasani

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/MiniRouterDFSCluster.java

@@ -140,7 +140,7 @@ public class MiniRouterDFSCluster {
   /**
    * Router context.
    */
-  public class RouterContext {
+  public static class RouterContext {
     private Router router;
     private FileContext fileContext;
     private String nameserviceId;

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/blockaliasmap/impl/InMemoryLevelDBAliasMapClient.java

@@ -130,7 +130,7 @@ public Iterator<FileRegion> iterator() {
     }
   }
 
-  class LevelDbWriter extends BlockAliasMap.Writer<FileRegion> {
+  static class LevelDbWriter extends BlockAliasMap.Writer<FileRegion> {
 
     private InMemoryAliasMapProtocol aliasMap;
 

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/RamDiskReplicaLruTracker.java

@@ -35,7 +35,7 @@
 @InterfaceStability.Unstable
 public class RamDiskReplicaLruTracker extends RamDiskReplicaTracker {
 
-  private class RamDiskReplicaLru extends RamDiskReplica {
+  private static class RamDiskReplicaLru extends RamDiskReplica {
     long lastUsedTime;
 
     private RamDiskReplicaLru(String bpid, long blockId,
@@ -88,7 +88,7 @@ synchronized void addReplica(final String bpid, final long blockId,
     }
     RamDiskReplicaLru ramDiskReplicaLru =
         new RamDiskReplicaLru(bpid, blockId, transientVolume,
-                              lockedBytesReserved);
+            lockedBytesReserved);
     map.put(blockId, ramDiskReplicaLru);
     replicasNotPersisted.add(ramDiskReplicaLru);
   }

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ReencryptionHandler.java

@@ -835,7 +835,7 @@ protected void readUnlock() {
     }
   }
 
-  private class ZoneTraverseInfo extends TraverseInfo {
+  private static class ZoneTraverseInfo extends TraverseInfo {
     private String ezKeyVerName;
 
     ZoneTraverseInfo(String ezKeyVerName) {

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java

@@ -64,7 +64,7 @@ public class DebugAdmin extends Configured implements Tool {
   /**
    * All the debug commands we can run.
    */
-  private DebugCommand DEBUG_COMMANDS[] = {
+  private final DebugCommand[] DEBUG_COMMANDS = {
       new VerifyMetaCommand(),
       new ComputeMetaCommand(),
       new RecoverLeaseCommand(),
@@ -74,7 +74,7 @@ public class DebugAdmin extends Configured implements Tool {
   /**
    * The base class for debug commands.
    */
-  private abstract class DebugCommand {
+  private abstract static class DebugCommand {
     final String name;
     final String usageText;
     final String helpText;
@@ -93,15 +93,15 @@ private abstract class DebugCommand {
   /**
    * The command for verifying a block metadata file and possibly block file.
    */
-  private class VerifyMetaCommand extends DebugCommand {
+  private static class VerifyMetaCommand extends DebugCommand {
     VerifyMetaCommand() {
       super("verifyMeta",
-"verifyMeta -meta <metadata-file> [-block <block-file>]",
-"  Verify HDFS metadata and block files.  If a block file is specified, we" +
-    System.lineSeparator() +
-"  will verify that the checksums in the metadata file match the block" +
-    System.lineSeparator() +
-"  file.");
+          "verifyMeta -meta <metadata-file> [-block <block-file>]",
+          "  Verify HDFS metadata and block files.  If a block file is specified, we" +
+              System.lineSeparator() +
+              "  will verify that the checksums in the metadata file match the block" +
+              System.lineSeparator() +
+              "  file.");
     }
 
     int run(List<String> args) throws IOException {
@@ -209,7 +209,7 @@ int run(List<String> args) throws IOException {
   /**
    * The command for verifying a block metadata file and possibly block file.
    */
-  private class ComputeMetaCommand extends DebugCommand {
+  private static class ComputeMetaCommand extends DebugCommand {
     ComputeMetaCommand() {
       super("computeMeta",
           "computeMeta -block <block-file> -out <output-metadata-file>",

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java

@@ -562,7 +562,7 @@ protected MiniDFSCluster(Builder builder) throws IOException {
                        builder.useConfiguredTopologyMappingClass);
   }
 
-  public class DataNodeProperties {
+  public static class DataNodeProperties {
     final DataNode datanode;
     final Configuration conf;
     String[] dnArgs;