HDFS-15931. Fix non-static inner classes for better memory management #2830

virajjasani · 2021-03-29T06:33:26Z

Jira: https://issues.apache.org/jira/browse/HDFS-15931

virajjasani · 2021-03-29T12:41:10Z

Could you please take a look @ayushtkn @liuml07 ?

hadoop-yetus · 2021-03-29T14:43:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 44s		trunk passed
+1 💚	compile	5m 8s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 48s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 18s		trunk passed
+1 💚	mvnsite	1m 59s		trunk passed
+1 💚	javadoc	1m 29s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 13s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 37s		trunk passed
+1 💚	shadedclient	16m 39s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 45s		the patch passed
+1 💚	compile	5m 5s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	5m 5s		the patch passed
+1 💚	compile	4m 41s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 10s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 4 new + 225 unchanged - 9 fixed = 229 total (was 234)
+1 💚	mvnsite	1m 45s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 2s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 38s		the patch passed
+1 💚	shadedclient	17m 4s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	347m 2s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	23m 34s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		488m 52s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
	hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.federation.router.TestRouterFederationRename

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/1/artifact/out/Dockerfile
GITHUB PR	#2830
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 8d14cf9c4e52 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `56e6bb3`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/1/testReport/
Max. process+thread count	2044 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-03-30T02:51:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 55s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 18s		trunk passed
+1 💚	compile	5m 8s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 47s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 15s		trunk passed
+1 💚	mvnsite	1m 58s		trunk passed
+1 💚	javadoc	1m 28s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 21s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 32s		trunk passed
+1 💚	shadedclient	19m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	7m 57s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	7m 57s		the patch passed
+1 💚	compile	6m 26s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	6m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 12s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 4 new + 225 unchanged - 9 fixed = 229 total (was 234)
+1 💚	mvnsite	1m 46s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 8s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 36s		the patch passed
+1 💚	shadedclient	16m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	365m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	25m 36s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 0s		The patch does not generate ASF License warnings.
		518m 52s

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHdfsFileSystemContract
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.TestRollingUpgrade
	hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme
	hadoop.hdfs.server.namenode.TestFileTruncate
	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
	hadoop.hdfs.server.datanode.TestIncrementalBrVariations
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
	hadoop.hdfs.TestReconstructStripedFileWithValidator
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.federation.router.TestRouterFederationRename

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/2/artifact/out/Dockerfile
GITHUB PR	#2830
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux c44f97445a17 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `56e6bb3`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/2/testReport/
Max. process+thread count	1938 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-03-30T19:56:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 1s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 40s		trunk passed
+1 💚	compile	5m 10s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	5m 30s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 25s		trunk passed
+1 💚	mvnsite	2m 11s		trunk passed
+1 💚	javadoc	1m 43s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	5m 15s		trunk passed
+1 💚	shadedclient	17m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 45s		the patch passed
+1 💚	compile	4m 57s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	4m 57s		the patch passed
+1 💚	compile	4m 39s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 9s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 4 new + 225 unchanged - 9 fixed = 229 total (was 234)
+1 💚	mvnsite	1m 45s		the patch passed
+1 💚	javadoc	1m 17s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 46s		the patch passed
+1 💚	shadedclient	16m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	358m 42s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	25m 1s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 46s		The patch does not generate ASF License warnings.
		504m 42s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestIncrementalBrVariations
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.federation.router.TestRouterFederationRename
	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/3/artifact/out/Dockerfile
GITHUB PR	#2830
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 04083d160ce8 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `56e6bb3`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/3/testReport/
Max. process+thread count	2231 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-03-31T03:46:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 52s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 9s		trunk passed
+1 💚	compile	5m 12s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 48s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 17s		trunk passed
+1 💚	mvnsite	1m 59s		trunk passed
+1 💚	javadoc	1m 28s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 12s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 26s		trunk passed
+1 💚	shadedclient	16m 42s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 46s		the patch passed
+1 💚	compile	5m 8s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	5m 8s		the patch passed
+1 💚	compile	4m 46s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 46s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 9s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 4 new + 227 unchanged - 9 fixed = 231 total (was 236)
+1 💚	mvnsite	1m 46s		the patch passed
+1 💚	javadoc	1m 17s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 5s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 37s		the patch passed
+1 💚	shadedclient	16m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	338m 58s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	25m 13s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		482m 17s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.datanode.TestIncrementalBrVariations
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.TestLeaseRecovery2
	hadoop.hdfs.TestStateAlignmentContextWithHA
	hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.server.federation.router.TestRouterRpc
	hadoop.hdfs.server.federation.router.TestRouterFederationRename
	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/4/artifact/out/Dockerfile
GITHUB PR	#2830
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 3d4ded8980cf 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `56e6bb3`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/4/testReport/
Max. process+thread count	1991 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-03-31T13:18:22Z

Failed tests don't seem relevant. FYI @liuml07 @ayushtkn

hadoop-yetus · 2021-03-31T13:33:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 54s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 14s		trunk passed
+1 💚	compile	5m 11s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 46s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 16s		trunk passed
+1 💚	mvnsite	2m 1s		trunk passed
+1 💚	javadoc	1m 30s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 13s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 27s		trunk passed
+1 💚	shadedclient	17m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 56s		the patch passed
+1 💚	compile	5m 38s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	5m 38s		the patch passed
+1 💚	compile	4m 39s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 7s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 4 new + 225 unchanged - 9 fixed = 229 total (was 234)
+1 💚	mvnsite	1m 48s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 2s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 43s		the patch passed
+1 💚	shadedclient	17m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	371m 41s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	23m 17s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		514m 55s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestStateAlignmentContextWithHA
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.TestPersistBlocks
	hadoop.hdfs.TestLeaseRecovery
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.TestSnapshotCommands
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.TestHDFSFileSystemContract
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
	hadoop.hdfs.server.federation.router.TestRouterFederationRename

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/5/artifact/out/Dockerfile
GITHUB PR	#2830
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ac4c6c4ffb77 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `56e6bb3`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/5/testReport/
Max. process+thread count	2167 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2830/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

liuml07

+1

Will merge in 24 hours if no objection. I see no backward compatibility concerns so this will not need to be claimed "incompatible change".

virajjasani · 2021-04-01T06:06:16Z

@liuml07 Thanks for the review. Shall I create backport PRs till branch-3.1 / branch-2.10?

liuml07 · 2021-04-01T06:57:50Z

@virajjasani No i think it's safe to backport directly. No need for separate PRs. Thanks

liuml07 · 2021-04-01T23:38:40Z

@virajjasani Just saw you have multiple PRs recently. In Hadoop, the PR title and git commit subject have format:

HADOOP-12345. Fix foo. Contributed by Viraj

So the . instead of :. I personally am fine with either char, but looks like the convention is to have . instead of space and colon : to join the JIRA number and subject.

#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

virajjasani · 2021-04-02T05:34:51Z

@virajjasani Just saw you have multiple PRs recently. In Hadoop, the PR title and git commit subject have format:
HADOOP-12345. Fix foo. Contributed by Viraj
So the . instead of :. I personally am fine with either char, but looks like the convention is to have . instead of space and colon : to join the JIRA number and subject.

Thanks @liuml07 , I will take care of this going forward. One question: Contributed by user should be in PR title? Or that is something taken care of while merging PR?

liuml07 · 2021-04-02T05:41:48Z

Right right, the PR title is as this one shows now - without "Contributed by...".

HADOOP-12345. Fix foo.

When committing, this "Contributed by ..." will be added into subject/ title. I also seen people keep this in commit message.

My comment was more about : vs ..

virajjasani · 2021-04-02T06:25:18Z

Got it, Thanks. Updated PR title for #2844

virajjasani · 2021-04-02T06:26:56Z

My comment was more about : vs ..

Sure, definitely makes sense. My bad that I might have missed the convention somewhere.

apache#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

HDFS-15931 : Fix non-static inner classes for better memory management

56e6bb3

liuml07 approved these changes Mar 31, 2021

View reviewed changes

liuml07 merged commit 4f28738 into apache:trunk Apr 1, 2021

liuml07 changed the title ~~HDFS-15931 : Fix non-static inner classes for better memory management~~ HDFS-15931. Fix non-static inner classes for better memory management Apr 1, 2021

asfgit pushed a commit that referenced this pull request Apr 1, 2021

HDFS-15931 : Fix non-static inner classes for better memory management (

f707d84

#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

asfgit pushed a commit that referenced this pull request Apr 1, 2021

HDFS-15931 : Fix non-static inner classes for better memory management (

5458ebf

#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

asfgit pushed a commit that referenced this pull request Apr 2, 2021

HDFS-15931 : Fix non-static inner classes for better memory management (

739f70b

#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

asfgit pushed a commit that referenced this pull request Apr 2, 2021

HDFS-15931 : Fix non-static inner classes for better memory management (

3c1c1b4

#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15931 : Fix non-static inner classes for better memory management (

594d144

apache#2830). Contributed by Viraj Jasani Signed-off-by: Mingliang Liu <liuml07@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15931. Fix non-static inner classes for better memory management #2830

HDFS-15931. Fix non-static inner classes for better memory management #2830

Uh oh!

virajjasani commented Mar 29, 2021 •

edited

Loading

Uh oh!

virajjasani commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

hadoop-yetus commented Mar 31, 2021

Uh oh!

virajjasani commented Mar 31, 2021

Uh oh!

hadoop-yetus commented Mar 31, 2021

Uh oh!

liuml07 left a comment

Uh oh!

virajjasani commented Apr 1, 2021

Uh oh!

liuml07 commented Apr 1, 2021

Uh oh!

liuml07 commented Apr 1, 2021 •

edited

Loading

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

liuml07 commented Apr 2, 2021

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

Uh oh!

HDFS-15931. Fix non-static inner classes for better memory management #2830

HDFS-15931. Fix non-static inner classes for better memory management #2830

Uh oh!

Conversation

virajjasani commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

hadoop-yetus commented Mar 31, 2021

Uh oh!

virajjasani commented Mar 31, 2021

Uh oh!

hadoop-yetus commented Mar 31, 2021

Uh oh!

liuml07 left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Apr 1, 2021

Uh oh!

liuml07 commented Apr 1, 2021

Uh oh!

liuml07 commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

liuml07 commented Apr 2, 2021

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

virajjasani commented Apr 2, 2021

Uh oh!

Uh oh!

virajjasani commented Mar 29, 2021 •

edited

Loading

liuml07 commented Apr 1, 2021 •

edited

Loading