YARN-11536. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java

@@ -130,6 +130,9 @@ public class RouterCLI extends Configured implements Tool {
   private static final String XML_TAG_AMRMPOLICYWEIGHTS = "amrmPolicyWeights";
   private static final String XML_TAG_ROUTERPOLICYWEIGHTS = "routerPolicyWeights";
   private static final String XML_TAG_HEADROOMALPHA = "headroomAlpha";
+  private static final String XML_TAG_FEDERATION_WEIGHTS = "federationWeights";
+  private static final String XML_TAG_QUEUE = "queue";
+  private static final String XML_TAG_NAME = "name";
 
   public RouterCLI() {
     super();
@@ -341,10 +344,7 @@ private int handlePolicy(String[] args)
         "Currently, there are one supported file formats: XML." +
         "These files contain the policy information for storing queue policies.");
     Option fileOpt = new Option("f", "input-file", true,
-    // TODO: 格式
-        "Users can specify the file format using this option. " +
-        "Currently, there are two supported file formats: XML and JSON. " +
-        "These files contain the policy information for storing queue policies.");
+        "The location of the input configuration file. ");
     formatOpt.setOptionalArg(true);
 
     opts.addOption(saveOpt);
@@ -438,7 +438,7 @@ private int handBatchSavePolicies(String format, String policyFile) {
 
     switch (format) {
     case FORMAT_XML:
-      return parseXml2Policies(policyFile);
+      return parseXml2PoliciesAndBatchSavePolicies(policyFile);
     default:
       System.out.println("We currently only support XML formats.");
       return EXIT_ERROR;
@@ -487,7 +487,19 @@ protected SaveFederationQueuePolicyRequest parsePolicy(String policy) throws Yar
     return request;
   }
 
-  protected int parseXml2Policies(String policiesXml) {
+  /**
+   * Parse Policies from XML and save them in batches to FederationStateStore.
+   *
+   * We save 20 policies in one batch.
+   * If the user needs to save 1000 policies, it will cycle 50 times.
+   *
+   * Every time a page is saved, we will print whether a page
+   * has been saved successfully or failed.
+   *
+   * @param policiesXml Policies Xml Path.
+   * @return 0, success; 1, failed.
+   */
+  protected int parseXml2PoliciesAndBatchSavePolicies(String policiesXml) {
     try {
       List<FederationQueueWeight> federationQueueWeightsList = parsePoliciesByXml(policiesXml);
       MemoryPageUtils<FederationQueueWeight> memoryPageUtils = new MemoryPageUtils<>(20);
@@ -502,7 +514,7 @@ protected int parseXml2Policies(String policiesXml) {
         ResourceManagerAdministrationProtocol adminProtocol = createAdminProtocol();
         BatchSaveFederationQueuePoliciesResponse response =
             adminProtocol.batchSaveFederationQueuePolicies(request);
-        System.out.println("page<" + i + "> : " + response.getMessage());
+        System.out.println("page <" + (i + 1) + "> : " + response.getMessage());
       }
     } catch (Exception e) {
       LOG.error("BatchSaveFederationQueuePolicies error", e);
@@ -512,15 +524,15 @@ protected int parseXml2Policies(String policiesXml) {
 
   /**
    * Parse FederationQueueWeight from the xml configuration file.
-   *
+   * <p>
    * We allow users to provide an xml configuration file,
    * which stores the weight information of the queue.
    *
-   * @param policiesXml
-   * @return
-   * @throws IOException
-   * @throws SAXException
-   * @throws ParserConfigurationException
+   * @param policiesXml Policies Xml Path.
+   * @return FederationQueueWeight List.
+   * @throws IOException an I/O exception of some sort has occurred.
+   * @throws SAXException Encapsulate a general SAX error or warning.
+   * @throws ParserConfigurationException a serious configuration error..
    */
   protected List<FederationQueueWeight> parsePoliciesByXml(String policiesXml)
       throws IOException, SAXException, ParserConfigurationException {
@@ -532,23 +544,24 @@ protected List<FederationQueueWeight> parsePoliciesByXml(String policiesXml)
     DocumentBuilder builder = factory.newDocumentBuilder();
     Document document = builder.parse(xmlFile);
 
-    NodeList federationsList = document.getElementsByTagName("federationWeights");
+    NodeList federationsList = document.getElementsByTagName(XML_TAG_FEDERATION_WEIGHTS);
 
     for (int i = 0; i < federationsList.getLength(); i++) {
 
       Node federationNode = federationsList.item(i);
 
       if (federationNode.getNodeType() == Node.ELEMENT_NODE) {
         Element federationElement = (Element) federationNode;
-        NodeList queueList = federationElement.getElementsByTagName("queue");
+        NodeList queueList = federationElement.getElementsByTagName(XML_TAG_QUEUE);
 
         for (int j = 0; j < queueList.getLength(); j++) {
 
           Node queueNode = queueList.item(j);
           if (queueNode.getNodeType() == Node.ELEMENT_NODE) {
             Element queueElement = (Element) queueNode;
             // parse queueName.
-            String queueName = queueElement.getElementsByTagName("name").item(0).getTextContent();
+            String queueName = queueElement.getElementsByTagName(XML_TAG_NAME)
+                .item(0).getTextContent();
 
             // parse amrmPolicyWeights / routerPolicyWeights.
             String amrmWeight = parsePolicyWeightsNode(queueElement, XML_TAG_AMRMPOLICYWEIGHTS);
@@ -561,7 +574,7 @@ protected List<FederationQueueWeight> parsePoliciesByXml(String policiesXml)
             String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER,
                 YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER);
 
-            LOG.info("Queue: {}, AmrmPolicyWeights: {}, RouterWeight: {}, HeadroomAlpha: {}.",
+            LOG.debug("Queue: {}, AmrmPolicyWeights: {}, RouterWeight: {}, HeadroomAlpha: {}.",
                 queueName, amrmWeight, routerWeight, headroomAlpha);
 
             FederationQueueWeight weight = FederationQueueWeight.newInstance(routerWeight,